Created attachment 127637 [details] Screenshot. The OSD to determine how a second screen should be treated uses a blue color in its pictograms to symbolize windows. Those windows become invisible under the selection as it has the same color. SOFTWARE/OS VERSIONS Operating System: Manjaro Linux KDE Plasma Version: 5.18.4 KDE Frameworks Version: 5.69.0 Qt Version: 5.14.2
Urgh. This happens for every element of every icon that incorporates the selection color. Seems like a fundamental error to use this color in an icon. Either that, or the selection color should be made less intense in the center, as with the Plasma highlight effect or Noah's new selection patch.
Currently the class is ColorScheme-Highlight. We talked about changing it to ColorScheme-ButtonFocus, but that didn’t work everywhere (until now). I think it wouldn’t change the situation anyway, because it’s the same color. What about using just Focus? That could change during selection, if I understand it correctly. Currently, in the Breeze color scheme, it is also just the same color, so we need to change the Breeze color scheme there.
(In reply to David Hurka from comment #2) > Currently the class is ColorScheme-Highlight. We talked about changing it to > ColorScheme-ButtonFocus, but that didn’t work everywhere (until now). I > think it wouldn’t change the situation anyway, because it’s the same color. Yeah. > What about using just Focus? That could change during selection, if I > understand it correctly. Currently, in the Breeze color scheme, it is also > just the same color, so we need to change the Breeze color scheme there. That's a good idea. If it changes when selected, all we need to do is make sure the color gets changes to a contrasting color. This has the potential to fix other instances of the same issue in other places too.
(In reply to Nate Graham from comment #3) > This has the potential > to fix other instances of the same issue in other places too. Honestly, I think this is just a cosmetic issue, which isn’t relevant everywhere else. To mitigate that we could use a slightly darker shade for SelectionFocus.
Created attachment 146224 [details] After Breeze redesign I guess this is fixed after the 'Blue ocean' Breeze redesign? I can at least say that this works for me, but I'll wait for confirmation.
Yes, this should be effectively fixed now, both by the BLue Ocean changes to selection highlights, and also changes to Breeze Icons themselves to use the text color rather than the selection color for selected icons. However it turns out that some people don't like that effect; see Bug 446468.