Bug 440308 - Can't drag-and-drop apps anymore (e.g. for re-arranging, for dropping onto the desktop or panel, etc)
Summary: Can't drag-and-drop apps anymore (e.g. for re-arranging, for dropping onto th...
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Application Launcher (Kickoff) widget (show other bugs)
Version: 5.22.90
Platform: Other Linux
: VHI normal
Target Milestone: 1.0
Assignee: Noah Davis
URL:
Keywords: regression
: 442655 442797 443066 443182 443442 (view as bug list)
Depends on:
Blocks: 439915
  Show dependency tree / graph
 
Reported: 2021-07-26 19:30 UTC by Nate Graham
Modified: 2021-10-07 20:57 UTC (History)
9 users (show)

See Also:
Latest Commit: https://invent.kde.org/plasma/plasma-desktop/commit/47697dce9bc9d443bb5b79869e434ca93d829830
Version Fixed In: 5.23
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Nate Graham 2021-07-26 19:30:19 UTC 
After the big code refactor in https://invent.kde.org/plasma/plasma-desktop/-/commit/9d9c4f169ed424e976636a6d5fa23c7a1e40576b landed, I can't drag favorited apps to re-arrange them anymore.

Both grid view and list view are affected, though I didn't use list view before, so I don't know if drag-re-ordering used to work there. But I know it used to work for grid view and it's broken now.
Comment 1 Nate Graham 2021-07-26 19:31:06 UTC 
Noah, can you investigate?
Comment 2 Noah Davis 2021-07-26 19:46:39 UTC 
(In reply to Nate Graham from comment #1)
> Noah, can you investigate?

will do. I think I forgot to re-add this.
Comment 3 Nate Graham 2021-08-03 19:23:17 UTC 
This also blocks dragging apps anywhere else, e.g. to the desktop or the panel.
Comment 4 Mikel Johnson 2021-09-06 11:24:22 UTC 
ping? this is pretty important
Comment 5 Nate Graham 2021-09-21 22:03:50 UTC 
*** Bug 442655 has been marked as a duplicate of this bug. ***
Comment 6 David Edmundson 2021-09-22 11:38:34 UTC 
*** Bug 442797 has been marked as a duplicate of this bug. ***
Comment 7 Nate Graham 2021-09-27 16:44:35 UTC 
In progress with https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/573.
Comment 8 Patrick Silva 2021-09-28 17:59:48 UTC 
*** Bug 443066 has been marked as a duplicate of this bug. ***
Comment 9 Patrick Silva 2021-10-01 01:55:25 UTC 
*** Bug 443182 has been marked as a duplicate of this bug. ***
Comment 10 Noah Davis 2021-10-06 17:07:06 UTC 
Git commit fd49cc02d18360963198abb4c53057483379968f by Noah Davis.
Committed on 06/10/2021 at 17:01.
Pushed by ndavis into branch 'master'.

kickoff: re-add drag and drop for favorites

M  +2    -2    applets/kickoff/package/contents/ui/ApplicationsPage.qml
A  +20   -0    applets/kickoff/package/contents/ui/DropAreaGridView.qml     [License: LGPL(v2.0+)]
A  +20   -0    applets/kickoff/package/contents/ui/DropAreaListView.qml     [License: LGPL(v2.0+)]
M  +0    -8    applets/kickoff/package/contents/ui/FullRepresentation.qml
M  +0    -2    applets/kickoff/package/contents/ui/Kickoff.qml
A  +46   -0    applets/kickoff/package/contents/ui/KickoffDropArea.qml     [License: LGPL(v2.0+)]
M  +22   -13   applets/kickoff/package/contents/ui/KickoffGridView.qml
M  +61   -11   applets/kickoff/package/contents/ui/KickoffItemDelegate.qml
M  +27   -3    applets/kickoff/package/contents/ui/KickoffListView.qml
M  +13   -0    applets/kickoff/package/contents/ui/KickoffSingleton.qml
M  +1    -0    applets/kickoff/package/contents/ui/PlacesPage.qml

https://invent.kde.org/plasma/plasma-desktop/commit/fd49cc02d18360963198abb4c53057483379968f
Comment 11 Noah Davis 2021-10-06 17:11:24 UTC 
Git commit 47697dce9bc9d443bb5b79869e434ca93d829830 by Noah Davis.
Committed on 06/10/2021 at 17:10.
Pushed by ndavis into branch 'Plasma/5.23'.

kickoff: re-add drag and drop for favorites
(cherry picked from commit fd49cc02d18360963198abb4c53057483379968f)

M  +2    -2    applets/kickoff/package/contents/ui/ApplicationsPage.qml
A  +20   -0    applets/kickoff/package/contents/ui/DropAreaGridView.qml     [License: LGPL(v2.0+)]
A  +20   -0    applets/kickoff/package/contents/ui/DropAreaListView.qml     [License: LGPL(v2.0+)]
M  +0    -8    applets/kickoff/package/contents/ui/FullRepresentation.qml
M  +0    -2    applets/kickoff/package/contents/ui/Kickoff.qml
A  +46   -0    applets/kickoff/package/contents/ui/KickoffDropArea.qml     [License: LGPL(v2.0+)]
M  +22   -13   applets/kickoff/package/contents/ui/KickoffGridView.qml
M  +61   -11   applets/kickoff/package/contents/ui/KickoffItemDelegate.qml
M  +27   -3    applets/kickoff/package/contents/ui/KickoffListView.qml
M  +13   -0    applets/kickoff/package/contents/ui/KickoffSingleton.qml
M  +1    -0    applets/kickoff/package/contents/ui/PlacesPage.qml

https://invent.kde.org/plasma/plasma-desktop/commit/47697dce9bc9d443bb5b79869e434ca93d829830
Comment 12 Nate Graham 2021-10-07 20:57:26 UTC 
*** Bug 443442 has been marked as a duplicate of this bug. ***