Bug 434969 - Soft Proofing not working entirely, making the canvas transparent or glitchy. 5.0 pre alpha
Summary: Soft Proofing not working entirely, making the canvas transparent or glitchy....
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Color models (show other bugs)
Version: nightly build (please specify the git hash!)
Platform: Microsoft Windows Microsoft Windows
: NOR normal
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords: regression, release_blocker
: 435098 435182 435955 437132 (view as bug list)
Depends on:
Blocks:
 
Reported: 2021-03-26 12:25 UTC by Diogo
Modified: 2021-12-14 20:07 UTC (History)
7 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Diogo 2021-03-26 12:25:28 UTC
SUMMARY
With canvas acceleration the soft proofing doesn't work all the time.  Most of the time it will make the image (all layers) transparent, some times it 
will be glitchy.  Video here: https://streamable.com/h270i9

With the canvas acceleration OFF the soft proof does nothing.

It happens with any model, CMYK, Grayscale, XYZ...  and any profile.

Works perfectly in the stable

STEPS TO REPRODUCE
1. View > Soft Proofing  or CTRL+Y
2. 
3. 

OBSERVED RESULT



EXPECTED RESULT


SOFTWARE/OS VERSIONS
Windows: 10
macOS: 
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 
Qt Version: 

ADDITIONAL INFORMATION
Comment 1 Halla Rempt 2021-03-26 12:28:20 UTC
Does it matter if you enable or disable Angle?
Comment 2 wolthera 2021-03-26 12:32:58 UTC
This may also be related to the fastfloat plugin not working right with clut profiles.

https://github.com/mm2/Little-CMS/issues/247

You can try turning off the 'LCMS optimizations' in settings->configure Krita->color management and then restarting Krita.
Comment 3 Diogo 2021-03-26 12:47:36 UTC
(In reply to Halla Rempt from comment #1)
> Does it matter if you enable or disable Angle?

Same behavior with Angle, OpenGL, and Software render

The only thing that makes a difference is the graphic acceleration. With it activated soft proofing works as shown in the video, if deactivated nothing happens (the ON/OFF indicator appears but there is no change).
Comment 4 Halla Rempt 2021-03-26 13:01:58 UTC
OKay, then wolthera's hypothesis is the most likely.
Comment 5 Diogo 2021-03-26 13:28:00 UTC
(In reply to wolthera from comment #2)
> This may also be related to the fastfloat plugin not working right with clut
> profiles.
> 
> https://github.com/mm2/Little-CMS/issues/247
> 
> You can try turning off the 'LCMS optimizations' in settings->configure
> Krita->color management and then restarting Krita.


I disabled "Allow Little CMS optimizations..." and restarted. Unfortunately it had no effect, the problem persists.

I'm downloading the most recent nightly to test.  I'm using yesterday's build
Comment 6 Lynx3d 2021-03-26 14:17:59 UTC
I'm seeing this issue here too with LCMS "fast float" plugin on (K)Ubuntu 20.04.
Interestingly, 16 bits/channel images don't seem to be affected, for those soft proofing to grey/alpha and CMYK works fine for me.

Unchecking "Allow Little CMS optimizations" in Color Management settings (and relaunching Krita) does not make a difference here either, but I haven't checked yet if that setting even affects soft proofing...
Neither does disabling vector optimization fix the issue, which is the only place I can think of right now where we might violate strict aliasing rules.

In any case, I'd also say it is that very issue Wolthera filed for LittleCMS.
Comment 7 tomtomtomreportingin 2021-03-29 09:59:27 UTC
*** Bug 435098 has been marked as a duplicate of this bug. ***
Comment 8 Halla Rempt 2021-03-31 11:30:29 UTC
*** Bug 435182 has been marked as a duplicate of this bug. ***
Comment 9 acc4commissions 2021-04-08 07:08:20 UTC
I noticed the same symptom occurs when using transform tool too. But I cannot catch when exactly it happens.
Comment 10 wolthera 2021-04-10 11:57:08 UTC
Marking this as release blocker, as the person who was going to look into it got drafted into building Krita with MSVC.
Comment 11 Nikola 2021-05-11 12:26:50 UTC
in  Version: 5.0.0-prealpha (git dac7f75) , the canvas rendering issue is fixed on my end.
Comment 12 wolthera 2021-05-11 12:31:48 UTC
(In reply to Nikola from comment #11)
> in  Version: 5.0.0-prealpha (git dac7f75) , the canvas rendering issue is
> fixed on my end.

I want to say 'that's impossible', but I can also not reproduce it now. O_O
Comment 13 wolthera 2021-05-11 12:47:53 UTC
Nope, still relevant, I had forgotten I need to use the appimage because the special LCMS version that has the feature that causes the bug is not yet in the repositories.
Comment 14 Nikola 2021-05-11 12:52:10 UTC
No idea why and how.
I haven't updated windows, nor drivers.
I even tried on older nightly versions that had the issue, and that I downloaded, but didn't delete. Oddly even those appear to work now.
The only difference I can see was that almost all brushes I had were not there in the Version: 5.0.0-prealpha (git dac7f75). While the previous nightly builds that had this issue have the brushes. That's the only change I saw when I tried this latest nightly version.
Comment 15 Ahab Greybeard 2021-05-20 07:43:12 UTC
*** Bug 437132 has been marked as a duplicate of this bug. ***
Comment 16 wolthera 2021-05-26 16:01:09 UTC
It seems that the latest LCMS fixes this bug, so now we need to ensure our deps are updated.
Comment 17 acc4commissions 2021-05-26 22:34:56 UTC
I cannot wait this bug to be fixed.
Comment 18 Bug Janitor Service 2021-05-31 20:49:13 UTC
A possibly relevant merge request was started @ https://invent.kde.org/graphics/krita/-/merge_requests/871
Comment 19 Halla Rempt 2021-06-01 08:46:56 UTC
Git commit 213e6cb4b37052075f44ea94fc0350167b0de627 by Halla Rempt, on behalf of L. E. Segovia.
Committed on 01/06/2021 at 08:46.
Pushed by rempt into branch 'master'.

Incorporate LittleCMS Soft Proofing fixes

This updates LittleCMS to commit
807809d7dd9b09c0380b71d5d5ebee3c1439ca99, using Github's tarball.
CCMAIL: kimageshop@kde.org

M  +2    -2    3rdparty/ext_lcms2/CMakeLists.txt

https://invent.kde.org/graphics/krita/commit/213e6cb4b37052075f44ea94fc0350167b0de627
Comment 20 acc4commissions 2021-06-02 10:23:28 UTC
It's still happening in teh latest git b5849f6. Is it that the patch hasn't been appiled yet?
Comment 21 wolthera 2021-06-02 10:25:50 UTC
Yeah, Lynx3d has found another possible fix. I am unsure what is going on that I wasn't experiencing the error anymore.

https://github.com/mm2/Little-CMS/issues/247

We'll have to wait a bit further.
Comment 22 Bug Janitor Service 2021-06-07 19:03:25 UTC
A possibly relevant merge request was started @ https://invent.kde.org/graphics/krita/-/merge_requests/895
Comment 23 Halla Rempt 2021-06-08 06:07:41 UTC
Git commit c75c77d10cd1d786d7e142bd27e487ace7ffeecc by Halla Rempt, on behalf of L. E. Segovia.
Committed on 08/06/2021 at 06:07.
Pushed by rempt into branch 'master'.

Update LittleCMS

Bring in the hotfixes for the Soft Proofing mode.

Thanks to Alvin Wong.

M  +2    -2    3rdparty/ext_lcms2/CMakeLists.txt

https://invent.kde.org/graphics/krita/commit/c75c77d10cd1d786d7e142bd27e487ace7ffeecc
Comment 24 acc4commissions 2021-06-08 10:29:11 UTC
Yes, it's fixed. Now I can finally switch to using nightly builds :D
Thanks for all the works.
Comment 25 Will Stephenson 2021-12-14 20:07:01 UTC
*** Bug 435955 has been marked as a duplicate of this bug. ***