Bug 432372 - FormLayout text gets elided too early when using a fractional font size
Summary: FormLayout text gets elided too early when using a fractional font size
Status: CLOSED UPSTREAM
Alias: None
Product: frameworks-kirigami
Classification: Frameworks and Libraries
Component: general (show other bugs)
Version: 5.78.0
Platform: Kubuntu Linux
: NOR normal
Target Milestone: 1.0
Assignee: Marco Martin
URL: https://bugreports.qt.io/browse/QTBUG...
Keywords:
: 414418 437077 437762 439271 441177 442343 443950 444181 449201 453303 453419 (view as bug list)
Depends on:
Blocks:
 
Reported: 2021-02-01 09:50 UTC by Usarin Heininga
Modified: 2022-05-13 06:41 UTC (History)
12 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
Screenshot (324.16 KB, image/png)
2021-02-01 09:50 UTC, Usarin Heininga
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Usarin Heininga 2021-02-01 09:50:13 UTC
Created attachment 135347 [details]
Screenshot

SUMMARY


STEPS TO REPRODUCE
1. open the font settings page.
2. change the font size to any size with a half, 10.5 or 11.5.

OBSERVED RESULT
All QML based widgets don't reserve enough space for the text.
Apparently the internal algorithm works with a rounded down value to resize the widgets.

EXPECTED RESULT
All qml based widgets should reserve enough space for the text.

SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: Ubuntu Hirsute
(available in About System)
KDE Plasma Version: 5.20.90
KDE Frameworks Version: 5.78
Qt Version: 5.15

ADDITIONAL INFORMATION

This is also the case in Ubuntu Focal and Groovy.
Comment 1 Nate Graham 2021-02-01 17:19:02 UTC
Can confirm. Seems like an issue with the Kirigami FormLayout component.
Comment 2 Usarin Heininga 2021-03-19 11:09:22 UTC
I have just investigated this bug, but unfortunately it's a QT bug.
I reported the bug at QT https://bugreports.qt.io/browse/QTBUG-92006.
So this means that this won't get fixed very soon. Not until QT6 i guess.
I have been able to fix it by hacking some of the default plasma controls.
But this doesn't work everywhere. The latte-dock configuration widgets use plain QtQuick 1 controls for example and those will not be affected by anything that KDE does, Right?
Comment 3 Nate Graham 2021-03-19 13:45:52 UTC
Darn. Thanks for the investigation!
Comment 4 Nate Graham 2021-05-28 16:50:13 UTC
*** Bug 437762 has been marked as a duplicate of this bug. ***
Comment 5 Patrick Silva 2021-06-29 21:46:02 UTC
*** Bug 439271 has been marked as a duplicate of this bug. ***
Comment 6 Safa Alfulaij 2021-08-20 04:38:39 UTC
*** Bug 441177 has been marked as a duplicate of this bug. ***
Comment 7 Nate Graham 2021-08-29 16:46:57 UTC
*** Bug 414418 has been marked as a duplicate of this bug. ***
Comment 8 Nate Graham 2021-08-29 16:58:07 UTC
*** Bug 437077 has been marked as a duplicate of this bug. ***
Comment 9 Nate Graham 2021-09-16 17:10:18 UTC
*** Bug 442343 has been marked as a duplicate of this bug. ***
Comment 10 Szczepan Hołyszewski 2021-09-28 14:04:48 UTC
Th.. Qt tea... shou... definit... alloc... mo... resou... to fixi... thi... bu... .
Comment 11 Nate Graham 2021-10-18 16:33:47 UTC
*** Bug 443950 has been marked as a duplicate of this bug. ***
Comment 12 Patrick Silva 2021-10-21 13:13:43 UTC
*** Bug 444181 has been marked as a duplicate of this bug. ***
Comment 13 Nate Graham 2022-01-28 19:41:41 UTC
*** Bug 449201 has been marked as a duplicate of this bug. ***
Comment 14 Szczepan Hołyszewski 2022-02-10 14:40:41 UTC
I believe that once it has been established that "upstream" has a bug that won't be fixed in foreseeable future, but "application" and its users continually suffer from the bug, then "application" should try to come up with a workaround instead of telling users that they will have to wait indefinitely for the bug to be fixed upstream.

KDE is the "application" here.
Comment 15 Nate Graham 2022-02-10 14:44:49 UTC
Please don't re-open bug marked RESOLVED UPSTREAM reports because you want a local workaround.

In this case I don't believe a local workaround is easily possible. We could prevent the ability to set fractional font sizes i the fong dialog, but I don't think that would make people very happy. :)
Comment 16 Patrick Silva 2022-05-02 18:01:19 UTC
*** Bug 453303 has been marked as a duplicate of this bug. ***
Comment 17 ianp 2022-05-02 18:32:00 UTC
Bug 453303, now marked as duplicate of this one, suggests "adding a warning to the Font settings". Closing bug 432372 did not save me wasting time on reporting this defect, nor others managing the duplicate bug. Either add a permanent label next to the settings or add a reactive pop up when a half point size is used.
Comment 18 Nate Graham 2022-05-02 18:41:45 UTC
Sure, that seems reasonable. I'll look into it.
Comment 19 Nate Graham 2022-05-02 20:43:03 UTC
Git commit 9d0a71d7e514cb4a11649464e8e867b2ce39e106 by Nate Graham.
Committed on 02/05/2022 at 20:42.
Pushed by ngraham into branch 'master'.

kcms/fonts: show warning when user tries to set a non-integer font size

It triggers https://bugreports.qt.io/browse/QTBUG-92006, and we need to
warn users about that.

M  +23   -0    kcms/fonts/package/contents/ui/main.qml

https://invent.kde.org/plasma/plasma-workspace/commit/9d0a71d7e514cb4a11649464e8e867b2ce39e106
Comment 20 Nate Graham 2022-05-05 22:09:25 UTC
*** Bug 453419 has been marked as a duplicate of this bug. ***
Comment 21 Usarin Heininga 2022-05-12 18:41:37 UTC
This bug has been fixed in QT 6.2.5 according to https://bugreports.qt.io/browse/QTBUG-92006
Is it possible to include it in the KDE QT patch collection?
Comment 22 Nate Graham 2022-05-12 18:44:25 UTC
Could be feasible. Feel free to send a merge request to do it. See https://community.kde.org/Qt5PatchCollection#How_do_I_get_a_patch_merged.3F
Comment 23 Usarin Heininga 2022-05-13 06:41:10 UTC
Haha, not the answer I was hoping for.
But I'll give it a try this weekend, I don't promise anything.
I'm short on time currently and not familiar with the QT codebase.

Regards,

Usarin Heininga