Bug 430622 - Panel applet margins are bigger with compositing turned on than with it turned off
Summary: Panel applet margins are bigger with compositing turned on than with it turne...
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Panel (show other bugs)
Version: 5.20.4
Platform: Neon Linux
: HI normal
Target Milestone: 1.0
Assignee: veggero
URL:
Keywords: regression
: 431653 434233 (view as bug list)
Depends on:
Blocks:
 
Reported: 2020-12-20 13:48 UTC by Serdar Tasel
Modified: 2021-03-12 15:07 UTC (History)
7 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.81


Attachments
Icon size (15.56 KB, image/png)
2020-12-20 13:48 UTC, Serdar Tasel
Details
with compositing (10.12 KB, image/png)
2021-01-12 18:11 UTC, Anthony Vital
Details
without compositing (8.94 KB, image/png)
2021-01-12 18:12 UTC, Anthony Vital
Details
Icon size 2 (30.59 KB, image/png)
2021-02-17 09:37 UTC, Serdar Tasel
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Serdar Tasel 2020-12-20 13:48:45 UTC
Created attachment 134227 [details]
Icon size

SUMMARY
The icons on the panel appear smaller than usual. After some logout/login cycle, they appear in normal size again. Then, they become smaller again after repeating logout/login. See the attachment.

In my system, normally, icons should exactly fit into panel when the panel height is 36. If the height is decreased, the icons get smaller in order to fit.

In buggy case, the panel height must be at least 40 to make icons appear as in normal case.

STEPS TO REPRODUCE
1. Add some icons onto panel and set panel height to 36.
2. Repeat logout/login cycle to observe the bug.

OBSERVED RESULT
Icons on the panel appear smaller than usual frequently. They appear normally sometimes.

EXPECTED RESULT
Size of panel icons should be stable and the behavior should not change by logging in / rebooting.

SOFTWARE/OS VERSIONS
Linux: KDE neon 5.20
KDE Plasma Version: 5.20.4
KDE Frameworks Version: 5.77.0
Qt Version: 5.15.2
Comment 1 Serdar Tasel 2020-12-20 14:00:52 UTC
Toggling the compositor (ALT+SHIFT+F12) also cause the icons' size to change.
Comment 2 Simon Vogl 2020-12-20 15:37:26 UTC
I'm experiencing this too on ArchLinux, +1 from my side.
Comment 3 Simon Vogl 2020-12-29 13:21:58 UTC
Any updates on this?
I've tested some more and the bug is also reproducible in Debian Experimental, it would be unfortunate if the bug would make it into e.g. Ubuntu 21.04
Comment 4 Nate Graham 2021-01-05 17:36:53 UTC
Cannot reproduce at any panel size or when toggling compositing. Is your panel changing height on login or something?

I wonder if this could be a different manifestation of Bug 430390.

For anyone experiencing it, could you try upgrading to Frameworks 5.78 and seeing if it still happens? Thanks!
Comment 5 Nate Graham 2021-01-12 01:33:05 UTC
Someone else reported this at https://www.reddit.com/r/kde/comments/kuyqbk/after_upgrading_to_frameworks_578_icons_in_the/ using Frameworks 5.78. Seems like it is not the same issue as Bug 430390; re-opening.

Still cannot reproduce.
Comment 6 Nate Graham 2021-01-12 01:43:34 UTC
Oh shoot, I bet this is a regression caused by changes to panel margins in frameworks when run without the corresponding changes in Plasma 5.21. If I'm right, the good news is that it will be fixed automatically in Plasma 5.21, but the bad news is that it's unfixable for people in Plasma 5.20.

Let me test that theory...
Comment 7 Serdar Tasel 2021-01-12 07:35:54 UTC
Upgraded to KDE Frameworks 5.78, now the icon size does not change by logging in/out cycle. However, icons still appear smaller than usual. They appear normally when the compositor is disabled. In my system, the panel does not change its size but the margins in the panel are increased (thus squeezing icons) when the compositor is enabled.
Comment 8 Daniel 2021-01-12 09:00:42 UTC
A quick workaround is to increase the panel height by 4, this worked for me and others in the linked reddit thread.
Comment 9 Nate Graham 2021-01-12 16:13:06 UTC
Hmm, no, there goes my theory. With Plasma 5.20.5 and Frameworks 5.78, I can't reproduce the issue of margins changing when toggling compositing on and off. Can you still reproduce this?
Comment 10 Anthony Vital 2021-01-12 18:10:38 UTC
I can reproduce this with Plasma 5.20.5 and Frameworks 5.78.
Comment 11 Anthony Vital 2021-01-12 18:11:26 UTC
Created attachment 134787 [details]
with compositing
Comment 12 Anthony Vital 2021-01-12 18:12:01 UTC
Created attachment 134788 [details]
without compositing
Comment 13 Nate Graham 2021-01-12 20:36:10 UTC
Thanks, I believe you. However I am very confused by not being able to reproduce the issue on Plasma 5.20.5 with Frameworks 5.78.
Comment 14 Nate Graham 2021-01-12 20:37:07 UTC
Niccolò, any ideas?
Comment 15 Nate Graham 2021-01-12 21:31:01 UTC
Niccolò says he knows what the problem is and how to fix it! Assigning it to him.
Comment 16 Nate Graham 2021-01-14 19:02:19 UTC
*** Bug 430556 has been marked as a duplicate of this bug. ***
Comment 17 Nate Graham 2021-01-15 21:12:53 UTC
*** Bug 431653 has been marked as a duplicate of this bug. ***
Comment 18 Bug Janitor Service 2021-01-28 10:28:39 UTC
A possibly relevant merge request was started @ https://invent.kde.org/frameworks/plasma-framework/-/merge_requests/191
Comment 19 Serdar Tasel 2021-02-17 09:37:19 UTC
Created attachment 135755 [details]
Icon size 2
Comment 20 Serdar Tasel 2021-02-17 09:38:04 UTC
Apparently, the problem persists with the update to Plasma version 5.21. Morever, the space between icons increased. Disabling compositor changes the icon size to the expected height as the spacing between icons remain.
Comment 21 The Feren OS Dev 2021-03-11 20:10:56 UTC
*** Bug 434233 has been marked as a duplicate of this bug. ***
Comment 22 Nate Graham 2021-03-12 15:07:39 UTC
Fixed by Niccolò Venerandi with https://invent.kde.org/frameworks/plasma-framework/-/commit/2f48e808d5e6c44a1f82d59f98d1cf8286b8bfb1 in Frameworks 5.81!