Bug 428164 - Adding new category from menu bar
Summary: Adding new category from menu bar
Status: RESOLVED FIXED
Alias: None
Product: kmymoney
Classification: Applications
Component: general (show other bugs)
Version: 5.0.6
Platform: Microsoft Windows Microsoft Windows
: NOR normal
Target Milestone: ---
Assignee: KMyMoney Devel Mailing List
URL:
Keywords:
: 418248 (view as bug list)
Depends on:
Blocks:
 
Reported: 2020-10-24 03:42 UTC by ralph.goddard@outlook.com
Modified: 2021-06-20 16:17 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.1.1
Sentry Crash Report:


Attachments
0DCC0D3C3617443DB60E40719114DDE0.jpg (93.92 KB, image/jpeg)
2020-10-24 22:52 UTC, ralph.goddard@outlook.com
Details
551C7CFE1FB04C77BB01CC63A8D9B85E.jpg (88.72 KB, image/jpeg)
2020-10-24 22:52 UTC, ralph.goddard@outlook.com
Details
BD57EDF6CA254B0EB1FD96A457A67176.jpg (86.91 KB, image/jpeg)
2020-10-24 22:52 UTC, ralph.goddard@outlook.com
Details
attachment-1351-0.html (4.02 KB, text/html)
2020-10-24 22:54 UTC, ralph.goddard@outlook.com
Details
attachment-1744-0.html (4.16 KB, text/html)
2020-10-24 23:04 UTC, ralph.goddard@outlook.com
Details
5.1 error message (23.28 KB, image/jpeg)
2020-10-26 20:02 UTC, ralph.goddard@outlook.com
Details
attachment-25717-0.html (1.56 KB, text/html)
2020-10-26 20:23 UTC, ralph.goddard@outlook.com
Details

Note You need to log in before you can comment on or make changes to this bug.
Description ralph.goddard@outlook.com 2020-10-24 03:42:10 UTC
Adding a category from the menu bar always adds to INCOME regardless of what is selected in category create window.


SOFTWARE/OS VERSIONS
Windows: 10
Comment 1 Jack 2020-10-24 20:50:20 UTC
If you set the Type: dropdown to Expense, what does the program show in the Hierarchy tab of the dialog.  I see only the Expense category hierarchy, and it correctly creates the new category.  

I don't recall any bug in this area being fixed, but 5.0.6 was released over a year ago, and 5.1 is available for Windows, so you might try upgrading.
Comment 2 ralph.goddard@outlook.com 2020-10-24 22:52:57 UTC
Created attachment 132697 [details]
0DCC0D3C3617443DB60E40719114DDE0.jpg

[cid:image002.jpg@01D6AA1D.B5982970][cid:image003.jpg@01D6AA1D.B5982970][cid:image005.jpg@01D6AA1D.B5982970]

Hope this helps

Ralph
Sent from Mail<https://go.microsoft.com/fwlink/?LinkId=550986> for Windows 10

From: Jack<mailto:bugzilla_noreply@kde.org>
Sent: October 24, 2020 1:50 PM
To: ralph.goddard@outlook.com<mailto:ralph.goddard@outlook.com>
Subject: [kmymoney] [Bug 428164] Adding new category from menu bar

https://bugs.kde.org/show_bug.cgi?id=428164

Jack <ostroffjh@users.sourceforge.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REPORTED                    |NEEDSINFO
         Resolution|---                         |WAITINGFORINFO
                 CC|                            |ostroffjh@users.sourceforge
                   |                            |.net

--- Comment #1 from Jack <ostroffjh@users.sourceforge.net> ---
If you set the Type: dropdown to Expense, what does the program show in the
Hierarchy tab of the dialog.  I see only the Expense category hierarchy, and it
correctly creates the new category.

I don't recall any bug in this area being fixed, but 5.0.6 was released over a
year ago, and 5.1 is available for Windows, so you might try upgrading.

--
You are receiving this mail because:
You reported the bug.
Comment 3 ralph.goddard@outlook.com 2020-10-24 22:52:57 UTC
Created attachment 132698 [details]
551C7CFE1FB04C77BB01CC63A8D9B85E.jpg
Comment 4 ralph.goddard@outlook.com 2020-10-24 22:52:57 UTC
Created attachment 132699 [details]
BD57EDF6CA254B0EB1FD96A457A67176.jpg
Comment 5 ralph.goddard@outlook.com 2020-10-24 22:54:53 UTC
Created attachment 132700 [details]
attachment-1351-0.html

I just upgrade to 5.0.6 awhile back – I wasn’t aware there was another update – thanks.

Ralph
Sent from Mail<https://go.microsoft.com/fwlink/?LinkId=550986> for Windows 10

From: Jack<mailto:bugzilla_noreply@kde.org>
Sent: October 24, 2020 1:50 PM
To: ralph.goddard@outlook.com<mailto:ralph.goddard@outlook.com>
Subject: [kmymoney] [Bug 428164] Adding new category from menu bar

https://bugs.kde.org/show_bug.cgi?id=428164

Jack <ostroffjh@users.sourceforge.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REPORTED                    |NEEDSINFO
         Resolution|---                         |WAITINGFORINFO
                 CC|                            |ostroffjh@users.sourceforge
                   |                            |.net

--- Comment #1 from Jack <ostroffjh@users.sourceforge.net> ---
If you set the Type: dropdown to Expense, what does the program show in the
Hierarchy tab of the dialog.  I see only the Expense category hierarchy, and it
correctly creates the new category.

I don't recall any bug in this area being fixed, but 5.0.6 was released over a
year ago, and 5.1 is available for Windows, so you might try upgrading.

--
You are receiving this mail because:
You reported the bug.
Comment 6 ralph.goddard@outlook.com 2020-10-24 23:04:36 UTC
Created attachment 132701 [details]
attachment-1744-0.html

The ‘download server’ only offers 5.0.6 for windows.

It appears there is a 5.1.x in stable preview build but I would rather wait until it is officially released.

Ralph
Sent from Mail<https://go.microsoft.com/fwlink/?LinkId=550986> for Windows 10

From: Jack<mailto:bugzilla_noreply@kde.org>
Sent: October 24, 2020 1:50 PM
To: ralph.goddard@outlook.com<mailto:ralph.goddard@outlook.com>
Subject: [kmymoney] [Bug 428164] Adding new category from menu bar

https://bugs.kde.org/show_bug.cgi?id=428164

Jack <ostroffjh@users.sourceforge.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REPORTED                    |NEEDSINFO
         Resolution|---                         |WAITINGFORINFO
                 CC|                            |ostroffjh@users.sourceforge
                   |                            |.net

--- Comment #1 from Jack <ostroffjh@users.sourceforge.net> ---
If you set the Type: dropdown to Expense, what does the program show in the
Hierarchy tab of the dialog.  I see only the Expense category hierarchy, and it
correctly creates the new category.

I don't recall any bug in this area being fixed, but 5.0.6 was released over a
year ago, and 5.1 is available for Windows, so you might try upgrading.

--
You are receiving this mail because:
You reported the bug.
Comment 7 ralph.goddard@outlook.com 2020-10-24 23:15:46 UTC
Hierarchy also shows Expenses 

The download page only offers 5.0.6 for windows.  5.1-x appears to be stable preview and maybe still in development?
Comment 8 Jack 2020-10-24 23:40:32 UTC
Hint: When you reply by email, and not at bugs.kde.org, please don't include the message you reply to, since your entire email (including the quoted text) gets included in your comment.  The only reason to quote any part of a previous comment is if you need to specify exactly what you are replying to.  Also, your email software is sending HTML as well as plain text, so the HTML version gets attached to the bug.  If possible, try to configure your email software to send only plain text.  Thanks.

5.1 was released in June.  The "stable branch" usually is the released version, although it might have some bug fixes which are waiting to be released.  It doesn't have experimental work or work in progress.  The difference between the stable preview versions and the "official" windows versions has to do with how they are built, so they are close but not quite equivalent.

So far, I am unable to find any reason for the behavior you are seeing, so we'll have to see if you can try a newer version, or anyone else has an idea.
Comment 9 ralph.goddard@outlook.com 2020-10-25 01:18:41 UTC
Sorry about the clutter.

How do I download 5.1?  Do I download all files and then run WHICH ONE?
Comment 10 Thomas Baumgart 2020-10-26 19:01:29 UTC
From https://binary-factory.kde.org/job/KMyMoney_Release_win64/ download the .exe file. It contains an installer. No need for the other files unless requested by a developer for bug hunting. Hope that helps.
Comment 11 ralph.goddard@outlook.com 2020-10-26 20:02:51 UTC
Created attachment 132771 [details]
5.1 error message

I get a system error message and program fails to run
Comment 12 ralph.goddard@outlook.com 2020-10-26 20:23:52 UTC
Created attachment 132772 [details]
attachment-25717-0.html

I have switched back to version 4.
5.0.6 crashed consistently when downloading a specific month of data(Sep 2020) from a bank.
5.1 wouldn’t run at all as per my comments on your bug site.

Ralph
Sent from Mail<https://go.microsoft.com/fwlink/?LinkId=550986> for Windows 10
Comment 13 Jack 2020-10-26 22:27:38 UTC
Please don't mix issues.  The failure of the current 5.1 stable preview is known (https://bugs.kde.org/show_bug.cgi?id=428228) but the fix will not be available until the next run of the build system overnight.

If you get a crash downloading data, please open a separate bug.  We can't fix things we don't know about.  (Apologies if there is already a relevant bug report.)

I'll wait for a working 5.1 build before asking again about the category creation issue.
Comment 14 Jack 2020-10-27 17:09:09 UTC
I finally installed 5.0.6 in a VM and can confirm it, with additional details.  It only happens if you invoke the New Category dialog with Income as the default type.  That means either from the menu or by right clicking any income category in the Category View and selecting New Category.  If you enter a name and click OK, the category still appears under Income, even if you change the Type to Expense.  However, if you explicitly select an expense category in the Hierarchy tab (even the top level Expense) the category is correctly created as an Expense.

Ralph - this means the easiest way (for now) to create an Expense category is either start with the Category View, right click on any existing Expense category, and click New, or else use the menu, but explicitly select Expense in the Hierarchy tab.

Also - I just tested against Version 5.1.0-0725a9f95 on Linux, and it does exhibit the same behavior.
Comment 15 ralph.goddard@outlook.com 2020-10-27 19:46:40 UTC
Thanks - I also found I could add expenses categories as described in the latter.
Comment 16 Thomas Baumgart 2020-11-18 12:40:43 UTC
Git commit f204a28dd52d1b33632adbfdd8914312d004616e by Thomas Baumgart.
Committed on 18/11/2020 at 12:39.
Pushed by tbaumgart into branch '5.1'.

Assign correct parent category to new categories

In case a category is selected use it as the parent for new categories.
Change the parent category when the category type changes between income
and expense.
FIXED-IN: 5.1.1

M  +51   -28   kmymoney/dialogs/knewaccountdlg.cpp

https://invent.kde.org/office/kmymoney/commit/f204a28dd52d1b33632adbfdd8914312d004616e
Comment 17 Thomas Baumgart 2020-11-18 12:55:44 UTC
Git commit db9dae70adff6f27a2b51a3968ad3a13afeaaa33 by Thomas Baumgart.
Committed on 18/11/2020 at 12:55.
Pushed by tbaumgart into branch 'master'.

Assign correct parent category to new categories

In case a category is selected use it as the parent for new categories.
Change the parent category when the category type changes between income
and expense.
FIXED-IN: 5.1.1
(cherry picked from commit f204a28dd52d1b33632adbfdd8914312d004616e)

M  +52   -24   kmymoney/dialogs/knewaccountdlg.cpp

https://invent.kde.org/office/kmymoney/commit/db9dae70adff6f27a2b51a3968ad3a13afeaaa33
Comment 18 Thomas Baumgart 2021-06-20 16:17:07 UTC
*** Bug 418248 has been marked as a duplicate of this bug. ***