Bug 424639 - Selected SDDM is not remembered in KCM: Not pre-selected, apply button turns on always on selection
Summary: Selected SDDM is not remembered in KCM: Not pre-selected, apply button turns ...
Status: RESOLVED FIXED
Alias: None
Product: systemsettings
Classification: Applications
Component: kcm_sddm (show other bugs)
Version: 5.20.3
Platform: Manjaro Other
: NOR normal
Target Milestone: ---
Assignee: David Edmundson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-07-25 09:57 UTC by postix
Modified: 2021-01-11 19:04 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.21


Attachments
Screenrecording (2.70 MB, video/mp4)
2020-07-25 09:57 UTC, postix
Details

Note You need to log in before you can comment on or make changes to this bug.
Description postix 2020-07-25 09:57:11 UTC
Created attachment 130387 [details]
Screenrecording

SUMMARY

When I go to the SDDM theme settings, the theme I already have chosen is not (pre)selected, instead the first theme in the list is slightly highlighted/focused.

When I click on the theme I already use, the apply button becomes activated. If I apply, and click on the very same theme again, it becomes activated again.

If I go to another KCM, I'm asked
> The settings of the current module have changed.
> Do you want to apply the changes or discard them?


STEPS TO REPRODUCE
1. Systemsettings -> SDDM -> Theme
2. Select a theme
3. Apply and enter password
4. Select the same theme again

OBSERVED RESULT

The apply button becomes activated again.


EXPECTED RESULT

Nothing should happen.


SOFTWARE/OS VERSIONS
Operating System: Manjaro Linux
KDE Plasma Version: 5.19.3
KDE Frameworks Version: 5.73.0
Qt Version: 5.15.0
Comment 1 Filip Fila 2020-10-15 14:15:08 UTC
I can't reproduce it, but it reminds me of this older permissions issue.

Check the permissions on etc/sddm.conf or etc/sddm.conf.d/kde_settings.conf.

Or to make it easier, just go into the Advanced tab and press Sync. That will fix the permissions.
Comment 2 postix 2020-10-15 14:28:50 UTC
(In reply to Filip Fila from comment #1)
> I can't reproduce it

I can reproduce it on two different machines, both running Manjaro.

> Check the permissions on etc/sddm.conf or etc/sddm.conf.d/kde_settings.conf.

sudo ls -lah /etc/sddm.conf.d/
drwxr-xr-x   2 root root 4,0K 15. Okt 16:23  .
drwxr-xr-x 131 root root  12K 15. Okt 16:23  ..
-rw-r--r--   1 root root  270 15. Okt 16:23  kde_settings.conf

ls -lah /etc/sddm.conf
-rw-r--r-- 1 root root 825 15. Okt 16:23 /etc/sddm.conf


> Or to make it easier, just go into the Advanced tab and press Sync. That
> will fix the permissions.

This did not neither change the permissions nor did it fix the issue unfortunately. :-(
Comment 3 Filip Fila 2020-10-15 14:52:17 UTC
Thanks for the quick reply. I'm also running Manjaro (Plasma is at 5.20) but it works for me.

Going to switch back the status to "Reported" since I can't reproduce it but additional info was provided.
Comment 4 postix 2020-11-19 13:05:11 UTC
I could now reproduce it on a second laptop with with

Operating System: Manjaro Linux
KDE Plasma Version: 5.20.3
KDE Frameworks Version: 5.76.0
Qt Version: 5.15.1
Comment 5 postix 2020-11-19 13:25:51 UTC
I also noticed that if I

1) delete the background wallpaper for SDDM theme in use (in the system settings, applying by the root password) 

2) click on a different design  

3) finally click on the design currently in use

the background wallpaper is displayed again.
Comment 6 postix 2020-11-20 15:36:24 UTC
A friend could reproduce it too on his/her Manjaro system.
Comment 7 David Redondo 2021-01-11 16:26:30 UTC
Git commit 5bbbe08748e0b1ecf48ea4af35b96fa23ccd0a0c by David Redondo.
Committed on 11/01/2021 at 12:42.
Pushed by ngraham into branch 'master'.

Port to ManagedConfigModule

The settings are now read via KConfigXT, with a trick to follow the config
scheme of SDDM. One KConfig object is used to read the defaults and another one
to read the actual config values, see SddmSettingsBase.h for details.
The UI is now entirely in Qml and follows the GridviewKCM style. The preview pane
has been moved into a Dialog. The "Advanced" has been moved into a page called
"Behavior" and the sync options live now in a OverlaySheet accessible from the main
page as does the background configuration.
Related: bug 403530, bug 407689, bug 411004, bug 411504, bug 419327

M  +2    -0    CMakeLists.txt
M  +10   -16   src/CMakeLists.txt
D  +0    -294  src/advancedconfig.cpp
D  +0    -63   src/advancedconfig.h
D  +0    -97   src/configwidgets/selectimagebutton.cpp
D  +0    -50   src/configwidgets/selectimagebutton.h
A  +196  -0    src/package/contents/ui/Advanced.qml     [License: GPL]
A  +98   -0    src/package/contents/ui/DetailsDialog.qml     [License: GPL (v2+)]
A  +211  -0    src/package/contents/ui/main.qml     [License: GPL]
A  +16   -0    src/package/metadata.desktop
D  +0    -147  src/qml/main.qml
A  +42   -0    src/sddmdata.cpp     [License: GPL]
A  +33   -0    src/sddmdata.h     [License: GPL]
M  +247  -57   src/sddmkcm.cpp
M  +22   -12   src/sddmkcm.h
A  +39   -0    src/sddmsettings.kcfg
A  +8    -0    src/sddmsettings.kcfgc
A  +81   -0    src/sddmsettingsbase.cpp     [License: GPL]
A  +51   -0    src/sddmsettingsbase.h     [License: GPL]
D  +0    -237  src/themeconfig.cpp
D  +0    -63   src/themeconfig.h
M  +9    -0    src/thememetadata.cpp
M  +1    -0    src/thememetadata.h
D  +0    -155  src/themesdelegate.cpp
D  +0    -47   src/themesdelegate.h
M  +80   -2    src/themesmodel.cpp
M  +16   -3    src/themesmodel.h
D  +0    -356  src/ui/advancedconfig.ui
D  +0    -223  src/ui/themeconfig.ui
M  +5    -4    src/usersmodel.cpp
M  +4    -2    src/usersmodel.h

https://invent.kde.org/plasma/sddm-kcm/commit/5bbbe08748e0b1ecf48ea4af35b96fa23ccd0a0c
Comment 8 postix 2021-01-11 19:01:42 UTC
How great! :-) 5.21?
Comment 9 Nate Graham 2021-01-11 19:04:00 UTC
Yep!