Created attachment 120167 [details] screenshot STEPS TO REPRODUCE 1. open system settings > display and monitor > "Scale display" button and set display scale factor to 1.2 2. restart plasma 3. open system settings in icon view mode 4. open "Startup and Shutdown" OBSERVED RESULT As we can see in the attached screenshot, preview of sddm themes and icons look pixelated EXPECTED RESULT preview of sddm themes and icons look crisp SOFTWARE/OS VERSIONS Operating System: Arch Linux KDE Plasma Version: 5.15.90 KDE Frameworks Version: 5.58.0 Qt Version: 5.13.0 beta3
I can't reproduce this in KDE Neon Unstable Dev: https://i.imgur.com/wZAJpXV.png And I can't reproduce it in Manjaro that has 5.15. If you have Neon somewhere could you please try there so we can see if it's Qt 5.13 that's creating the difference.
Created attachment 120231 [details] standalone kcm - worst Same thing on neon dev unstable with Qt 5.12. Standalone kcm looks worst, see "No preview available" text.
Created attachment 120232 [details] kcm in system settings
I've finally reproduced it, but restarting plasmashell wasn't enough, I had to log out. Before log out: https://i.imgur.com/lFacva1.png After log in: https://i.imgur.com/gfTfvGF.png Note how even the preview image is affected.(The coloring bug is a VirtualBox bug) The fact that it works and then doesn't makes me think it's a general problem we have with scaling, not with the code specific to this KCM. I'm tagging David as he should know a lot more.
Yes, step 2 was not clear. I meant "restart plasma session". Sorry.
On the other hand, I can't reproduce it in 5.15 even after logging out and then in again. Patrick, can you also confirm that the bug is not present in 5.15? If not, the only suspect I see is: https://phabricator.kde.org/R123:5a973f13fd6115e67c11ecf9f4624a42800b68d4
yes, I can. Operating System: Arch Linux KDE Plasma Version: 5.15.5 KDE Frameworks Version: 5.58.0 Qt Version: 5.12.3
ops, the bug also is present in plasma 5.15.5.
Git commit 9e0f846727488cf4aff7fb45a5463a92bb1f5cd2 by David Edmundson. Committed on 13/10/2019 at 16:15. Pushed by davidedmundson into branch 'Plasma/5.17'. Set preview to correct device size Summary: QQuickImage::sourceSize is in device pixels for pixmap images. Converting is the responsibility of the calling code. Test Plan: QT_SCALE_FACTOR=1.5 kcmshell5 sddm Looked at image Reviewers: #plasma, apol Reviewed By: apol Subscribers: ngraham, plasma-devel Tags: #plasma Differential Revision: https://phabricator.kde.org/D24591 M +3 -2 src/qml/main.qml https://commits.kde.org/sddm-kcm/9e0f846727488cf4aff7fb45a5463a92bb1f5cd2
This issue persists after update to Plasma 5.17.1. Operating System: Arch Linux KDE Plasma Version: 5.17.1 KDE Frameworks Version: 5.63.0 Qt Version: 5.13.1
Yunhe, you've been working on HiDPI improvements in Plasma, would you be interested in fixing this?
Git commit 5bbbe08748e0b1ecf48ea4af35b96fa23ccd0a0c by David Redondo. Committed on 11/01/2021 at 12:42. Pushed by ngraham into branch 'master'. Port to ManagedConfigModule The settings are now read via KConfigXT, with a trick to follow the config scheme of SDDM. One KConfig object is used to read the defaults and another one to read the actual config values, see SddmSettingsBase.h for details. The UI is now entirely in Qml and follows the GridviewKCM style. The preview pane has been moved into a Dialog. The "Advanced" has been moved into a page called "Behavior" and the sync options live now in a OverlaySheet accessible from the main page as does the background configuration. Related: bug 403530, bug 411004, bug 411504, bug 419327, bug 424639 M +2 -0 CMakeLists.txt M +10 -16 src/CMakeLists.txt D +0 -294 src/advancedconfig.cpp D +0 -63 src/advancedconfig.h D +0 -97 src/configwidgets/selectimagebutton.cpp D +0 -50 src/configwidgets/selectimagebutton.h A +196 -0 src/package/contents/ui/Advanced.qml [License: GPL] A +98 -0 src/package/contents/ui/DetailsDialog.qml [License: GPL (v2+)] A +211 -0 src/package/contents/ui/main.qml [License: GPL] A +16 -0 src/package/metadata.desktop D +0 -147 src/qml/main.qml A +42 -0 src/sddmdata.cpp [License: GPL] A +33 -0 src/sddmdata.h [License: GPL] M +247 -57 src/sddmkcm.cpp M +22 -12 src/sddmkcm.h A +39 -0 src/sddmsettings.kcfg A +8 -0 src/sddmsettings.kcfgc A +81 -0 src/sddmsettingsbase.cpp [License: GPL] A +51 -0 src/sddmsettingsbase.h [License: GPL] D +0 -237 src/themeconfig.cpp D +0 -63 src/themeconfig.h M +9 -0 src/thememetadata.cpp M +1 -0 src/thememetadata.h D +0 -155 src/themesdelegate.cpp D +0 -47 src/themesdelegate.h M +80 -2 src/themesmodel.cpp M +16 -3 src/themesmodel.h D +0 -356 src/ui/advancedconfig.ui D +0 -223 src/ui/themeconfig.ui M +5 -4 src/usersmodel.cpp M +4 -2 src/usersmodel.h https://invent.kde.org/plasma/sddm-kcm/commit/5bbbe08748e0b1ecf48ea4af35b96fa23ccd0a0c