Bug 411004 - sddm setting page is too wild and cannot be resized smaller
Summary: sddm setting page is too wild and cannot be resized smaller
Status: RESOLVED FIXED
Alias: None
Product: systemsettings
Classification: Applications
Component: kcm_sddm (show other bugs)
Version: 5.12.6
Platform: openSUSE Linux
: NOR normal
Target Milestone: ---
Assignee: David Edmundson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-08-17 05:35 UTC by Clementine
Modified: 2021-01-11 16:26 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
it shows a horizontal scrollbar (184.67 KB, image/png)
2019-08-17 05:35 UTC, Clementine
Details
scroll to see the whole page (189.69 KB, image/png)
2019-08-17 05:36 UTC, Clementine
Details
this is 42.3 (it is expected like this) (211.38 KB, image/png)
2019-08-17 05:37 UTC, Clementine
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Clementine 2019-08-17 05:35:36 UTC
Created attachment 122191 [details]
it shows a horizontal scrollbar

SUMMARY

Sddm setting page is too wild and cannot be resized smaller. It displays themes in the middle and a preview at the right side. Normally, the width of the middle column should be resizable and display vertical scrollbar if there are many thems to display, however systemsettings (5.12.x and above) may have set a large minimum width for the middle column. It has a horizontal scroll bar for the middle column and preview as a whole. You have to scroll right to see the while page .
 
STEPS TO REPRODUCE
1. Use openSUSE 15.1 or latest tumbleweed. (with systemsettings higher that 5.12.x)
2. open systemsettings 5.
3. open login screen (sddm setting).

OBSERVED RESULT


EXPECTED RESULT


SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 
Qt Version: 

ADDITIONAL INFORMATION
Comment 1 Clementine 2019-08-17 05:36:46 UTC
Created attachment 122192 [details]
scroll to see the whole page
Comment 2 Clementine 2019-08-17 05:37:39 UTC
Created attachment 122193 [details]
this is 42.3 (it is expected like this)
Comment 3 Clementine 2019-08-17 05:41:29 UTC
it starts at least from 15.1.
Comment 4 David Redondo 2021-01-11 16:26:21 UTC
Git commit 5bbbe08748e0b1ecf48ea4af35b96fa23ccd0a0c by David Redondo.
Committed on 11/01/2021 at 12:42.
Pushed by ngraham into branch 'master'.

Port to ManagedConfigModule

The settings are now read via KConfigXT, with a trick to follow the config
scheme of SDDM. One KConfig object is used to read the defaults and another one
to read the actual config values, see SddmSettingsBase.h for details.
The UI is now entirely in Qml and follows the GridviewKCM style. The preview pane
has been moved into a Dialog. The "Advanced" has been moved into a page called
"Behavior" and the sync options live now in a OverlaySheet accessible from the main
page as does the background configuration.
Related: bug 403530, bug 407689, bug 411504, bug 419327, bug 424639

M  +2    -0    CMakeLists.txt
M  +10   -16   src/CMakeLists.txt
D  +0    -294  src/advancedconfig.cpp
D  +0    -63   src/advancedconfig.h
D  +0    -97   src/configwidgets/selectimagebutton.cpp
D  +0    -50   src/configwidgets/selectimagebutton.h
A  +196  -0    src/package/contents/ui/Advanced.qml     [License: GPL]
A  +98   -0    src/package/contents/ui/DetailsDialog.qml     [License: GPL (v2+)]
A  +211  -0    src/package/contents/ui/main.qml     [License: GPL]
A  +16   -0    src/package/metadata.desktop
D  +0    -147  src/qml/main.qml
A  +42   -0    src/sddmdata.cpp     [License: GPL]
A  +33   -0    src/sddmdata.h     [License: GPL]
M  +247  -57   src/sddmkcm.cpp
M  +22   -12   src/sddmkcm.h
A  +39   -0    src/sddmsettings.kcfg
A  +8    -0    src/sddmsettings.kcfgc
A  +81   -0    src/sddmsettingsbase.cpp     [License: GPL]
A  +51   -0    src/sddmsettingsbase.h     [License: GPL]
D  +0    -237  src/themeconfig.cpp
D  +0    -63   src/themeconfig.h
M  +9    -0    src/thememetadata.cpp
M  +1    -0    src/thememetadata.h
D  +0    -155  src/themesdelegate.cpp
D  +0    -47   src/themesdelegate.h
M  +80   -2    src/themesmodel.cpp
M  +16   -3    src/themesmodel.h
D  +0    -356  src/ui/advancedconfig.ui
D  +0    -223  src/ui/themeconfig.ui
M  +5    -4    src/usersmodel.cpp
M  +4    -2    src/usersmodel.h

https://invent.kde.org/plasma/sddm-kcm/commit/5bbbe08748e0b1ecf48ea4af35b96fa23ccd0a0c