Bug 417511 - Dark panels have light-colored visual glitches in their rounded corners
Summary: Dark panels have light-colored visual glitches in their rounded corners
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Panel (show other bugs)
Version: 5.18.0
Platform: Other Linux
: HI normal
Target Milestone: 1.0
Assignee: visual-design
URL:
Keywords: regression
: 454467 454794 455749 459704 460781 (view as bug list)
Depends on:
Blocks:
 
Reported: 2020-02-12 19:15 UTC by veggero
Modified: 2022-11-25 16:39 UTC (History)
12 users (show)

See Also:
Latest Commit: https://invent.kde.org/frameworks/plasma-framework/commit/575d0de125cd9b6d60ca5a51ebc32c9bd0dd05ea
Version Fixed In: 5.101
Sentry Crash Report:

Attachments
White corners (9.71 KB, image/png)
2022-05-20 20:07 UTC, GL513 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description veggero 2020-02-12 19:15:59 UTC 
SUMMARY

Since last framework release, panels have white corners.

STEPS TO REPRODUCE
1. Make the panel smaller than screen width

OBSERVED RESULT

White corners

EXPECTED RESULT

No white corners


SOFTWARE/OS VERSIONS
KDE Frameworks Version: 5.67
Comment 1 Nate Graham 2020-02-13 17:27:25 UTC 
author	Niccol Venerandi <niccolo@venerandi.com>	2020-02-12 20:12:05 +0100
committer	Niccolò Venerandi <niccolo@venerandi.com>	2020-02-13 18:18:09 +0100
commit	1ed47e7c4188ed0f047dda40093ea0213ae4a433 (patch)
tree	605f782003b23344c59284e6ce2e75a476770ada
parent	1dc36bc2cee489e621a52fb4456ff28cf6a64685 (diff)
Remove hardcoded colorsHEADmaster
Summary:
Fixes https://www.reddit.com/r/kde/comments/f2mxd3/517_seeing_weird_white_corners_on_my_autohiding/

BUG:417511

Reviewers: ndavis

Reviewed By: ndavis

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D27354
Comment 2 GL513 2022-05-20 20:07:22 UTC 
Created attachment 149042 [details]
White corners

Same issue in 5.24.4
Comment 3 GL513 2022-05-21 12:27:26 UTC 
Oops meant to say frameworks 5.92.0 I suppose
Comment 4 GL513 2022-05-21 12:28:02 UTC 
Oops meant to say frameworks 5.92.0 I suppose
Comment 5 GL513 2022-05-21 12:29:08 UTC 
System Info

Operating System: Kubuntu 22.04
KDE Plasma Version: 5.24.4
KDE Frameworks Version: 5.92.0
Qt Version: 5.15.3
Kernel Version: 5.15.0-30-generic (64-bit)
Graphics Platform: X11
Processors: 8 × Intel® Core™ i7-8550U CPU @ 1.80GHz
Memory: 7.7 GiB of RAM
Graphics Processor: Mesa Intel® UHD Graphics 620
Comment 6 Nate Graham 2022-05-23 14:55:30 UTC 
It's actually Bug 438644 now; it came back. :(

*** This bug has been marked as a duplicate of bug 438644 ***
Comment 7 Nate Graham 2022-09-26 20:15:07 UTC 
Not fixed by the fix for Bug 438644, unfortunately. Re-opening.
Comment 8 Nate Graham 2022-09-26 20:15:15 UTC 
*** Bug 454467 has been marked as a duplicate of this bug. ***
Comment 9 Nate Graham 2022-09-26 20:15:35 UTC 
*** Bug 459704 has been marked as a duplicate of this bug. ***
Comment 10 Nate Graham 2022-09-26 20:16:09 UTC 
*** Bug 455749 has been marked as a duplicate of this bug. ***
Comment 11 Nate Graham 2022-09-26 20:16:21 UTC 
*** Bug 454794 has been marked as a duplicate of this bug. ***
Comment 12 Bug Janitor Service 2022-10-14 10:54:54 UTC 
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/2215
Comment 13 Nate Graham 2022-10-14 15:55:24 UTC 
Git commit 999c3a0feb97874a41faa286977e34398216e80e by Nate Graham, on behalf of Niccolò Venerandi.
Committed on 14/10/2022 at 15:55.
Pushed by ngraham into branch 'master'.

Make the panel's corner mask 1px smaller to avoid artifacts at the corners

This effectively applies the fix in
https://invent.kde.org/frameworks/plasma-framework/-/merge_requests/377 to
panels as well.
FIXED-IN: 5.26.1

M  +10   -3    shell/panelview.cpp

https://invent.kde.org/plasma/plasma-workspace/commit/999c3a0feb97874a41faa286977e34398216e80e
Comment 14 Nate Graham 2022-10-14 15:56:05 UTC 
Git commit b68a93efee8a1b1de86f3689c0db685f6a74adf9 by Nate Graham, on behalf of Niccolò Venerandi.
Committed on 14/10/2022 at 15:56.
Pushed by ngraham into branch 'Plasma/5.26'.

Make the panel's corner mask 1px smaller to avoid artifacts at the corners

This effectively applies the fix in
https://invent.kde.org/frameworks/plasma-framework/-/merge_requests/377 to
panels as well.
FIXED-IN: 5.26.1


(cherry picked from commit 999c3a0feb97874a41faa286977e34398216e80e)

M  +10   -3    shell/panelview.cpp

https://invent.kde.org/plasma/plasma-workspace/commit/b68a93efee8a1b1de86f3689c0db685f6a74adf9
Comment 15 Nate Graham 2022-10-24 17:55:37 UTC 
*** Bug 460781 has been marked as a duplicate of this bug. ***
Comment 16 Bug Janitor Service 2022-11-24 17:08:53 UTC 
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/2358
Comment 17 Nate Graham 2022-11-24 17:59:56 UTC 
Git commit 631841e00e204ba37da2367fe6b221ba6ab795b4 by Nate Graham, on behalf of Niccolò Venerandi.
Committed on 24/11/2022 at 17:00.
Pushed by ngraham into branch 'Plasma/5.26'.

Panel: Revert making the mask smaller by 1px

This fixes 460896, but breaks the fix for 417511. It will be re-fixed again by
https://invent.kde.org/frameworks/plasma-framework/-/merge_requests/644, without
any negative side effects.
Related: bug 460896
FIXED-IN: 5.26.4
(cherry picked from commit 1abe11473bcaa282ad1b5087b8dbaab2329530de)

M  +2    -10   shell/panelview.cpp

https://invent.kde.org/plasma/plasma-workspace/commit/631841e00e204ba37da2367fe6b221ba6ab795b4
Comment 18 Nate Graham 2022-11-24 18:14:58 UTC 
We had to revert the fix; re-opening this. It will be re-fixed with https://invent.kde.org/frameworks/plasma-framework/-/merge_requests/644 in Frameworks 5.101.
Comment 19 Nate Graham 2022-11-25 16:39:26 UTC 
Git commit 575d0de125cd9b6d60ca5a51ebc32c9bd0dd05ea by Nate Graham, on behalf of Niccolò Venerandi.
Committed on 25/11/2022 at 16:39.
Pushed by ngraham into branch 'master'.

Rework Plasma theme mask corners and outlines

This patch reverts Marco's idea of making the mask of dialogs smaller by 1px
(and https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/2276 reverts
my patch doing the same for the panel); instead, this MR reduces the mask by 1px,
but only for the corner elements.

The issue with reducing the whole mask by 1px is that you'll get a dark outline in
Breeze Dark (both on the panel and the dialogs) *and* you'll be able to see the
wallpaper through the panel/dialog in its outermost pixel.

This patch still isn't perfect. With some combination of colorscheme and wallpaper,
you might still notice some slight darkening going on in the corners. This happened
before this MR too, but at least now it happens *only* in the corners. It's much
less noticeable; especially since most people seem to notice it only for the panel,
which in most cases does not have any rounded corners (but it does have sides, so
this MR - which makes the bug only appear in corners - is a great step forward).
FIXED-IN: 5.101

M  +643  -111  src/desktoptheme/breeze/dialogs/background.svg
M  +622  -120  src/desktoptheme/breeze/solid/dialogs/background.svg
M  +656  -121  src/desktoptheme/breeze/solid/widgets/background.svg
M  +663  -125  src/desktoptheme/breeze/solid/widgets/panel-background.svg
M  +625  -128  src/desktoptheme/breeze/solid/widgets/tooltip.svg
M  +649  -120  src/desktoptheme/breeze/translucent/dialogs/background.svg
M  +687  -125  src/desktoptheme/breeze/translucent/widgets/panel-background.svg
M  +649  -120  src/desktoptheme/breeze/translucent/widgets/tooltip.svg
M  +687  -125  src/desktoptheme/breeze/widgets/panel-background.svg
M  +261  -59   src/desktoptheme/breeze/widgets/plasmoidheading.svg
M  +649  -120  src/desktoptheme/breeze/widgets/tooltip.svg
M  +1    -5    src/plasmaquick/dialog.cpp

https://invent.kde.org/frameworks/plasma-framework/commit/575d0de125cd9b6d60ca5a51ebc32c9bd0dd05ea