Bug 416041 - Folder View widget icon should always be monochrome
Summary: Folder View widget icon should always be monochrome
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Desktop icons & Folder View widget (show other bugs)
Version: 5.22.4
Platform: Arch Linux Linux
: NOR wishlist
Target Milestone: 1.0
Assignee: visual-design
URL:
Keywords: junior-jobs
: 405239 (view as bug list)
Depends on:
Blocks: 473215
  Show dependency tree / graph
 
Reported: 2020-01-09 12:45 UTC by Patrick Silva
Modified: 2023-08-10 13:49 UTC (History)
4 users (show)

See Also:
Latest Commit: https://invent.kde.org/plasma/plasma-desktop/-/commit/836d757ab8a9bccaf5996f0e498e2353c3327587
Version Fixed In: 6.0
Sentry Crash Report:

Attachments
panel height 38px (9.35 KB, image/png)
2020-01-09 12:45 UTC, Patrick Silva 		Details
panel height 30px (7.39 KB, image/png)
2020-01-09 12:45 UTC, Patrick Silva 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Silva 2020-01-09 12:45:12 UTC 
STEPS TO REPRODUCE
1. add Folder View widget to plasma panel
2. set panel height to 30px or less

OBSERVED RESULT
icon of Folder View widget changes. Compare the blue icon shown in the attached screenshots.


EXPECTED RESULT
icon of Folder View widget is always the same

SOFTWARE/OS VERSIONS
Operating System: Arch Linux 
KDE Plasma Version: 5.17.5
KDE Frameworks Version: 5.65.0
Qt Version: 5.14.0

ADDITIONAL INFORMATION
related to bug 381960
Comment 1 Patrick Silva 2020-01-09 12:45:25 UTC 
Created attachment 124992 [details]
panel height 38px
Comment 2 Patrick Silva 2020-01-09 12:45:38 UTC 
Created attachment 124993 [details]
panel height 30px
Comment 3 Nate Graham 2023-08-09 15:08:12 UTC 
We can do this now by asking for -symbolic icons for its CompactRepresentation.
Comment 4 Nate Graham 2023-08-09 15:13:13 UTC 
*** Bug 405239 has been marked as a duplicate of this bug. ***
Comment 5 Bug Janitor Service 2023-08-09 16:07:18 UTC 
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/1653
Comment 6 Nate Graham 2023-08-09 17:29:41 UTC 
Git commit 99680f1fff79331b7d2733e453c10f9be06ae878 by Nate Graham.
Committed on 09/08/2023 at 19:26.
Pushed by ngraham into branch 'master'.

Add inode-folder-symbolic icons

Now we can programmatically ask for either mono or colorful versions of
this mimetype icon.

M  +1    -1    icons/actions/32/document-open-folder-symbolic.svg
T  +1    -13   icons/actions/32/document-open-folder.svg
A  +1    -0    icons/actions/32/folder-symbolic.svg
C  +0    -0    icons/actions/32/folder.svg [from: icons/actions/32/document-open-folder.svg - 100% similarity]
A  +1    -0    icons/mimetypes/16/inode-directory-symbolic.svg
A  +1    -0    icons/mimetypes/22/inode-directory-symbolic.svg
A  +1    -0    icons/mimetypes/32/inode-directory-symbolic.svg

https://invent.kde.org/frameworks/breeze-icons/-/commit/99680f1fff79331b7d2733e453c10f9be06ae878
Comment 7 Nate Graham 2023-08-10 13:49:35 UTC 
Git commit 836d757ab8a9bccaf5996f0e498e2353c3327587 by Nate Graham.
Committed on 10/08/2023 at 15:38.
Pushed by ngraham into branch 'master'.

folderview: use -symbolic version for CompactRepresentation icon by default

When not using a custom icon, we want to make sure that we use the
-symbolic version (if it exists) of whatever icon is automatically
chosen for the CompactRepresentation's icon, so the Panel icons will
always be monochrome when using a mixed mono/colorful icon theme.
FIXED-IN: 6.0

M  +1    -1    containments/desktop/package/contents/config/main.xml
M  +2    -2    containments/desktop/package/contents/ui/ConfigIcons.qml
M  +13   -1    containments/desktop/package/contents/ui/main.qml

https://invent.kde.org/plasma/plasma-desktop/-/commit/836d757ab8a9bccaf5996f0e498e2353c3327587