Bug 406468 - Not-very-long strings elided in artist/album/genre grid views
Summary: Not-very-long strings elided in artist/album/genre grid views
Alias: None
Product: Elisa
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Matthieu Gallien
Depends on:
Reported: 2019-04-12 14:04 UTC by Nate Graham
Modified: 2019-04-23 02:56 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:

Elided album and artist names (593.56 KB, image/png)
2019-04-12 14:04 UTC, Nate Graham

Note You need to log in before you can comment on or make changes to this bug.
Description Nate Graham 2019-04-12 14:04:01 UTC
Created attachment 119375 [details]
Elided album and artist names

Elisa from git master.

See attached screenshot. The grid delegates' labels get elided rather than becoming multi-line strings, causing elision most artist and album names (though the problem is also visible in genre view).
Comment 1 Nate Graham 2019-04-12 15:40:41 UTC
A quick fix would be to make the grid delegates larger, which would allow the pretty art in album view to be more prominent. However this would exacerbate the issues with Genre and Artist views that currently have generic icons See Bug 406474 and Bug 406475). Those issues could be solved by making them lists rather than grids, or by giving them some artwork (see those bugs).
Comment 2 Nate Graham 2019-04-23 02:56:40 UTC
Git commit 761e3af65347072f12b770529a5effb6b39b6e58 by Nate Graham.
Committed on 23/04/2019 at 02:56.
Pushed by ngraham into branch 'master'.

Revamp grid browser delegates to improve UI

This patch changes the grid browser delegates in the following ways:
- Labels are centered
- Album art size increases from 100px to 170px, making the album view more attractive and leaving more room for labels
- Hover buttons now appear in the corner, have borders, and no longer make the album art get washed out when the delegate is hovered
- Some minor layout and positioning bugs are fixed

As a result, the following bugs are fixed:
Related: bug 406476

Also, the last usage of QQC1 in this component is removed as a side effect.

Test Plan:
Everything still works and there are no behavioral changes.


Reviewers: mgallien, #elisa

Reviewed By: mgallien, #elisa

Differential Revision: https://phabricator.kde.org/D20581

M  +83   -63   autotests/qmltests/tst_GridBrowserDelegate.qml
M  +2    -2    src/qml/BaseTheme.qml
M  +62   -61   src/qml/GridBrowserDelegate.qml