Bug 403791 - Replace all passivenotification messages with InlineMessages
Summary: Replace all passivenotification messages with InlineMessages
Status: RESOLVED FIXED
Alias: None
Product: Discover
Classification: Applications
Component: discover (show other bugs)
Version: 5.14.4
Platform: Other Linux
: HI major
Target Milestone: ---
Assignee: Plasma Bugs List
URL:
Keywords:
: 420382 421824 422257 434622 436696 (view as bug list)
Depends on:
Blocks:
 
Reported: 2019-01-31 04:00 UTC by Nate Graham
Modified: 2022-11-18 20:26 UTC (History)
9 users (show)

See Also:
Latest Commit: https://invent.kde.org/plasma/discover/commit/7db678f6faba9de0a88b8c4c43c10cdfa269c4bb
Version Fixed In: 5.27
Sentry Crash Report:

Attachments
Error message that disappeared one second later (250.74 KB, image/png)
2019-01-31 04:00 UTC, Nate Graham 		Details
"Aborted due to failure" (162.35 KB, image/png)
2019-10-10 15:29 UTC, Nate Graham 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Nate Graham 2019-01-31 04:00:50 UTC 
Created attachment 117756 [details]
Error message that disappeared one second later

Attached is a screenshot showing the error message that Discover displayed tonight after a failed update (see Bug 403790). Because it was implemented as a passivenotification, the error message disappeared approximately one second after I took the screenshot. If I had not been watching and ready with Spectacle, I would have missed it entirely and been left confused and frustrated.

These passivenotification messages are awful for the following reasons:

1. They disappear after a few seconds so you can miss them if you're not staring at Discover while it does its thing
2. Even if you are, they'll probably disappear before you're done reading and comprehending them
3. Even if you do manage to read and comprehend them, since they've disappeared, you can't write down the text or copy it for the purpose of pasting into a web search so you can figure out what to do about the problem
4. They're a totally unfamiliar, alien UI. No other KDE program displays error messages in tooltip-like pop-ups that disappear after a few seconds

Every time we would display a passivenotification, let's instead use a Kirigami InlineMessage or a Kirigami overlay sheet, which are both much nicer because they're persistent and attention-getting.

For any message where this would not be appropriate because it would be really annoying, that's a sign that we shouldn't be emitting any user-visible error message at all because it's just noise, not a real error message.
Comment 1 Dan Leinir Turthra Jensen 2019-02-01 12:17:20 UTC 
Quite right... It's an issue right now because the resourcemodel really only knows how to handle low-importance informational messages (which is what passive notifications are, after all, supposed to be for). First step is to ensure we actually have a severity separation there, and then implement the ways in which to handle that.
Comment 2 Aleix Pol 2019-08-22 21:56:00 UTC 
Git commit 3c605c3f9c5da1e3ab81dbe1882e7c9c59eda38c by Aleix Pol.
Committed on 22/08/2019 at 21:55.
Pushed by apol into branch 'master'.

Show update issues on a popup instead of as passive messages

Summary:
Otherwise they may disappear.
Related: bug 411182

Reviewers: ngraham

Reviewed By: ngraham

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D23357

M  +32   -1    discover/qml/UpdatesPage.qml

https://commits.kde.org/discover/3c605c3f9c5da1e3ab81dbe1882e7c9c59eda38c
Comment 3 Nate Graham 2019-10-10 15:29:51 UTC 
Created attachment 123129 [details]
"Aborted due to failure"

I'm not sure that worked. See this attachment.
Comment 4 Jorge Chaves 2019-12-27 22:44:03 UTC 
Não consigo atualizar o Discover, nem instalar programas com ele pois exibe a mensagem que não há conexão.
Comment 5 Nate Graham 2020-04-21 17:08:15 UTC 
*** Bug 420382 has been marked as a duplicate of this bug. ***
Comment 6 Nate Graham 2020-06-10 21:29:10 UTC 
*** Bug 421824 has been marked as a duplicate of this bug. ***
Comment 7 Nate Graham 2020-06-10 22:40:06 UTC 
*** Bug 422257 has been marked as a duplicate of this bug. ***
Comment 8 Nate Graham 2021-03-19 14:51:47 UTC 
*** Bug 434622 has been marked as a duplicate of this bug. ***
Comment 9 Nate Graham 2021-05-08 17:12:50 UTC 
*** Bug 436696 has been marked as a duplicate of this bug. ***
Comment 10 Jakub Narolewski 2022-06-19 13:55:29 UTC 
Is this up for grabs? Looking at: https://tinyurl.com/plasma-15-minute-bugs this is first on the list, assigned to admin@leinir.dk but the work here seems stale with one commit from mid 2019
Comment 11 Nate Graham 2022-06-20 01:52:18 UTC 
Yes, please feel free to work on this if you'd like to.
Comment 12 Bug Janitor Service 2022-06-20 20:28:53 UTC 
A possibly relevant merge request was started @ https://invent.kde.org/plasma/discover/-/merge_requests/324
Comment 13 Piotr Mierzwinski 2022-11-15 23:12:09 UTC 
If I may add my 3 cents.
Maybe good solution would be adding log view at the bottom of window where would be collected all error and warning messages to user could check them any time. This view could be hidden  by default  (some button would shown and hidden it) . And one can be leave the notifications as they are or alternatively replace them with inline messages, which disappear after few seconds.
Comment 14 Aleix Pol 2022-11-18 00:05:55 UTC 
Git commit 7db678f6faba9de0a88b8c4c43c10cdfa269c4bb by Aleix Pol Gonzalez, on behalf of Jakub Narolewski.
Committed on 18/11/2022 at 00:05.
Pushed by apol into branch 'master'.

Replaced passivenotification messages in DiscoverWindow.qml component with Kirigami.OverlaySheet with copyable text elements

Messages that got replaced are:
 * "Running as root" message during Component.onCompleted handling
 * app.onUnableToFind handler message about invalid resource
 * ResourcesModel.onPassiveMessage handler messages
 * TransactionModel.transaction.onPassiveMessage handler messages

M  +116  -10   discover/qml/DiscoverWindow.qml

https://invent.kde.org/plasma/discover/commit/7db678f6faba9de0a88b8c4c43c10cdfa269c4bb