SUMMARY I have 2 suggestions on improving the visual consistency of Dolphin's selection markers. Please allow me to explain them separately below. 1) A Square Plus selection marker: Right now the "Plus" (+) selection marker in Dolphin is round. It creates visual inconsistency because almost everything else including the "Minus" [-] icon is sharp and rectangle. It really stands out right now as a green round icon and doesn't match anything else there. 2) Do not highlight selection markers with colors: Right now the (+) icon turns green and the [-] icon turns red when cursor is over them. Again this creates visual inconsistency because KDE's visual style is very grey-white-oriented and low-key-elegant. The green and red used here are way too intense and they stand out in a bad way. Although they serve their functions, I think we can either: a) Turn it down a notch so they look greyish-green/red b) Use blue instead of green, use orange-yellow instead of red c) Use only transparency difference as over hints Thank you!
For that pretty much the "somewhat best fitting" icons were chosen in the iconset, never were dedicated icons created for this. I agree, this needs some polish. I even copied that to Folder View, to at least be consistently bad :)
Hello, I am currently doing work related to your request (improving the consistency and visibility of emblems), so I will see if I can make this work. (In reply to Tyson Tan from comment #0) > 1) A Square Plus selection marker: > Right now the "Plus" (+) selection marker in Dolphin is round. It creates > visual inconsistency because almost everything else including the "Minus" > [-] icon is sharp and rectangle. It really stands out right now as a green > round icon and doesn't match anything else there. I will definitely do this. > 2) Do not highlight selection markers with colors: > Right now the (+) icon turns green and the [-] icon turns red when cursor is > over them. Again this creates visual inconsistency because KDE's visual > style is very grey-white-oriented and low-key-elegant. The green and red > used here are way too intense and they stand out in a bad way. I know it's not your point, but green and red are the real colors of those icons. They go semi-transparent when the mouse isn't over them and I think they lose their color as well. > Although they serve their functions, I think we can either: > a) Turn it down a notch so they look greyish-green/red I'll experiment with that and changing the opacity of the background to make the colors have more light or dark grey based on the color scheme. > b) Use blue instead of green, use orange-yellow instead of red Blue instead of green might make sense, but I'm not so sure about orange/yellow since those colors are usually used for warnings and user input. > c) Use only transparency difference as over hints I'm not sure what this means.
I thought the emblems were handled two separated ones for each. For example, I thought you have a grey (+) and a green (+) for "Add" and gradually switch between them when the mouse cursor is over or away from a folder. Apparently, what you actually do is using only one green (+) emblem and desaturate it when the mouse cursor is away? So, 1) My last suggestion is to use grey emblem bases for both [+] and [-] 2) When the mouse cursor is over them, they have no transparency. 3) When the mouse cursor is away from them, they have some transparency
(In reply to Tyson Tan from comment #3) > I thought the emblems were handled two separated ones for each. For example, > I thought you have a grey (+) and a green (+) for "Add" and gradually switch > between them when the mouse cursor is over or away from a folder. There's probably some code in Dolphin or something to change the color. You can see the icons here (emblem-added, emblem-remove): https://phabricator.kde.org/source/breeze-icons/browse/master/icons/emblems/8/ > Apparently, what you actually do is using only one green (+) emblem and > desaturate it when the mouse cursor is away? > > So, > > 1) My last suggestion is to use grey emblem bases for both [+] and [-] > 2) When the mouse cursor is over them, they have no transparency. > 3) When the mouse cursor is away from them, they have some transparency Like this? https://www.youtube.com/watch?v=sHUiV6VKH3o
Yes. Exactly that. Thank you!
Created attachment 115870 [details] Plasma Blue emblem-added (In reply to Tyson Tan from comment #5) > Yes. Exactly that. Thank you! Keep in mind that's not the final design. Because those icons may not be used exclusively for selecting files in Dolphin, It may make sense to keep their colors. Here's another version with Plasma Blue for emblem-added instead of the green it used to have.
Created attachment 115871 [details] Icon Red emblem-remove
Those are fantastic! I love the design and border. Very nice. Color-wise, I wonder if the red remove emblem oughtn't use a different color--maybe yellow or orange? We usually use red for destructive actions or error conditions, but de-selecting something isn't destructive or an error. As far as I can tell, emblem-remove is currently only used in Dolphin. This is something we're already not perfectly consistent about (e.g. red close buttons everywhere), so maybe it doesn't matter? Or maybe we should then fix those too...
Git commit 527704fbfb2dd85f352b058c0ce33b061c576fa3 by Nate Graham, on behalf of Noah Davis. Committed on 29/10/2018 at 13:14. Pushed by ngraham into branch 'master'. Improve emblem contrast, legibility and consistency Summary: Added outlines to 16 and 22 px icons Improved the legibility of 8px icons Added new 8, 16 and 22 px versions of existing emblems Improved the consistency of emblem icons Related: bug 399356, bug 399357 FIXED-IN: 5.52 Reviewers: #vdg Reviewed By: #vdg, ngraham Subscribers: kde-frameworks-devel, #vdg Tags: #frameworks Differential Revision: https://phabricator.kde.org/D16421 A +1 -0 icons-dark/emblems/16/checkmark.svg A +15 -0 icons-dark/emblems/16/emblem-added.svg A +15 -0 icons-dark/emblems/16/emblem-checked.svg A +15 -0 icons-dark/emblems/16/emblem-encrypted-locked.svg A +1 -0 icons-dark/emblems/16/emblem-encrypted-unlocked.svg A +15 -0 icons-dark/emblems/16/emblem-error.svg A +1 -0 icons-dark/emblems/16/emblem-favorite.svg A +15 -0 icons-dark/emblems/16/emblem-important.svg A +15 -0 icons-dark/emblems/16/emblem-information.svg A +15 -0 icons-dark/emblems/16/emblem-locked.svg A +15 -0 icons-dark/emblems/16/emblem-mounted.svg A +12 -0 icons-dark/emblems/16/emblem-pause.svg A +12 -0 icons-dark/emblems/16/emblem-question.svg A +12 -0 icons-dark/emblems/16/emblem-readonly.svg A +15 -0 icons-dark/emblems/16/emblem-remove.svg M +14 -19 icons-dark/emblems/16/emblem-shared.svg A +1 -0 icons-dark/emblems/16/emblem-success.svg M +14 -17 icons-dark/emblems/16/emblem-symbolic-link.svg A +12 -0 icons-dark/emblems/16/emblem-unavailable.svg A +15 -0 icons-dark/emblems/16/emblem-unlocked.svg A +15 -0 icons-dark/emblems/16/emblem-unmounted.svg A +15 -0 icons-dark/emblems/16/emblem-warning.svg M +9 -15 icons-dark/emblems/16/rating-unrated.svg M +12 -16 icons-dark/emblems/16/rating.svg M +14 -20 icons-dark/emblems/16/vcs-added.svg M +14 -19 icons-dark/emblems/16/vcs-conflicting.svg M +14 -18 icons-dark/emblems/16/vcs-locally-modified-unstaged.svg M +14 -20 icons-dark/emblems/16/vcs-locally-modified.svg M +14 -19 icons-dark/emblems/16/vcs-normal.svg M +14 -17 icons-dark/emblems/16/vcs-removed.svg M +14 -17 icons-dark/emblems/16/vcs-update-required.svg A +1 -0 icons-dark/emblems/22/checkmark.svg A +15 -0 icons-dark/emblems/22/emblem-added.svg A +15 -0 icons-dark/emblems/22/emblem-checked.svg A +15 -0 icons-dark/emblems/22/emblem-encrypted-locked.svg M +1 -1 icons-dark/emblems/22/emblem-encrypted-unlocked.svg A +15 -0 icons-dark/emblems/22/emblem-error.svg T +1 -14 icons-dark/emblems/22/emblem-favorite.svg M +14 -17 icons-dark/emblems/22/emblem-important.svg A +15 -0 icons-dark/emblems/22/emblem-information.svg T +15 -1 icons-dark/emblems/22/emblem-locked.svg A +15 -0 icons-dark/emblems/22/emblem-mounted.svg A +12 -0 icons-dark/emblems/22/emblem-pause.svg A +12 -0 icons-dark/emblems/22/emblem-question.svg A +12 -0 icons-dark/emblems/22/emblem-readonly.svg A +15 -0 icons-dark/emblems/22/emblem-remove.svg A +15 -0 icons-dark/emblems/22/emblem-shared.svg A +1 -0 icons-dark/emblems/22/emblem-success.svg M +14 -13 icons-dark/emblems/22/emblem-symbolic-link.svg A +12 -0 icons-dark/emblems/22/emblem-unavailable.svg A +15 -0 icons-dark/emblems/22/emblem-unlocked.svg A +15 -0 icons-dark/emblems/22/emblem-unmounted.svg A +15 -0 icons-dark/emblems/22/emblem-warning.svg A +10 -0 icons-dark/emblems/22/rating-unrated.svg A +13 -0 icons-dark/emblems/22/rating.svg A +15 -0 icons-dark/emblems/22/vcs-added.svg A +15 -0 icons-dark/emblems/22/vcs-conflicting.svg A +15 -0 icons-dark/emblems/22/vcs-locally-modified-unstaged.svg A +15 -0 icons-dark/emblems/22/vcs-locally-modified.svg A +15 -0 icons-dark/emblems/22/vcs-normal.svg A +15 -0 icons-dark/emblems/22/vcs-removed.svg A +15 -0 icons-dark/emblems/22/vcs-update-required.svg M +10 -17 icons-dark/emblems/8/emblem-added.svg M +10 -17 icons-dark/emblems/8/emblem-checked.svg A +11 -0 icons-dark/emblems/8/emblem-encrypted-locked.svg A +1 -0 icons-dark/emblems/8/emblem-encrypted-unlocked.svg M +10 -17 icons-dark/emblems/8/emblem-error.svg A +1 -0 icons-dark/emblems/8/emblem-favorite.svg A +11 -0 icons-dark/emblems/8/emblem-important.svg M +10 -20 icons-dark/emblems/8/emblem-information.svg M +10 -17 icons-dark/emblems/8/emblem-locked.svg M +9 -16 icons-dark/emblems/8/emblem-mounted.svg M +3 -17 icons-dark/emblems/8/emblem-pause.svg M +3 -9 icons-dark/emblems/8/emblem-question.svg A +4 -0 icons-dark/emblems/8/emblem-readonly.svg M +10 -17 icons-dark/emblems/8/emblem-remove.svg A +11 -0 icons-dark/emblems/8/emblem-shared.svg A +6 -0 icons-dark/emblems/8/emblem-symbolic-link.svg M +3 -17 icons-dark/emblems/8/emblem-unavailable.svg M +10 -17 icons-dark/emblems/8/emblem-unlocked.svg M +10 -17 icons-dark/emblems/8/emblem-unmounted.svg M +10 -17 icons-dark/emblems/8/emblem-warning.svg A +10 -0 icons-dark/emblems/8/rating-unrated.svg A +10 -0 icons-dark/emblems/8/rating.svg A +11 -0 icons-dark/emblems/8/vcs-added.svg A +11 -0 icons-dark/emblems/8/vcs-conflicting.svg A +67 -0 icons-dark/emblems/8/vcs-locally-modified-unstaged.svg A +71 -0 icons-dark/emblems/8/vcs-locally-modified.svg A +11 -0 icons-dark/emblems/8/vcs-normal.svg A +11 -0 icons-dark/emblems/8/vcs-removed.svg A +67 -0 icons-dark/emblems/8/vcs-update-required.svg A +1 -0 icons/emblems/16/checkmark.svg A +15 -0 icons/emblems/16/emblem-added.svg A +15 -0 icons/emblems/16/emblem-checked.svg A +15 -0 icons/emblems/16/emblem-encrypted-locked.svg A +1 -0 icons/emblems/16/emblem-encrypted-unlocked.svg A +15 -0 icons/emblems/16/emblem-error.svg A +1 -0 icons/emblems/16/emblem-favorite.svg A +15 -0 icons/emblems/16/emblem-important.svg A +15 -0 icons/emblems/16/emblem-information.svg A +15 -0 icons/emblems/16/emblem-locked.svg A +15 -0 icons/emblems/16/emblem-mounted.svg A +12 -0 icons/emblems/16/emblem-pause.svg A +12 -0 icons/emblems/16/emblem-question.svg A +12 -0 icons/emblems/16/emblem-readonly.svg A +15 -0 icons/emblems/16/emblem-remove.svg M +14 -19 icons/emblems/16/emblem-shared.svg A +1 -0 icons/emblems/16/emblem-success.svg M +14 -17 icons/emblems/16/emblem-symbolic-link.svg A +12 -0 icons/emblems/16/emblem-unavailable.svg A +15 -0 icons/emblems/16/emblem-unlocked.svg A +15 -0 icons/emblems/16/emblem-unmounted.svg A +15 -0 icons/emblems/16/emblem-warning.svg M +9 -12 icons/emblems/16/rating-unrated.svg M +12 -16 icons/emblems/16/rating.svg M +14 -20 icons/emblems/16/vcs-added.svg M +14 -19 icons/emblems/16/vcs-conflicting.svg M +14 -18 icons/emblems/16/vcs-locally-modified-unstaged.svg M +14 -20 icons/emblems/16/vcs-locally-modified.svg M +14 -19 icons/emblems/16/vcs-normal.svg M +14 -17 icons/emblems/16/vcs-removed.svg M +14 -17 icons/emblems/16/vcs-update-required.svg A +1 -0 icons/emblems/22/checkmark.svg A +15 -0 icons/emblems/22/emblem-added.svg A +15 -0 icons/emblems/22/emblem-checked.svg A +15 -0 icons/emblems/22/emblem-encrypted-locked.svg M +1 -1 icons/emblems/22/emblem-encrypted-unlocked.svg A +15 -0 icons/emblems/22/emblem-error.svg T +1 -14 icons/emblems/22/emblem-favorite.svg M +14 -17 icons/emblems/22/emblem-important.svg A +15 -0 icons/emblems/22/emblem-information.svg T +15 -1 icons/emblems/22/emblem-locked.svg A +15 -0 icons/emblems/22/emblem-mounted.svg A +12 -0 icons/emblems/22/emblem-pause.svg A +12 -0 icons/emblems/22/emblem-question.svg A +12 -0 icons/emblems/22/emblem-readonly.svg A +15 -0 icons/emblems/22/emblem-remove.svg A +15 -0 icons/emblems/22/emblem-shared.svg A +1 -0 icons/emblems/22/emblem-success.svg M +14 -13 icons/emblems/22/emblem-symbolic-link.svg A +12 -0 icons/emblems/22/emblem-unavailable.svg A +15 -0 icons/emblems/22/emblem-unlocked.svg A +15 -0 icons/emblems/22/emblem-unmounted.svg A +15 -0 icons/emblems/22/emblem-warning.svg A +10 -0 icons/emblems/22/rating-unrated.svg A +13 -0 icons/emblems/22/rating.svg A +15 -0 icons/emblems/22/vcs-added.svg A +15 -0 icons/emblems/22/vcs-conflicting.svg A +15 -0 icons/emblems/22/vcs-locally-modified-unstaged.svg A +15 -0 icons/emblems/22/vcs-locally-modified.svg A +15 -0 icons/emblems/22/vcs-normal.svg A +15 -0 icons/emblems/22/vcs-removed.svg A +15 -0 icons/emblems/22/vcs-update-required.svg M +10 -17 icons/emblems/8/emblem-added.svg M +10 -17 icons/emblems/8/emblem-checked.svg A +11 -0 icons/emblems/8/emblem-encrypted-locked.svg A +1 -0 icons/emblems/8/emblem-encrypted-unlocked.svg M +10 -17 icons/emblems/8/emblem-error.svg A +1 -0 icons/emblems/8/emblem-favorite.svg A +11 -0 icons/emblems/8/emblem-important.svg M +10 -20 icons/emblems/8/emblem-information.svg M +10 -17 icons/emblems/8/emblem-locked.svg M +9 -16 icons/emblems/8/emblem-mounted.svg M +3 -17 icons/emblems/8/emblem-pause.svg M +3 -9 icons/emblems/8/emblem-question.svg A +4 -0 icons/emblems/8/emblem-readonly.svg M +10 -17 icons/emblems/8/emblem-remove.svg A +11 -0 icons/emblems/8/emblem-shared.svg A +6 -0 icons/emblems/8/emblem-symbolic-link.svg M +3 -17 icons/emblems/8/emblem-unavailable.svg M +10 -17 icons/emblems/8/emblem-unlocked.svg M +10 -17 icons/emblems/8/emblem-unmounted.svg M +10 -17 icons/emblems/8/emblem-warning.svg A +10 -0 icons/emblems/8/rating-unrated.svg A +10 -0 icons/emblems/8/rating.svg A +11 -0 icons/emblems/8/vcs-added.svg A +11 -0 icons/emblems/8/vcs-conflicting.svg A +67 -0 icons/emblems/8/vcs-locally-modified-unstaged.svg A +71 -0 icons/emblems/8/vcs-locally-modified.svg A +11 -0 icons/emblems/8/vcs-normal.svg A +11 -0 icons/emblems/8/vcs-removed.svg A +67 -0 icons/emblems/8/vcs-update-required.svg https://commits.kde.org/breeze-icons/527704fbfb2dd85f352b058c0ce33b061c576fa3
Thank you for all the works. Can't wait to see them!