Bug 399357 - A few emblem icons need adjustment to fit the style
Summary: A few emblem icons need adjustment to fit the style
Status: RESOLVED FIXED
Alias: None
Product: Breeze
Classification: Plasma
Component: Icons (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: visual-design
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-10-04 03:15 UTC by Nate Graham
Modified: 2018-10-29 13:18 UTC (History)
2 users (show)

See Also:
Latest Commit: https://commits.kde.org/breeze-icons/527704fbfb2dd85f352b058c0ce33b061c576fa3
Version Fixed In: 5.52

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Nate Graham 2018-10-04 03:15:37 UTC 
Emblem icons consist of a light-colored symbol on top of a colored shape. The color matches the tone, e.g. red for negative or dangerous actions, green for positive or good ones, blue or gray for neutral ones, etc.

However, some of the emblem do not follow this pattern and are dark with no colored backgrounds. Here are the offenders:
- emblem-favorite
- emblem-symbolic-link
- emblem-locked (correct only for the 8px version)
- emblem-encrypted-unlocked (should probably just be symlinked to emblem-encrypted-unlocked)

We should fix those.
Comment 1 Nate Graham 2018-10-04 16:13:21 UTC 
> - emblem-encrypted-unlocked (should probably just be symlinked to
> emblem-encrypted-unlocked)
What I meant was: emblem-encrypted-unlocked could be symlinked to emblem-unlocked.
Comment 2 Noah Davis 2018-10-24 12:12:43 UTC 
(In reply to Nate Graham from comment #0)
> Emblem icons consist of a light-colored symbol on top of a colored shape.
> The color matches the tone, e.g. red for negative or dangerous actions,
> green for positive or good ones, blue or gray for neutral ones, etc.
> 
> However, some of the emblem do not follow this pattern and are dark with no
> colored backgrounds. Here are the offenders:
> - emblem-favorite
> - emblem-symbolic-link
> - emblem-locked (correct only for the 8px version)
> - emblem-encrypted-unlocked (should probably just be symlinked to
> emblem-encrypted-unlocked)
> 
> We should fix those.

Where are emblem-favorite and emblem-important used? Knowing that would make it easier to know what they should look like when I redesign them.

I'm not sure about changing the style of emblem-symbolic-link. It might not be the same style as the other emblems, but I really like the icon as it is. Considering it indicates the file type (a link) rather than a status, I think it's OK for it to have a different style from the other emblems.
Comment 3 Nate Graham 2018-10-29 13:18:57 UTC 
Git commit 527704fbfb2dd85f352b058c0ce33b061c576fa3 by Nate Graham, on behalf of Noah Davis.
Committed on 29/10/2018 at 13:14.
Pushed by ngraham into branch 'master'.

Improve emblem contrast, legibility and consistency

Summary:
Added outlines to 16 and 22 px icons
Improved the legibility of 8px icons
Added new 8, 16 and 22 px versions of existing emblems
Improved the consistency of emblem icons
Related: bug 399356, bug 399968
FIXED-IN: 5.52

Reviewers: #vdg

Reviewed By: #vdg, ngraham

Subscribers: kde-frameworks-devel, #vdg

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D16421

A  +1    -0    icons-dark/emblems/16/checkmark.svg
A  +15   -0    icons-dark/emblems/16/emblem-added.svg
A  +15   -0    icons-dark/emblems/16/emblem-checked.svg
A  +15   -0    icons-dark/emblems/16/emblem-encrypted-locked.svg
A  +1    -0    icons-dark/emblems/16/emblem-encrypted-unlocked.svg
A  +15   -0    icons-dark/emblems/16/emblem-error.svg
A  +1    -0    icons-dark/emblems/16/emblem-favorite.svg
A  +15   -0    icons-dark/emblems/16/emblem-important.svg
A  +15   -0    icons-dark/emblems/16/emblem-information.svg
A  +15   -0    icons-dark/emblems/16/emblem-locked.svg
A  +15   -0    icons-dark/emblems/16/emblem-mounted.svg
A  +12   -0    icons-dark/emblems/16/emblem-pause.svg
A  +12   -0    icons-dark/emblems/16/emblem-question.svg
A  +12   -0    icons-dark/emblems/16/emblem-readonly.svg
A  +15   -0    icons-dark/emblems/16/emblem-remove.svg
M  +14   -19   icons-dark/emblems/16/emblem-shared.svg
A  +1    -0    icons-dark/emblems/16/emblem-success.svg
M  +14   -17   icons-dark/emblems/16/emblem-symbolic-link.svg
A  +12   -0    icons-dark/emblems/16/emblem-unavailable.svg
A  +15   -0    icons-dark/emblems/16/emblem-unlocked.svg
A  +15   -0    icons-dark/emblems/16/emblem-unmounted.svg
A  +15   -0    icons-dark/emblems/16/emblem-warning.svg
M  +9    -15   icons-dark/emblems/16/rating-unrated.svg
M  +12   -16   icons-dark/emblems/16/rating.svg
M  +14   -20   icons-dark/emblems/16/vcs-added.svg
M  +14   -19   icons-dark/emblems/16/vcs-conflicting.svg
M  +14   -18   icons-dark/emblems/16/vcs-locally-modified-unstaged.svg
M  +14   -20   icons-dark/emblems/16/vcs-locally-modified.svg
M  +14   -19   icons-dark/emblems/16/vcs-normal.svg
M  +14   -17   icons-dark/emblems/16/vcs-removed.svg
M  +14   -17   icons-dark/emblems/16/vcs-update-required.svg
A  +1    -0    icons-dark/emblems/22/checkmark.svg
A  +15   -0    icons-dark/emblems/22/emblem-added.svg
A  +15   -0    icons-dark/emblems/22/emblem-checked.svg
A  +15   -0    icons-dark/emblems/22/emblem-encrypted-locked.svg
M  +1    -1    icons-dark/emblems/22/emblem-encrypted-unlocked.svg
A  +15   -0    icons-dark/emblems/22/emblem-error.svg
T  +1    -14   icons-dark/emblems/22/emblem-favorite.svg
M  +14   -17   icons-dark/emblems/22/emblem-important.svg
A  +15   -0    icons-dark/emblems/22/emblem-information.svg
T  +15   -1    icons-dark/emblems/22/emblem-locked.svg
A  +15   -0    icons-dark/emblems/22/emblem-mounted.svg
A  +12   -0    icons-dark/emblems/22/emblem-pause.svg
A  +12   -0    icons-dark/emblems/22/emblem-question.svg
A  +12   -0    icons-dark/emblems/22/emblem-readonly.svg
A  +15   -0    icons-dark/emblems/22/emblem-remove.svg
A  +15   -0    icons-dark/emblems/22/emblem-shared.svg
A  +1    -0    icons-dark/emblems/22/emblem-success.svg
M  +14   -13   icons-dark/emblems/22/emblem-symbolic-link.svg
A  +12   -0    icons-dark/emblems/22/emblem-unavailable.svg
A  +15   -0    icons-dark/emblems/22/emblem-unlocked.svg
A  +15   -0    icons-dark/emblems/22/emblem-unmounted.svg
A  +15   -0    icons-dark/emblems/22/emblem-warning.svg
A  +10   -0    icons-dark/emblems/22/rating-unrated.svg
A  +13   -0    icons-dark/emblems/22/rating.svg
A  +15   -0    icons-dark/emblems/22/vcs-added.svg
A  +15   -0    icons-dark/emblems/22/vcs-conflicting.svg
A  +15   -0    icons-dark/emblems/22/vcs-locally-modified-unstaged.svg
A  +15   -0    icons-dark/emblems/22/vcs-locally-modified.svg
A  +15   -0    icons-dark/emblems/22/vcs-normal.svg
A  +15   -0    icons-dark/emblems/22/vcs-removed.svg
A  +15   -0    icons-dark/emblems/22/vcs-update-required.svg
M  +10   -17   icons-dark/emblems/8/emblem-added.svg
M  +10   -17   icons-dark/emblems/8/emblem-checked.svg
A  +11   -0    icons-dark/emblems/8/emblem-encrypted-locked.svg
A  +1    -0    icons-dark/emblems/8/emblem-encrypted-unlocked.svg
M  +10   -17   icons-dark/emblems/8/emblem-error.svg
A  +1    -0    icons-dark/emblems/8/emblem-favorite.svg
A  +11   -0    icons-dark/emblems/8/emblem-important.svg
M  +10   -20   icons-dark/emblems/8/emblem-information.svg
M  +10   -17   icons-dark/emblems/8/emblem-locked.svg
M  +9    -16   icons-dark/emblems/8/emblem-mounted.svg
M  +3    -17   icons-dark/emblems/8/emblem-pause.svg
M  +3    -9    icons-dark/emblems/8/emblem-question.svg
A  +4    -0    icons-dark/emblems/8/emblem-readonly.svg
M  +10   -17   icons-dark/emblems/8/emblem-remove.svg
A  +11   -0    icons-dark/emblems/8/emblem-shared.svg
A  +6    -0    icons-dark/emblems/8/emblem-symbolic-link.svg
M  +3    -17   icons-dark/emblems/8/emblem-unavailable.svg
M  +10   -17   icons-dark/emblems/8/emblem-unlocked.svg
M  +10   -17   icons-dark/emblems/8/emblem-unmounted.svg
M  +10   -17   icons-dark/emblems/8/emblem-warning.svg
A  +10   -0    icons-dark/emblems/8/rating-unrated.svg
A  +10   -0    icons-dark/emblems/8/rating.svg
A  +11   -0    icons-dark/emblems/8/vcs-added.svg
A  +11   -0    icons-dark/emblems/8/vcs-conflicting.svg
A  +67   -0    icons-dark/emblems/8/vcs-locally-modified-unstaged.svg
A  +71   -0    icons-dark/emblems/8/vcs-locally-modified.svg
A  +11   -0    icons-dark/emblems/8/vcs-normal.svg
A  +11   -0    icons-dark/emblems/8/vcs-removed.svg
A  +67   -0    icons-dark/emblems/8/vcs-update-required.svg
A  +1    -0    icons/emblems/16/checkmark.svg
A  +15   -0    icons/emblems/16/emblem-added.svg
A  +15   -0    icons/emblems/16/emblem-checked.svg
A  +15   -0    icons/emblems/16/emblem-encrypted-locked.svg
A  +1    -0    icons/emblems/16/emblem-encrypted-unlocked.svg
A  +15   -0    icons/emblems/16/emblem-error.svg
A  +1    -0    icons/emblems/16/emblem-favorite.svg
A  +15   -0    icons/emblems/16/emblem-important.svg
A  +15   -0    icons/emblems/16/emblem-information.svg
A  +15   -0    icons/emblems/16/emblem-locked.svg
A  +15   -0    icons/emblems/16/emblem-mounted.svg
A  +12   -0    icons/emblems/16/emblem-pause.svg
A  +12   -0    icons/emblems/16/emblem-question.svg
A  +12   -0    icons/emblems/16/emblem-readonly.svg
A  +15   -0    icons/emblems/16/emblem-remove.svg
M  +14   -19   icons/emblems/16/emblem-shared.svg
A  +1    -0    icons/emblems/16/emblem-success.svg
M  +14   -17   icons/emblems/16/emblem-symbolic-link.svg
A  +12   -0    icons/emblems/16/emblem-unavailable.svg
A  +15   -0    icons/emblems/16/emblem-unlocked.svg
A  +15   -0    icons/emblems/16/emblem-unmounted.svg
A  +15   -0    icons/emblems/16/emblem-warning.svg
M  +9    -12   icons/emblems/16/rating-unrated.svg
M  +12   -16   icons/emblems/16/rating.svg
M  +14   -20   icons/emblems/16/vcs-added.svg
M  +14   -19   icons/emblems/16/vcs-conflicting.svg
M  +14   -18   icons/emblems/16/vcs-locally-modified-unstaged.svg
M  +14   -20   icons/emblems/16/vcs-locally-modified.svg
M  +14   -19   icons/emblems/16/vcs-normal.svg
M  +14   -17   icons/emblems/16/vcs-removed.svg
M  +14   -17   icons/emblems/16/vcs-update-required.svg
A  +1    -0    icons/emblems/22/checkmark.svg
A  +15   -0    icons/emblems/22/emblem-added.svg
A  +15   -0    icons/emblems/22/emblem-checked.svg
A  +15   -0    icons/emblems/22/emblem-encrypted-locked.svg
M  +1    -1    icons/emblems/22/emblem-encrypted-unlocked.svg
A  +15   -0    icons/emblems/22/emblem-error.svg
T  +1    -14   icons/emblems/22/emblem-favorite.svg
M  +14   -17   icons/emblems/22/emblem-important.svg
A  +15   -0    icons/emblems/22/emblem-information.svg
T  +15   -1    icons/emblems/22/emblem-locked.svg
A  +15   -0    icons/emblems/22/emblem-mounted.svg
A  +12   -0    icons/emblems/22/emblem-pause.svg
A  +12   -0    icons/emblems/22/emblem-question.svg
A  +12   -0    icons/emblems/22/emblem-readonly.svg
A  +15   -0    icons/emblems/22/emblem-remove.svg
A  +15   -0    icons/emblems/22/emblem-shared.svg
A  +1    -0    icons/emblems/22/emblem-success.svg
M  +14   -13   icons/emblems/22/emblem-symbolic-link.svg
A  +12   -0    icons/emblems/22/emblem-unavailable.svg
A  +15   -0    icons/emblems/22/emblem-unlocked.svg
A  +15   -0    icons/emblems/22/emblem-unmounted.svg
A  +15   -0    icons/emblems/22/emblem-warning.svg
A  +10   -0    icons/emblems/22/rating-unrated.svg
A  +13   -0    icons/emblems/22/rating.svg
A  +15   -0    icons/emblems/22/vcs-added.svg
A  +15   -0    icons/emblems/22/vcs-conflicting.svg
A  +15   -0    icons/emblems/22/vcs-locally-modified-unstaged.svg
A  +15   -0    icons/emblems/22/vcs-locally-modified.svg
A  +15   -0    icons/emblems/22/vcs-normal.svg
A  +15   -0    icons/emblems/22/vcs-removed.svg
A  +15   -0    icons/emblems/22/vcs-update-required.svg
M  +10   -17   icons/emblems/8/emblem-added.svg
M  +10   -17   icons/emblems/8/emblem-checked.svg
A  +11   -0    icons/emblems/8/emblem-encrypted-locked.svg
A  +1    -0    icons/emblems/8/emblem-encrypted-unlocked.svg
M  +10   -17   icons/emblems/8/emblem-error.svg
A  +1    -0    icons/emblems/8/emblem-favorite.svg
A  +11   -0    icons/emblems/8/emblem-important.svg
M  +10   -20   icons/emblems/8/emblem-information.svg
M  +10   -17   icons/emblems/8/emblem-locked.svg
M  +9    -16   icons/emblems/8/emblem-mounted.svg
M  +3    -17   icons/emblems/8/emblem-pause.svg
M  +3    -9    icons/emblems/8/emblem-question.svg
A  +4    -0    icons/emblems/8/emblem-readonly.svg
M  +10   -17   icons/emblems/8/emblem-remove.svg
A  +11   -0    icons/emblems/8/emblem-shared.svg
A  +6    -0    icons/emblems/8/emblem-symbolic-link.svg
M  +3    -17   icons/emblems/8/emblem-unavailable.svg
M  +10   -17   icons/emblems/8/emblem-unlocked.svg
M  +10   -17   icons/emblems/8/emblem-unmounted.svg
M  +10   -17   icons/emblems/8/emblem-warning.svg
A  +10   -0    icons/emblems/8/rating-unrated.svg
A  +10   -0    icons/emblems/8/rating.svg
A  +11   -0    icons/emblems/8/vcs-added.svg
A  +11   -0    icons/emblems/8/vcs-conflicting.svg
A  +67   -0    icons/emblems/8/vcs-locally-modified-unstaged.svg
A  +71   -0    icons/emblems/8/vcs-locally-modified.svg
A  +11   -0    icons/emblems/8/vcs-normal.svg
A  +11   -0    icons/emblems/8/vcs-removed.svg
A  +67   -0    icons/emblems/8/vcs-update-required.svg

https://commits.kde.org/breeze-icons/527704fbfb2dd85f352b058c0ce33b061c576fa3