Bug 399356 - Give emblem icons a 1px border to ensure contrast against the icon they're on top of
Summary: Give emblem icons a 1px border to ensure contrast against the icon they're on...
Status: RESOLVED FIXED
Alias: None
Product: Breeze
Classification: Plasma
Component: Icons (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: visual-design
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-10-04 03:08 UTC by Nate Graham
Modified: 2018-10-29 13:18 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.52


Attachments
Blue emblem on blue folder (1.99 KB, image/png)
2018-10-04 03:08 UTC, Nate Graham
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Nate Graham 2018-10-04 03:08:32 UTC
Created attachment 115398 [details]
Blue emblem on blue folder

See attached screenshot.

If would be great if emblem icons had a 1px white/light gray border around the edge to ensure contrast no matter the color of the icon they're on top of.
Comment 1 Noah Davis 2018-10-04 14:33:48 UTC
(In reply to Nate Graham from comment #0)
> 
> If would be great if emblem icons had a 1px white/light gray border around
> the edge to ensure contrast no matter the color of the icon they're on top
> of.

How about a darker/lighter shade of the same color? It would depend on the lightness or darkness of the main color.
Comment 2 Nate Graham 2018-10-04 14:37:55 UTC
Yeah, I could see that working.
Comment 3 Nate Graham 2018-10-29 13:18:57 UTC
Git commit 527704fbfb2dd85f352b058c0ce33b061c576fa3 by Nate Graham, on behalf of Noah Davis.
Committed on 29/10/2018 at 13:14.
Pushed by ngraham into branch 'master'.

Improve emblem contrast, legibility and consistency

Summary:
Added outlines to 16 and 22 px icons
Improved the legibility of 8px icons
Added new 8, 16 and 22 px versions of existing emblems
Improved the consistency of emblem icons
Related: bug 399357, bug 399968
FIXED-IN: 5.52

Reviewers: #vdg

Reviewed By: #vdg, ngraham

Subscribers: kde-frameworks-devel, #vdg

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D16421

A  +1    -0    icons-dark/emblems/16/checkmark.svg
A  +15   -0    icons-dark/emblems/16/emblem-added.svg
A  +15   -0    icons-dark/emblems/16/emblem-checked.svg
A  +15   -0    icons-dark/emblems/16/emblem-encrypted-locked.svg
A  +1    -0    icons-dark/emblems/16/emblem-encrypted-unlocked.svg
A  +15   -0    icons-dark/emblems/16/emblem-error.svg
A  +1    -0    icons-dark/emblems/16/emblem-favorite.svg
A  +15   -0    icons-dark/emblems/16/emblem-important.svg
A  +15   -0    icons-dark/emblems/16/emblem-information.svg
A  +15   -0    icons-dark/emblems/16/emblem-locked.svg
A  +15   -0    icons-dark/emblems/16/emblem-mounted.svg
A  +12   -0    icons-dark/emblems/16/emblem-pause.svg
A  +12   -0    icons-dark/emblems/16/emblem-question.svg
A  +12   -0    icons-dark/emblems/16/emblem-readonly.svg
A  +15   -0    icons-dark/emblems/16/emblem-remove.svg
M  +14   -19   icons-dark/emblems/16/emblem-shared.svg
A  +1    -0    icons-dark/emblems/16/emblem-success.svg
M  +14   -17   icons-dark/emblems/16/emblem-symbolic-link.svg
A  +12   -0    icons-dark/emblems/16/emblem-unavailable.svg
A  +15   -0    icons-dark/emblems/16/emblem-unlocked.svg
A  +15   -0    icons-dark/emblems/16/emblem-unmounted.svg
A  +15   -0    icons-dark/emblems/16/emblem-warning.svg
M  +9    -15   icons-dark/emblems/16/rating-unrated.svg
M  +12   -16   icons-dark/emblems/16/rating.svg
M  +14   -20   icons-dark/emblems/16/vcs-added.svg
M  +14   -19   icons-dark/emblems/16/vcs-conflicting.svg
M  +14   -18   icons-dark/emblems/16/vcs-locally-modified-unstaged.svg
M  +14   -20   icons-dark/emblems/16/vcs-locally-modified.svg
M  +14   -19   icons-dark/emblems/16/vcs-normal.svg
M  +14   -17   icons-dark/emblems/16/vcs-removed.svg
M  +14   -17   icons-dark/emblems/16/vcs-update-required.svg
A  +1    -0    icons-dark/emblems/22/checkmark.svg
A  +15   -0    icons-dark/emblems/22/emblem-added.svg
A  +15   -0    icons-dark/emblems/22/emblem-checked.svg
A  +15   -0    icons-dark/emblems/22/emblem-encrypted-locked.svg
M  +1    -1    icons-dark/emblems/22/emblem-encrypted-unlocked.svg
A  +15   -0    icons-dark/emblems/22/emblem-error.svg
T  +1    -14   icons-dark/emblems/22/emblem-favorite.svg
M  +14   -17   icons-dark/emblems/22/emblem-important.svg
A  +15   -0    icons-dark/emblems/22/emblem-information.svg
T  +15   -1    icons-dark/emblems/22/emblem-locked.svg
A  +15   -0    icons-dark/emblems/22/emblem-mounted.svg
A  +12   -0    icons-dark/emblems/22/emblem-pause.svg
A  +12   -0    icons-dark/emblems/22/emblem-question.svg
A  +12   -0    icons-dark/emblems/22/emblem-readonly.svg
A  +15   -0    icons-dark/emblems/22/emblem-remove.svg
A  +15   -0    icons-dark/emblems/22/emblem-shared.svg
A  +1    -0    icons-dark/emblems/22/emblem-success.svg
M  +14   -13   icons-dark/emblems/22/emblem-symbolic-link.svg
A  +12   -0    icons-dark/emblems/22/emblem-unavailable.svg
A  +15   -0    icons-dark/emblems/22/emblem-unlocked.svg
A  +15   -0    icons-dark/emblems/22/emblem-unmounted.svg
A  +15   -0    icons-dark/emblems/22/emblem-warning.svg
A  +10   -0    icons-dark/emblems/22/rating-unrated.svg
A  +13   -0    icons-dark/emblems/22/rating.svg
A  +15   -0    icons-dark/emblems/22/vcs-added.svg
A  +15   -0    icons-dark/emblems/22/vcs-conflicting.svg
A  +15   -0    icons-dark/emblems/22/vcs-locally-modified-unstaged.svg
A  +15   -0    icons-dark/emblems/22/vcs-locally-modified.svg
A  +15   -0    icons-dark/emblems/22/vcs-normal.svg
A  +15   -0    icons-dark/emblems/22/vcs-removed.svg
A  +15   -0    icons-dark/emblems/22/vcs-update-required.svg
M  +10   -17   icons-dark/emblems/8/emblem-added.svg
M  +10   -17   icons-dark/emblems/8/emblem-checked.svg
A  +11   -0    icons-dark/emblems/8/emblem-encrypted-locked.svg
A  +1    -0    icons-dark/emblems/8/emblem-encrypted-unlocked.svg
M  +10   -17   icons-dark/emblems/8/emblem-error.svg
A  +1    -0    icons-dark/emblems/8/emblem-favorite.svg
A  +11   -0    icons-dark/emblems/8/emblem-important.svg
M  +10   -20   icons-dark/emblems/8/emblem-information.svg
M  +10   -17   icons-dark/emblems/8/emblem-locked.svg
M  +9    -16   icons-dark/emblems/8/emblem-mounted.svg
M  +3    -17   icons-dark/emblems/8/emblem-pause.svg
M  +3    -9    icons-dark/emblems/8/emblem-question.svg
A  +4    -0    icons-dark/emblems/8/emblem-readonly.svg
M  +10   -17   icons-dark/emblems/8/emblem-remove.svg
A  +11   -0    icons-dark/emblems/8/emblem-shared.svg
A  +6    -0    icons-dark/emblems/8/emblem-symbolic-link.svg
M  +3    -17   icons-dark/emblems/8/emblem-unavailable.svg
M  +10   -17   icons-dark/emblems/8/emblem-unlocked.svg
M  +10   -17   icons-dark/emblems/8/emblem-unmounted.svg
M  +10   -17   icons-dark/emblems/8/emblem-warning.svg
A  +10   -0    icons-dark/emblems/8/rating-unrated.svg
A  +10   -0    icons-dark/emblems/8/rating.svg
A  +11   -0    icons-dark/emblems/8/vcs-added.svg
A  +11   -0    icons-dark/emblems/8/vcs-conflicting.svg
A  +67   -0    icons-dark/emblems/8/vcs-locally-modified-unstaged.svg
A  +71   -0    icons-dark/emblems/8/vcs-locally-modified.svg
A  +11   -0    icons-dark/emblems/8/vcs-normal.svg
A  +11   -0    icons-dark/emblems/8/vcs-removed.svg
A  +67   -0    icons-dark/emblems/8/vcs-update-required.svg
A  +1    -0    icons/emblems/16/checkmark.svg
A  +15   -0    icons/emblems/16/emblem-added.svg
A  +15   -0    icons/emblems/16/emblem-checked.svg
A  +15   -0    icons/emblems/16/emblem-encrypted-locked.svg
A  +1    -0    icons/emblems/16/emblem-encrypted-unlocked.svg
A  +15   -0    icons/emblems/16/emblem-error.svg
A  +1    -0    icons/emblems/16/emblem-favorite.svg
A  +15   -0    icons/emblems/16/emblem-important.svg
A  +15   -0    icons/emblems/16/emblem-information.svg
A  +15   -0    icons/emblems/16/emblem-locked.svg
A  +15   -0    icons/emblems/16/emblem-mounted.svg
A  +12   -0    icons/emblems/16/emblem-pause.svg
A  +12   -0    icons/emblems/16/emblem-question.svg
A  +12   -0    icons/emblems/16/emblem-readonly.svg
A  +15   -0    icons/emblems/16/emblem-remove.svg
M  +14   -19   icons/emblems/16/emblem-shared.svg
A  +1    -0    icons/emblems/16/emblem-success.svg
M  +14   -17   icons/emblems/16/emblem-symbolic-link.svg
A  +12   -0    icons/emblems/16/emblem-unavailable.svg
A  +15   -0    icons/emblems/16/emblem-unlocked.svg
A  +15   -0    icons/emblems/16/emblem-unmounted.svg
A  +15   -0    icons/emblems/16/emblem-warning.svg
M  +9    -12   icons/emblems/16/rating-unrated.svg
M  +12   -16   icons/emblems/16/rating.svg
M  +14   -20   icons/emblems/16/vcs-added.svg
M  +14   -19   icons/emblems/16/vcs-conflicting.svg
M  +14   -18   icons/emblems/16/vcs-locally-modified-unstaged.svg
M  +14   -20   icons/emblems/16/vcs-locally-modified.svg
M  +14   -19   icons/emblems/16/vcs-normal.svg
M  +14   -17   icons/emblems/16/vcs-removed.svg
M  +14   -17   icons/emblems/16/vcs-update-required.svg
A  +1    -0    icons/emblems/22/checkmark.svg
A  +15   -0    icons/emblems/22/emblem-added.svg
A  +15   -0    icons/emblems/22/emblem-checked.svg
A  +15   -0    icons/emblems/22/emblem-encrypted-locked.svg
M  +1    -1    icons/emblems/22/emblem-encrypted-unlocked.svg
A  +15   -0    icons/emblems/22/emblem-error.svg
T  +1    -14   icons/emblems/22/emblem-favorite.svg
M  +14   -17   icons/emblems/22/emblem-important.svg
A  +15   -0    icons/emblems/22/emblem-information.svg
T  +15   -1    icons/emblems/22/emblem-locked.svg
A  +15   -0    icons/emblems/22/emblem-mounted.svg
A  +12   -0    icons/emblems/22/emblem-pause.svg
A  +12   -0    icons/emblems/22/emblem-question.svg
A  +12   -0    icons/emblems/22/emblem-readonly.svg
A  +15   -0    icons/emblems/22/emblem-remove.svg
A  +15   -0    icons/emblems/22/emblem-shared.svg
A  +1    -0    icons/emblems/22/emblem-success.svg
M  +14   -13   icons/emblems/22/emblem-symbolic-link.svg
A  +12   -0    icons/emblems/22/emblem-unavailable.svg
A  +15   -0    icons/emblems/22/emblem-unlocked.svg
A  +15   -0    icons/emblems/22/emblem-unmounted.svg
A  +15   -0    icons/emblems/22/emblem-warning.svg
A  +10   -0    icons/emblems/22/rating-unrated.svg
A  +13   -0    icons/emblems/22/rating.svg
A  +15   -0    icons/emblems/22/vcs-added.svg
A  +15   -0    icons/emblems/22/vcs-conflicting.svg
A  +15   -0    icons/emblems/22/vcs-locally-modified-unstaged.svg
A  +15   -0    icons/emblems/22/vcs-locally-modified.svg
A  +15   -0    icons/emblems/22/vcs-normal.svg
A  +15   -0    icons/emblems/22/vcs-removed.svg
A  +15   -0    icons/emblems/22/vcs-update-required.svg
M  +10   -17   icons/emblems/8/emblem-added.svg
M  +10   -17   icons/emblems/8/emblem-checked.svg
A  +11   -0    icons/emblems/8/emblem-encrypted-locked.svg
A  +1    -0    icons/emblems/8/emblem-encrypted-unlocked.svg
M  +10   -17   icons/emblems/8/emblem-error.svg
A  +1    -0    icons/emblems/8/emblem-favorite.svg
A  +11   -0    icons/emblems/8/emblem-important.svg
M  +10   -20   icons/emblems/8/emblem-information.svg
M  +10   -17   icons/emblems/8/emblem-locked.svg
M  +9    -16   icons/emblems/8/emblem-mounted.svg
M  +3    -17   icons/emblems/8/emblem-pause.svg
M  +3    -9    icons/emblems/8/emblem-question.svg
A  +4    -0    icons/emblems/8/emblem-readonly.svg
M  +10   -17   icons/emblems/8/emblem-remove.svg
A  +11   -0    icons/emblems/8/emblem-shared.svg
A  +6    -0    icons/emblems/8/emblem-symbolic-link.svg
M  +3    -17   icons/emblems/8/emblem-unavailable.svg
M  +10   -17   icons/emblems/8/emblem-unlocked.svg
M  +10   -17   icons/emblems/8/emblem-unmounted.svg
M  +10   -17   icons/emblems/8/emblem-warning.svg
A  +10   -0    icons/emblems/8/rating-unrated.svg
A  +10   -0    icons/emblems/8/rating.svg
A  +11   -0    icons/emblems/8/vcs-added.svg
A  +11   -0    icons/emblems/8/vcs-conflicting.svg
A  +67   -0    icons/emblems/8/vcs-locally-modified-unstaged.svg
A  +71   -0    icons/emblems/8/vcs-locally-modified.svg
A  +11   -0    icons/emblems/8/vcs-normal.svg
A  +11   -0    icons/emblems/8/vcs-removed.svg
A  +67   -0    icons/emblems/8/vcs-update-required.svg

https://commits.kde.org/breeze-icons/527704fbfb2dd85f352b058c0ce33b061c576fa3