Bug 394420 - Folder view applet is expanded when in panel
Summary: Folder view applet is expanded when in panel
Status: RESOLVED WORKSFORME
Alias: None
Product: plasmashell
Classification: Plasma
Component: Folder (show other bugs)
Version: 5.13.0
Platform: Other Linux
: NOR normal
Target Milestone: 1.0
Assignee: Eike Hein
URL:
Keywords:
: 395333 396037 (view as bug list)
Depends on:
Blocks:
 
Reported: 2018-05-18 18:36 UTC by Antonio Rojas
Modified: 2018-07-06 20:31 UTC (History)
16 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Screenshot (109.05 KB, image/png)
2018-05-18 18:36 UTC, Antonio Rojas
Details
Too small popup (7.94 KB, image/png)
2018-06-14 10:19 UTC, Andreas Blochberger
Details
attachment-17471-0.html (1.60 KB, text/html)
2018-06-14 17:52 UTC, Michail Vourlakos
Details
attachment-19365-0.html (1.24 KB, text/html)
2018-06-14 18:16 UTC, Michail Vourlakos
Details
Not possible to change icon sizes (84.83 KB, image/png)
2018-06-19 20:17 UTC, Vangelis
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Antonio Rojas 2018-05-18 18:36:07 UTC
Created attachment 112737 [details]
Screenshot

Since commit 2683d4c6e60a9b8cca32f9b342d9010f4cc46086, the folder view is displayed expanded in the panel instead of as a pop-up icon. You need to make the panel absurdly narrow to turn it into an icon. This makes the applet useless, since it only has room to display the title.
Comment 1 Michail Vourlakos 2018-05-18 22:50:00 UTC
Have you set a maximum panel icon size?
Comment 2 Antonio Rojas 2018-05-19 06:44:45 UTC
I had no idea that you could do that, so no. I'm on a high DPI screen with 2x scaling in case it matters.
Comment 3 Antonio Rojas 2018-05-19 06:51:07 UTC
OK i found the setting now - increasing the panel icon size to 128 fizes it. Still, I find it strange to base this on the max icon size - even if the expanded folder view were 2x or 3x the icon size it would be unusable. Other applets (such as sticky notes) turn to a full representation at a much reasonably large panel size IMO.
Comment 4 Michail Vourlakos 2018-05-19 07:15:18 UTC
it is a design decision from plasma devs, this value to be respected from all plasma applets. Applets in the panel shouldnt grow their icon bigger than that value.

> Other applets (such as sticky notes) turn to a full representation at a much reasonably large panel size IMO.

different full representations or for notes that design decision hasnt reached it yet.

why dont you set that value to 256px?

this change was discussed here: https://phabricator.kde.org/D11220
and it was applied through: https://phabricator.kde.org/D11651
Comment 5 Marco Martin 2018-05-21 13:06:41 UTC
for folderview probably the switch should occur when the panel is 2-3 times bugger then the icon size
Comment 6 Michail Vourlakos 2018-05-21 13:20:58 UTC
(In reply to Marco Martin from comment #5)
> for folderview probably the switch should occur when the panel is 2-3 times
> bigger then the icon size

1. do you mean 2,3 times bigger than the units.iconSizeHints.panel?
2. do you have any preference between 2 or 3 ?
Comment 7 Eike Hein 2018-05-22 12:10:30 UTC
I sort of agree with Marco's take and would accept a patch doing this, it seems pragmatic.
Comment 8 Antonio Rojas 2018-06-14 06:34:15 UTC
*** Bug 395333 has been marked as a duplicate of this bug. ***
Comment 9 Andreas Blochberger 2018-06-14 10:19:21 UTC
Created attachment 113305 [details]
Too small popup

After finding the setting for the icon size, the folderview shows correctly in the panel again. But the popup window is far too small. It only shows the first item (in my case).
I'm using the folderview as menu for some desktop files, but this is not so easy anymore, because now I can't read the text and I have to scroll.

Is there any way, to make the popup bigger?
Comment 10 TOM Harrison 2018-06-14 12:48:14 UTC
I also have this issue.
Folder view is also expanded in latte-dock.
No option that could set back to icon.
Comment 11 Andreas Blochberger 2018-06-14 14:00:59 UTC
(In reply to Andreas Blochberger from comment #9)
> But the popup window is far too small. 
Reverting the commit from https://phabricator.kde.org/D11651?vs=on&id=30470&whitespace=ignore-most#change-AFymfCJYvM9H locally fixed the problem

This code makes the popup have the correct size again:
> Plasmoid.switchWidth: preferredWidth(true)
> Plasmoid.switchHeight: preferredHeight(true)
Comment 12 Andreas Blochberger 2018-06-14 14:15:20 UTC
(In reply to Andreas Blochberger from comment #9)
> After finding the setting for the icon size, the folderview shows correctly
> in the panel again. 

This setting can be found under System settings > Icons
Comment 13 jeep70cp 2018-06-14 17:45:42 UTC
I have this issue too, and it renders this widget useless to me in latte-dock. I really think there should be an option to force the old style.
Comment 14 Michail Vourlakos 2018-06-14 17:52:19 UTC
Created attachment 113322 [details]
attachment-17471-0.html

The current implementation just needs from the user to set a high panel
icon size from plasma systemsettings. You can set it at 256px. and
everything will be ok

Στις Πέμ, 14 Ιουν 2018, 8:45 μ.μ. ο χρήστης <bugzilla_noreply@kde.org>
έγραψε:

> https://bugs.kde.org/show_bug.cgi?id=394420
>
> jeep70cp@gmail.com changed:
>
>            What    |Removed                     |Added
>
> ----------------------------------------------------------------------------
>                  CC|                            |jeep70cp@gmail.com
>              Status|UNCONFIRMED                 |CONFIRMED
>      Ever confirmed|0                           |1
>
> --- Comment #13 from jeep70cp@gmail.com ---
> I have this issue too, and it renders this widget useless to me in
> latte-dock.
> I really think there should be an option to force the old style.
>
> --
> You are receiving this mail because:
> You are on the CC list for the bug.
Comment 15 jeep70cp 2018-06-14 18:13:43 UTC
(In reply to Michail Vourlakos from comment #14)
> Created attachment 113322 [details]
> attachment-17471-0.html
> 
> The current implementation just needs from the user to set a high panel
> icon size from plasma systemsettings. You can set it at 256px. and
> everything will be ok

Thanks, I still think there should be an option in the future though.
Comment 16 Michail Vourlakos 2018-06-14 18:16:28 UTC
Created attachment 113323 [details]
attachment-19365-0.html

As the plasma devs agreed, that threshold might be small for that specific
case, increasing it to 2x or 3x it would be accepted

Στις Πέμ, 14 Ιουν 2018, 9:13 μ.μ. ο χρήστης <bugzilla_noreply@kde.org>
έγραψε:

> https://bugs.kde.org/show_bug.cgi?id=394420
>
> --- Comment #15 from jeep70cp@gmail.com ---
> (In reply to Michail Vourlakos from comment #14)
> > Created attachment 113322 [details]
> > attachment-17471-0.html
> >
> > The current implementation just needs from the user to set a high panel
> > icon size from plasma systemsettings. You can set it at 256px. and
> > everything will be ok
>
> Thanks, I still think there should be an option in the future though.
>
> --
> You are receiving this mail because:
> You are on the CC list for the bug.
Comment 17 Patrick Silva 2018-06-17 19:29:27 UTC
*** Bug 395477 has been marked as a duplicate of this bug. ***
Comment 18 Vangelis 2018-06-19 20:17:02 UTC
Created attachment 113445 [details]
Not possible to change icon sizes
Comment 19 Vangelis 2018-06-19 20:19:05 UTC
How can one change the panel icon size? If I go to "System Settings -> Icons" I see a button "Configure Icon Sizes" but I do not get the option to change anything there. I only get a disabled slider with a value of 0. Check attachment in the previous comment.
Comment 20 Eike Hein 2018-06-20 16:19:21 UTC
The Icons module was rewritten with an all-new UI for 5.13 - this could be a bug in it. CC'ing relevant dev.
Comment 21 Kai Uwe Broulik 2018-06-29 09:28:48 UTC
What icon theme are you using?
Comment 22 Kai Uwe Broulik 2018-06-29 09:36:45 UTC
Ok, I can confirm the zero size for obsidian icon theme but I don't understand how this could have worked before. It clearly couldn't. But maybe the old KCM didn't overwrite the previous size value son save as this advanced configuration was on a separate page.
Comment 23 Vangelis 2018-06-29 15:29:14 UTC
What is the reason for the zero size for obsidian icon theme?

If there is a problem with the icon theme a message to user (in the plenty of empty space) that icon sizes are not supported with the selected theme would probably be better instead of just having a non-working menu?
Comment 24 Antonio Rojas 2018-06-29 15:31:40 UTC
Can this discussion be moved to a separate bug report, please? It has nothing to do with the folder view issue.
Comment 25 Antonio Rojas 2018-07-01 06:55:36 UTC
*** Bug 396037 has been marked as a duplicate of this bug. ***
Comment 26 North 2018-07-01 08:44:07 UTC
(In reply to Andreas Blochberger from comment #12)
> (In reply to Andreas Blochberger from comment #9)
> > After finding the setting for the icon size, the folderview shows correctly
> > in the panel again. 
> 
> This setting can be found under System settings > Icons

I can't reset the icon size for panel.  Nothing happens when I select 'panel'.
Comment 27 Michail Vourlakos 2018-07-05 13:50:07 UTC
(In reply to North from comment #26)
> (In reply to Andreas Blochberger from comment #12)
> I can't reset the icon size for panel.  Nothing happens when I select
> 'panel'.

you can choose Breeze icons to change the panel icon size to 256px. and afterwards you choose your icon theme
Comment 28 North 2018-07-06 00:35:32 UTC
(In reply to Michail Vourlakos from comment #27)
> (In reply to North from comment #26)
> > (In reply to Andreas Blochberger from comment #12)
> > I can't reset the icon size for panel.  Nothing happens when I select
> > 'panel'.
> 
> you can choose Breeze icons to change the panel icon size to 256px. and
> afterwards you choose your icon theme

If I change the icons theme, ALL my panel icons will change to that theme.  The last time I changed the icons theme, all the icons became nondescript blobs.  They remained so after I changed the theme back to what it had been.  I then had to change each icon individually.  I had and have about 28 icons in Quicklaunch widgets on the panel.
Comment 29 North 2018-07-06 00:37:46 UTC
The bug report I filed related to the File View widget. ( https://bugs.kde.org/show_bug.cgi?id=396037 )  I have just noticed that this report relates to an applet.
Comment 30 Eike Hein 2018-07-06 20:31:46 UTC
In the next 4.13.x release several changes happen:
* The icons sixes setting in System Settings is fixed again.
* Folder View will only expand on vertical panels (and only when the panel is bigger than the Panel icon size setting).