Bug 395477 - regression: folder view widget in panel = file list popup is too tiny
Summary: regression: folder view widget in panel = file list popup is too tiny
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Folder (show other bugs)
Version: 5.13.0
Platform: Arch Linux Linux
: NOR major
Target Milestone: 1.0
Assignee: Eike Hein
URL:
Keywords:
: 396304 (view as bug list)
Depends on:
Blocks:
 
Reported: 2018-06-16 06:38 UTC by S. Christian Collins
Modified: 2018-07-08 08:43 UTC (History)
11 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.13.3


Attachments
screenshot of the bug (52.20 KB, image/png)
2018-06-16 06:38 UTC, S. Christian Collins
Details
What it should look like [Kubuntu 18.04] (27.92 KB, image/png)
2018-06-21 13:42 UTC, Jeff Smith
Details
What it looks like on Arch [same exact folder structure] (13.54 KB, image/png)
2018-06-21 13:45 UTC, Jeff Smith
Details
Set from detail mode to icon mode. Icon size largest (96.51 KB, image/png)
2018-07-02 13:15 UTC, Jeff Smith
Details
Still in icon mode. Set to smallest icon. (104.08 KB, image/png)
2018-07-02 13:20 UTC, Jeff Smith
Details
Set from icon mode back to list mode. Icon size still set to smallest. (83.42 KB, image/png)
2018-07-02 13:24 UTC, Jeff Smith
Details

Note You need to log in before you can comment on or make changes to this bug.
Description S. Christian Collins 2018-06-16 06:38:08 UTC
Created attachment 113366 [details]
screenshot of the bug

I have the folder view widget on my plasma panel pointing to a folder on my desktop. Normally, when I click the widget's icon, I get a popup with a list of the files in the associated folder. However, after upgrading to Plasma 5.13, the popup is tiny and can only list one file at a time (see attached screenshot).

Steps to reproduce:
1. Add the "Folder View" widget to the Plasma panel. It doesn't matter which folder it is pointing to ("~/Desktop" is the default). This will create a folder icon on the Plasma panel.
2. Click the folder icon.

Result: A tiny popup appears, displaying only one file at a time.
Expected result: A tall popup should appear (as in Plasma 5.12.x), large enough to show several files at the same time.

** My System **
OS: KDE Neon 5.13.0 64-bit (Plasma Desktop 5.13.0, KDE Frameworks 5.47.0, Qt 5.11.0)
Linux Kernel: 4.13.0.45-generic
CPU: Intel Core i7-930 Bloomfield (2.8 GHz quad-core)
RAM: 12GB DDR3
Video: NVIDIA GeForce GTX 970 w/ 4GB RAM (PCI Express)
NVIDIA video driver: 384.130
Comment 1 Øystein Steffensen-Alværvik 2018-06-16 14:16:50 UTC
Can reproduce on Neon 5.13.
Comment 2 Jeff Smith 2018-06-17 12:29:18 UTC
Can confirm on Arch which uses the latest plasma 5.13. Just started happening after the upgrade from 5.12. Does not happen on Kubuntu 18.04 running plasma 5.12. Folder view widget only displays one folder at a time when it is in the panel. Found nothing of consequence when looking at the plasma-org.kde.plasma.desktop-appletsrc file. Tried removing and reinserting with no joy. Same thing happened on my backup Arch system which I don't use but keep updated. The act of updating alone broke it.
Comment 3 Patrick Silva 2018-06-17 19:29:27 UTC

*** This bug has been marked as a duplicate of bug 394420 ***
Comment 4 S. Christian Collins 2018-06-17 20:48:19 UTC
This bug is not the same as bug #394420. Bug #394420 deals with the folder view appearing on the panel with too much space. Later in the comments, somebody wrote about the too-small-popup, but that should have been filed as a separate bug, as it is here. Reopening.
Comment 5 Jeff Smith 2018-06-21 13:42:19 UTC
Created attachment 113487 [details]
What it should look like [Kubuntu 18.04]

This is what it used to look like, until Plasma 5.13
Comment 6 Jeff Smith 2018-06-21 13:45:42 UTC
Created attachment 113488 [details]
What it looks like on Arch [same exact folder structure]

After updating Arch to Plasma 5.13, this is what happened. I can't even use my mouse scroll wheel to select what I want which makes it useless now.
Comment 7 Rik Mills 2018-06-26 15:49:38 UTC
Confirmed on Neon packages and with Kubuntu testing builds
Comment 8 Eike Hein 2018-06-26 15:51:09 UTC
I wasn't able to reproduce this so far.
Comment 9 Rik Mills 2018-06-26 16:03:55 UTC
If I manually revert the changes from:

https://cgit.kde.org/plasma-desktop.git/commit/?h=Plasma/5.13&id=2683d4c6e60a9b8cca32f9b342d9010f4cc46086

I seem to get a functional panel folderview again
Comment 10 Michail Vourlakos 2018-06-26 16:30:33 UTC
This issue is totally related to folderview changing from CompactRepresentation to FullRepresentation and vice versa...

As mentioned also at https://bugs.kde.org/show_bug.cgi?id=394420 if the user sets a very high panel icon size e.g. 256px it should be solved...
Comment 11 Emil Sedgh 2018-07-01 19:50:30 UTC
Can confirm on 5.13.1 on Debian.
Comment 12 Jeff Smith 2018-07-02 13:15:13 UTC
Created attachment 113715 [details]
Set from detail mode to icon mode. Icon size largest

Took the folder view shown in my previous screenshots and set the mode to icon with the largest possible icon size which I believe is 256px. Immediate expansion on the panel.
Comment 13 Michail Vourlakos 2018-07-02 13:19:27 UTC
(In reply to Jeff Smith from comment #12)
> Created attachment 113715 [details]
> Set from detail mode to icon mode. Icon size largest
> 
> Took the folder view shown in my previous screenshots and set the mode to
> icon with the largest possible icon size which I believe is 256px. Immediate
> expansion on the panel.


1. did you use 256px for the panel icon size from the plasma systemsettings?
2. did you try a relogin afterwards?
Comment 14 Jeff Smith 2018-07-02 13:20:01 UTC
Created attachment 113716 [details]
Still in icon mode. Set to smallest icon.

To further prove OUR point, set the icon to minimum while still in icon mode. Sorta kinda usable but the panel still has all that empty space. I don't know about you but I need all the panel space I can get.
Comment 15 Jeff Smith 2018-07-02 13:24:57 UTC
Created attachment 113717 [details]
Set from icon mode back to list mode. Icon size still set to smallest.

Even better, but still not right and the extra panel space is still being used. The only way to correct that extra panel space from the bug https://bugs.kde.org/show_bug.cgi?id=394420 is to delete the folder view and start over which of course takes US back to the reason for this bug report. I will of course not use it this way because I need my panel space. Please fix.
Comment 16 Jeff Smith 2018-07-02 13:35:22 UTC
Michail Vourlakos asked,

1. did you use 256px for the panel icon size from the plasma systemsettings? NO
2. did you try a relogin afterwards? NO

I set the icon size to the largest in system settings and logged out and back in. The folder view widget (and I mean both of them in the panel including the one that I did not modify) are back to normal. This seems to be a good workaround and I seriously hope it does get fixed properly. So please lets keep this bug report open until it does.
Comment 17 Michail Vourlakos 2018-07-02 13:44:47 UTC
(In reply to Jeff Smith from comment #16)
> Michail Vourlakos asked,
> 
> 1. did you use 256px for the panel icon size from the plasma systemsettings?
> NO
> 2. did you try a relogin afterwards? NO
> 
> I set the icon size to the largest in system settings and logged out and
> back in. The folder view widget (and I mean both of them in the panel
> including the one that I did not modify) are back to normal. This seems to
> be a good workaround and I seriously hope it does get fixed properly. So
> please lets keep this bug report open until it does.

What do you consider a proper fix?
According to plasma devs the proper fix is to set the panel icon size correctly.
All this has been discussed at: 

https://bugs.kde.org/show_bug.cgi?id=394420
https://phabricator.kde.org/D11220
https://phabricator.kde.org/D11651

If the plasma team decides for a better solution, I can implement it.
Comment 18 S. Christian Collins 2018-07-02 18:48:44 UTC
Why can't this be fixed to work like it did before, where it was actually useful without taking up a crazy amount of horizontal space in the panel?

In the past, I've used a folder view icon on the panel to bring up a quick access list of frequently used files. In Plasma 5.13, the files list window is too small to be of any use, and if I make the icon space super-wide, then I'm losing a ton of space on an already cramped panel. A feature that was once a major part of my workflow has now become unusable :(
Comment 19 Eike Hein 2018-07-02 18:51:30 UTC
There's likely going to be changes to it. There's two problems currently:

a) I can't reproduce it on my system at all. I need to set up something where I can reproduce it first.

b) I am currently very busy and in the middle of travel preparations, so I haven't had time for it.

I may or may not find some time this week. In the meantime any other dev is very welcome to look into it to.
Comment 20 Eike Hein 2018-07-02 18:56:55 UTC
Michail, note the problem people are having here isn't the applet expanding on the panel, it's the popup being very tiny.
Comment 21 Michail Vourlakos 2018-07-02 19:29:21 UTC
(In reply to Eike Hein from comment #20)
> Michail, note the problem people are having here isn't the applet expanding
> on the panel, it's the popup being very tiny.

they are relevant because it happens when the folderview is switching from single icon in the panel to FullRepresentation and vice versa. You can use Latte in order to reproduce.

Way to reproduce:
1. Revert my commit (https://phabricator.kde.org/D11651) for panel icon in order for FolderView to execute always the code:

    Plasmoid.switchWidth: preferredWidth(true)
    Plasmoid.switchHeight: preferredHeight(true)

2. Open Latte and disable the parabolic effect
3. Add a folderview in Latte
4. Close Latte and re-open it.
5. Click the FolderView in Latte it should work ok
6. Enable the parabolic effect in Latte and hover the folderview in order to change to FullRepresentation
7. disable the parabolic effect again in Latte in order for FolderView in Latte to stick in icon
8. Click the folderview and you will see the problem, whatever you change afterwards in folderview settings the popup will be always very small


* 1) If you dont revert my commit then the problematic code cant be accessed except if your panel has bigger thickness than the panel icon size (this is why the proposal to set panel icon size to 256px. fixes the issue after relogin)
* 2) the code that breaks is from preferredWidth(true)/preferredHeigth(true) and  it needs also the plasmoid to change in the panel from CompactRepresentation to FullRepresentation and vice versa
Comment 22 Michail Vourlakos 2018-07-02 19:57:32 UTC
I found a way to reproduce easier with plasma panel:

1. Add a folderview in a plasma panel
2. Click the folderview and the popup should look just fine
3. Increase the panel thickness until the folderview shows as FullRepresentation
4. Restore the panel thickness in order for the folderview to look as icon
5. Click the folderview and you will notice the problem. Whatever you do afterwards the popup should always look very small
Comment 23 Eike Hein 2018-07-02 20:11:32 UTC
Thanks, that helps a lot. I think this is fixable; I'll look into it soon.
Comment 24 Meinhard Ritscher 2018-07-03 09:00:00 UTC
I can confirm I can reproduce this behavior on
KDE Plasma Version 5.13.2 (openSUSE-Leap) and 5.13.1 (openSUSE Tumbleweed).
(KDE Framework Version 5.47.0)
Logging out of the session and logging in again restores a useful preview (popup) size again.
Comment 25 Eike Hein 2018-07-03 16:13:03 UTC
This patch should solve all the issues as well as make FV behave better on panels in general: https://phabricator.kde.org/D13870
Comment 26 Eike Hein 2018-07-03 16:30:54 UTC
FYI: The initial patch upload was missing some stuff, it's been updated now.
Comment 27 Emil Sedgh 2018-07-03 16:34:24 UTC
Thank you Eike. Really appreciate the quick fix.
Comment 28 Jeff Smith 2018-07-04 15:24:38 UTC
Not allowing full view on a horizontal panel is a top notch fix. Thanks Eike.
Comment 29 Eike Hein 2018-07-04 19:41:50 UTC
Git commit 4ad27c62b5e71dcf143c5e5a96d9127de38c7d2d by Eike Hein.
Committed on 04/07/2018 at 19:41.
Pushed by hein into branch 'Plasma/5.13'.

Correct Folder View sizing and representation switch behavior

Summary:
* Resolve inherent layout hint conflicts between full and compact
  representations by setting them seperately.
  This fixes a recent regression causing tiny popups.
* Correctly respect the panel icon size hint when scaling the
  compact representation, with the code and behavior now matching
  the Icon applet.
* Only expand into the full representation in place on vertical
  panels. This is not a bugfix, and optional. But I think the
  expansion is useless on horizontal panels, and this means fewer
  users have to care about changing the panel icon size hint if
  they're using a really tall horizontal panel or Latte with
  parabolic zooming.

Reviewers: mart, broulik, mvourlakos

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D13870

M  +11   -0    containments/desktop/package/contents/ui/CompactRepresentation.qml
M  +29   -9    containments/desktop/package/contents/ui/main.qml

https://commits.kde.org/plasma-desktop/4ad27c62b5e71dcf143c5e5a96d9127de38c7d2d
Comment 30 Øystein Steffensen-Alværvik 2018-07-08 08:43:55 UTC
*** Bug 396304 has been marked as a duplicate of this bug. ***