Bug 388574 - Application Launcher keyboard shortcuts require a reboot/restarting the session before taking effect
Summary: Application Launcher keyboard shortcuts require a reboot/restarting the sessi...
Status: RESOLVED FIXED
Alias: None
Product: systemsettings
Classification: Applications
Component: kcm_keys (show other bugs)
Version: 5.12.0
Platform: Arch Linux Linux
: NOR normal
Target Milestone: ---
Assignee: Michael Jansen
URL:
Keywords:
: 347509 393877 411887 (view as bug list)
Depends on:
Blocks:
 
Reported: 2018-01-05 15:26 UTC by Oleksandr Popel
Modified: 2020-04-30 17:16 UTC (History)
7 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.19.0
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Oleksandr Popel 2018-01-05 15:26:55 UTC
In the "Global Shortcuts" section of the "Shortcuts" settings page there's an option to assign a shortcuts for certain actions with any application from system menu. However, it does seem to work only with apps that have at least one Desktop Action, for example Konsole or Chromium.
I had created a 'test.desktop' file and assigned a shortcut to it. Shortcut wasn't even considered a shortcut - if I pressed Meta+X (I assigned it) I was getting "x" characters in a text fields. So then I added a simple Desktop Action to 'test.desktop' file. To my surprise it actually worked and i was able to launch that .desktop file (Note: I had to delete it and add again so the Action was added too). And I mean exactly launch, not use Desktop Action, but use "Launch" action that is present on everything you add.
This is very strange bug, and though it's not being major, because you still can use custom shortcuts, I hope it to get fixed soon.
Comment 1 Gena 2018-01-05 15:37:08 UTC
I have the same bug too.
Comment 3 Oleksandr Popel 2018-02-08 08:19:14 UTC
Still not fixed in 5.12.
Comment 4 wazhai 2018-04-23 13:59:57 UTC
When you first add an application with '+' and set a global shortcut for launching it like shown in comment 2, it doesn't work initially. This applies to Dolphin, for example.

However, it WILL work on the next log in. It seems like this bug only affects newly added entries before there has been a log out. Modifying already existing entries seems to work fine and they take effect immediately.
Comment 5 Nate Graham 2020-01-12 05:54:53 UTC
*** Bug 347509 has been marked as a duplicate of this bug. ***
Comment 6 Nate Graham 2020-01-12 06:03:22 UTC
*** Bug 393877 has been marked as a duplicate of this bug. ***
Comment 7 Nate Graham 2020-01-12 06:08:40 UTC
*** Bug 411887 has been marked as a duplicate of this bug. ***
Comment 8 David Redondo 2020-04-30 17:16:05 UTC
Git commit 1ee6660ceb62d4584a5371d0cce107b7008e75df by David Redondo.
Committed on 30/04/2020 at 16:51.
Pushed by davidre into branch 'master'.

Rewrite of the global shortcuts kcm

Summary:
This is a total rewrite of the global shortcuts kcm from scratch. It uses an
abstract item model backend with a qml frontend. This resolves some issues the
old kcm inherently had because it just stacked KShortcutEditors. First it enables
a global serach/filter which either matches the component name, actions, default
or set key combinations across components. Secondly KGlobalAccel can have multiple
default/active key combinations for each action - the old kcm only exposed two each.
The new kcm displays all default or set key combinations.
The main visual structure is similiar to the old kcm. On the left there is a list
with all components but rather than divided into "Application Launchers" and
"Other Shortcuts" the sections are now called "Applications" and "System Services"
(cf. notifications kcm) and the components are now assigned whether the service
we find for a component is an application or not rather if the component was
added via .desktop file. In the main view the shortcuts are displayed. Each item
corresponds to one action. Initially each item is collapsed and shows the action
name and a list of the currently set key combinations for that action. In the
expanded form all default shortcuts are shown which can be activated or
deactivated and all other active shortcuts ("Custom Shortcuts"). It is possible
to change, remove or add new custom shortcuts.
The kcm and model communicate directly with the daemon over DBus. This removes
the need to awkwardly construct actions to pass to the KGlobalAccel API.
Related: bug 157468, bug 213101, bug 230583, bug 250121, bug 251437, bug 272554, bug 318964, bug 341817, bug 348264, bug 366257, bug 369020, bug 393403, bug 408942, bug 416149, bug 416737, bug 417915, bug 419215, bug 419515, bug 419624, bug 419692, bug 419825, bug 419909, bug 420093
FIXED-IN: 5.19.0

Closes T7267

Test Plan:
kcmshell5 kcm_keys
{F8243559}

{F8243560}

{F8243561}

{F8243562}

{F8243563}

{F8243564}

Reviewers: #vdg, #plasma, ngraham

Reviewed By: #vdg, ngraham

Subscribers: GB_2, broulik, davidedmundson, nicolasfella, ngraham, iasensio, plasma-devel

Tags: #plasma

Maniphest Tasks: T7267

Differential Revision: https://phabricator.kde.org/D28744

M  +43   -33   kcms/keys/CMakeLists.txt
D  +0    -29   kcms/keys/ChangeLog
M  +1    -6    kcms/keys/Messages.sh
D  +0    -7    kcms/keys/README
D  +0    -84   kcms/keys/export_scheme_dialog.cpp
D  +0    -59   kcms/keys/export_scheme_dialog.h
D  +0    -35   kcms/keys/export_scheme_dialog.ui
A  +82   -0    kcms/keys/filteredmodel.cpp     [License: GPL (v2/3)]
A  +46   -0    kcms/keys/filteredmodel.h     [License: GPL (v2/3)]
D  +0    -89   kcms/keys/globalshortcuts.cpp
D  +0    -44   kcms/keys/globalshortcuts.h
A  +198  -0    kcms/keys/kcm_keys.cpp     [License: GPL (v2/3)]
R  +1    -1    kcms/keys/kcm_keys.desktop [from: kcms/keys/keys.desktop - 099% similarity]
A  +74   -0    kcms/keys/kcm_keys.h     [License: GPL (v2/3)]
D  +0    -856  kcms/keys/kglobalshortcutseditor.cpp
D  +0    -153  kcms/keys/kglobalshortcutseditor.h
D  +0    -130  kcms/keys/kglobalshortcutseditor.ui
A  +216  -0    kcms/keys/package/contents/ui/ShortcutActionDelegate.qml     [License: GPL (v2+)]
A  +302  -0    kcms/keys/package/contents/ui/main.qml     [License: GPL (v2+)]
A  +17   -0    kcms/keys/package/metadata.desktop
D  +0    -77   kcms/keys/select_application.ui
D  +0    -102  kcms/keys/select_scheme_dialog.cpp
D  +0    -51   kcms/keys/select_scheme_dialog.h
D  +0    -150  kcms/keys/select_scheme_dialog.ui
A  +489  -0    kcms/keys/shortcutsmodel.cpp     [License: GPL (v2+)]
A  +112  -0    kcms/keys/shortcutsmodel.h     [License: GPL (v2/3)]

https://commits.kde.org/plasma-desktop/1ee6660ceb62d4584a5371d0cce107b7008e75df