Bug 381786 - Make release 4.8.1
Summary: Make release 4.8.1
Status: RESOLVED FIXED
Alias: None
Product: kmymoney
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Other Unspecified
: NOR task
Target Milestone: ---
Assignee: KMyMoney Devel Mailing List
URL:
Keywords:
Depends on: 348059 380075 381790 381818 381854 382183 382186 382218 382293 384334
Blocks:
  Show dependency treegraph
 
Reported: 2017-06-29 08:23 UTC by Ralf Habacker
Modified: 2017-12-29 19:46 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
translation state of 2017-11-14 (23.66 KB, text/html)
2017-11-14 16:07 UTC, Ralf Habacker
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Ralf Habacker 2017-06-29 08:23:43 UTC
In the last year there has been over 30 bugs fixed intended for release 4.8.1 (see https://bugs.kde.org/buglist.cgi?bug_status=RESOLVED&f1=cf_versionfixedin&list_id=1447675&o1=equals&product=kmymoney4&query_format=advanced&resolution=FIXED&v1=4.8.1) which make me think that it should be time now to make this release. 

Making a stable 4.8 release will help KMyMoney users to benefit from the ongoing bug fixing and development effort done by the KMymoney developers and shows users that the KMyMoney community cares about them. 

People may ask why releasing a Qt4 based release while KF5 port is in work. The answer is that the Qt5/KF5 port in combination with all 3rdparty libraries required for KMyMoney on Windows are currently not ready for making stable releases.

Other people may be afraid that changes made for the 4.8.1 release would be lost for KF5. The anser is that all changes made in the git branch 4.8 has been recently be merged into the master branch and will be merged in future. They are immediatly usable by KF5 builds.

While preparing the release I'm also going through the open bug list 

https://bugs.kde.org/buglist.cgi?bug_severity=critical&bug_severity=grave&bug_severity=major&bug_severity=crash&bug_severity=normal&bug_severity=minor&bug_status=UNCONFIRMED&columnlist=product%2Ccomponent%2Cbug_status%2Cresolution%2Cshort_desc%2Cchangeddate%2Creporter_realname%2Cassigned_to_realname%2Cbug_severity%2Cversion%2Ccf_versionfixedin%2Crep_platform%2Cop_sys&list_id=1447686&order=op_sys%2Creporter_realname%2Cbug_status%2Cpriority%2Cassigned_to%2Cbug_id&product=kmymoney4&query_format=advanced

and will check if any of them could be fixed for the Windows build which I'm mainly caring about. It would be nice if anyone would do similar for linux related bugs.

Bugs and features identified to be useful for including in this release should be added as dependency of this bug which makes it able to get an overview what is open and what not (similar to https://bugs.kde.org/showdependencytree.cgi?id=380136&hide_resolved=1)

<offtopic>KDE phabricator has not been used for this task because it does not support KDE bugzilla bug dependencies</offtopic>
Comment 1 Ralf Habacker 2017-07-01 09:05:32 UTC
I used 
for i in $(git log | grep "cherry picked" | sed 's,^.*commit ,,g;s,),,g'); do git log -n 1 $i; done > out.log

and 

 cat out.log  | gawk '$1 == "commit" { c=$2 } $1 ~ /BUG:[^$]/ { gsub(/BUG:/,"",$1); b=$1; } $1 == "BUG:" { b=$2; } $1 == "FIXED-IN:5.0" { f="5.0" ; print c " " b " " f } $1 == "FIXED-IN:" { f=$2 ; print c " " b " " f }'

and got

398304bcf331a322a0fe7e475775aea887c4b565 249844 5.0
30564ba57d2614f1410b87e1d4edd81e8fc35fc3 378379 5.0
64d8749496a04c3be88300f040ae1c1e14af8103 372435 5.0

Checking the bug tracker shows that the first both tickets have a "version fixed in" to 4.8.1. 

The third commit uses a wrong bug id.
Comment 2 Ralf Habacker 2017-07-01 09:08:27 UTC
(In reply to Ralf Habacker from comment #1)
> I used 
... a wrong bug id too this comment should be in 381851
Comment 3 Ralf Habacker 2017-07-10 13:04:17 UTC
Just for the record: I'm documentation issues found on preparing/testing this release because they will probably be the same on making a kf5 based release or could be used as a hints how to fix similar issues.
Comment 4 Micha Lenk 2017-10-20 22:12:27 UTC
Any update?
Comment 5 Ralf Habacker 2017-10-24 19:07:07 UTC
The Windows binaries has uploaded to https://download.kde.org/stable/kmymoney/4.8.1/, the linux package has been delayed because of unfinished translations.
Comment 6 Jack 2017-10-24 19:41:46 UTC
Ralf,  given that there will be a 4.8.2 very soon after 4.8.1, with only minimal changes, would it be worth releasing 4.8.1 without all translations, and complete the translations with 4.8.2?  While in one sense it will be extra work, at least distributions can start the process, and be ready for a quick following bug-release.
Comment 7 Ralf Habacker 2017-10-30 14:32:38 UTC
(In reply to Jack from comment #6)
> Ralf,  given that there will be a 4.8.2 very soon after 4.8.1, with only
> minimal changes, would it be worth releasing 4.8.1 without all translations,
The recent 7z. tarball does not contain any translations. If we go road we simply need to add a xz tarball with the same content. 

> and complete the translations with 4.8.2?  
The problem with with translations seem to be much older because 4.8.0 tarball also includes outdated documentations:

./de/kmymoney/whatsnew.docbook:7:>4.7.01</releaseinfo>
./en/kmymoney/whatsnew.docbook:5:4.7.01</releaseinfo>
./es/kmymoney/whatsnew.docbook:7:>4.7.01</releaseinfo>
./et/kmymoney/whatsnew.docbook:7:>4.7.01</releaseinfo>
./fr/kmymoney/whatsnew.docbook:7:>4.6</releaseinfo>
./it/kmymoney/whatsnew.docbook:7:>4.7.01</releaseinfo>
./nl/kmymoney/whatsnew.docbook:7:>4.7.01</releaseinfo>
./pt_BR/kmymoney/whatsnew.docbook:7:>4.7.01</releaseinfo>
./pt/kmymoney/whatsnew.docbook:7:>4.5</releaseinfo>
./sv/kmymoney/whatsnew.docbook:7:>4.7.01</releaseinfo>
./uk/kmymoney/whatsnew.docbook:7:>4.7.01</releaseinfo>

To follow 4.8.0 style we can also use the available translations, which are of the following versions

./de/kmymoney/whatsnew.docbook:7:>4.7.01</releaseinfo>
./es/kmymoney/whatsnew.docbook:7:>4.7.01</releaseinfo>
./et/kmymoney/whatsnew.docbook:7:>4.7.01</releaseinfo>
./fr/kmymoney/whatsnew.docbook:7:>4.6</releaseinfo>
./it/kmymoney/whatsnew.docbook:7:>4.8.1</releaseinfo>
./nl/kmymoney/whatsnew.docbook:7:>4.8.1</releaseinfo>
./pt_BR/kmymoney/whatsnew.docbook:7:>4.7.01</releaseinfo>
./pt/kmymoney/whatsnew.docbook:7:>4.5</releaseinfo>
./sv/kmymoney/whatsnew.docbook:7:>4.8.1</releaseinfo>
./uk/kmymoney/whatsnew.docbook:7:>4.8.1</releaseinfo>

The version list shows that 6 of 10 translations are not up to date.
There may be some progress by pinging the related translation teams.
Comment 8 Jack 2017-10-30 16:12:26 UTC
Regarding "outdated" documentation, KDE says to only update the version number in a docbook if the content has actually been updated for that version.  Many sections have not been updated specifically for recent versions.  A translation that has a version less than 4.8.1 may not be outdated if the original is also at the same prior version.  I suspect that as long as at least some sections are at 4.8.1 then the translation is probably complete.  I'm not sure how much effort it would be to create a script to compare docbook section numbers of translations against the original.  My best guess is not to worry about it.
Comment 9 Ralf Habacker 2017-11-03 08:31:12 UTC
I guess that at least whatsnew.docbook will need to be updated with every released version and according to the mentioned rule it should have up to date version inside. 
 
The untranslated whatsnew.docbook from git tag 4.8.0 has version 4.7.1 (see https://cgit.kde.org/kmymoney.git/commit/doc/whatsnew.docbook?h=4.8.0&id=e52df82a35485e3dc83b0ed2e14e76a23d7f616a) 

From the related list at comment 7 outdated translations for version 4.8.0 looks to be
./fr/kmymoney/whatsnew.docbook:7:>4.6</releaseinfo>
./pt/kmymoney/whatsnew.docbook:7:>4.5</releaseinfo>

the untranslated whatsnew.docbook for 4.8.1 has been changed has version 4.8.1 inside (see https://cgit.kde.org/kmymoney.git/tree/doc/whatsnew.docbook?h=4.8.1&id=ebeeced0715a82327ae0e2ee833cf93fc3029366)

for 4.8.1 outdated translations currently seems to be these
./de/kmymoney/whatsnew.docbook:7:>4.7.01</releaseinfo>
./es/kmymoney/whatsnew.docbook:7:>4.7.01</releaseinfo>
./et/kmymoney/whatsnew.docbook:7:>4.7.01</releaseinfo>
./fr/kmymoney/whatsnew.docbook:7:>4.6</releaseinfo>
./pt_BR/kmymoney/whatsnew.docbook:7:>4.7.01</releaseinfo>
./pt/kmymoney/whatsnew.docbook:7:>4.5</releaseinfo>

To get this translations the regular process is to trigger the related translation team, which I did 
for the german translation team (see https://mail.kde.org/pipermail/kde-i18n-de/2017-October/013312.html). 
One translator already jumped in and provided a german translated po file for whatsnew.docbook, which needs to be reviewed.
Comment 10 Jack 2017-11-03 21:44:25 UTC
It is quite possible that I forgot to update the <releaseinfo> for whatsnew.docbook for 4.8.0.  I also don't think it matters now whether translations were outdated for 4.8.0.  What matters is whether I updated it for any file I changed for 4.8.1, and whether the translations match the current untranslated versions.  Is there a general way to trigger the translation teams for those languages which are not current?

Unfortunately, we simply have not followed the usual planning steps (including freezes) for 4.8.1.  At this point, I still think it would be worth releasing 4.8.1 as is, with a note that translations are known not up to date, and we then apply a freeze for 4.8.2, and release when the translations are complete.  (The only other item I think is OK to add to 4.8.2 is any change made related to the problem with Yahoo quotes for stock and currency prices.)
Comment 11 Ralf Habacker 2017-11-06 13:13:11 UTC
(In reply to Jack from comment #10)
> Is there a general way to trigger the translation teams for those languages which are not current?
This is by sending a request to kde-i18n-doc, which I did some weeks ago https://marc.info/?l=kmymoney-devel&m=150824069904331&w=2.
They answered that each translation team needs to be contacted - the answer from the german translation team, which I contacted, is added at the end of comment 9.
Comment 12 Ralf Habacker 2017-11-06 14:33:36 UTC
(In reply to Ralf Habacker from comment #9)
> for 4.8.1 outdated translations currently seems to be these
> ./de/kmymoney/whatsnew.docbook:7:>4.7.01</releaseinfo>
The german translation has been updated on request at Oct 30 (see https://websvn.kde.org/?view=revision&revision=1502202
> ./es/kmymoney/whatsnew.docbook:7:>4.7.01</releaseinfo>
> ./et/kmymoney/whatsnew.docbook:7:>4.7.01</releaseinfo>
> ./fr/kmymoney/whatsnew.docbook:7:>4.6</releaseinfo>
> ./pt_BR/kmymoney/whatsnew.docbook:7:>4.7.01</releaseinfo>
> ./pt/kmymoney/whatsnew.docbook:7:>4.5</releaseinfo>
An update for the remaining translations requires to contact every related translation list. See https://mail.kde.org/mailman/listinfo/ for details. Look forkde-i18n-.
Comment 13 Ralf Habacker 2017-11-10 20:51:24 UTC
(In reply to Ralf Habacker from comment #12)
update has been triggered of the following languages
> > ./fr/kmymoney/whatsnew.docbook:7:>4.6</releaseinfo>
> > ./pt_BR/kmymoney/whatsnew.docbook:7:>4.7.01</releaseinfo>
> > ./pt/kmymoney/whatsnew.docbook:7:>4.5</releaseinfo>
Comment 14 Ralf Habacker 2017-11-12 12:16:00 UTC
(In reply to Ralf Habacker from comment #13)
> (In reply to Ralf Habacker from comment #12)
> update has been triggered of the following languages
> > > ./fr/kmymoney/whatsnew.docbook:7:>4.6</releaseinfo>
Used initial wrong list kde-i18n-fr at kde.org where is should be kde-francophone at kde.org. Filed a related request https://phabricator.kde.org/T7438
Comment 15 Ralf Habacker 2017-11-12 17:56:29 UTC
(In reply to Ralf Habacker from comment #12)
> > ./et/kmymoney/whatsnew.docbook:7:>4.7.01</releaseinfo>
Will be available at the end of December or January, see https://marc.info/?l=kde-i18n-doc&m=151050920321516&w=2
Comment 16 Ralf Habacker 2017-11-14 16:07:41 UTC
Created attachment 108858 [details]
translation state of 2017-11-14
Comment 17 Ralf Habacker 2017-11-24 22:12:52 UTC
bug 384334 has been fixed in windows builds, but has not been merged into kdelibs git repo because of missing Windows reviewers.
Comment 18 Ralf Habacker 2017-12-19 17:45:49 UTC
The completed translation state has not been changed very much in the last month, so I'm planning to release an 4.8.1 source tarball (from tag 4.8.1) with recent translations at the end of this week. The plan is to submit the tarball at 2017/12/23 to upload.kde.org with the hope that it will be available at 2017/12/24. 
It would be nice if someone can prepare a news entry for the website and send it to me or push it into the websites/kmymoney-org at that time.
Comment 19 Ralf Habacker 2017-12-24 12:19:13 UTC
Files has been uploaded to ftp://upload.kde.org/incoming
Comment 20 Ralf Habacker 2017-12-27 10:49:03 UTC
Released  4.8.1 as 4.8.1.1 with a related news.
Comment 21 Ralf Habacker 2017-12-29 19:46:49 UTC
(In reply to Ralf Habacker from comment #20)
> Released  4.8.1 as 4.8.1.1 with a related news.

If someone asks why this has been released as 4.8.1.1:
1. updating tarballs for a given release is only possible if the new file has a different name (e.g. an updated tar ball for kmymoney 4.8.1 need to be have version 4.8.1-0 or 4.8.1.1, see https://phabricator.kde.org/T7093#111956)
2. On building the windows release with obs I first tried to use an updated version of 4.8.1-1 as suggested by Ben Cooksley, which was not allowed as obs package version - I was forced to use 4.8.1.1.
3. 4.8.1.1 is source code compatible to 4.8.1 (it is build from the 4.8.1 tag), it contains only updated translations, therefore using a complete different version like 4.8.2 looks not applicable.
4. On releasing 4.8.1 it was planned to update the tarballs as soon as possible, but unfortunally it took about 3 months to get the "whatsnew" page translated for about 55% of languages for kmymoney. For example estonian translation will be probably available at the end of Januar or Februar 2018 (I was really surprised that it takes so long and that the process has so many hurdles)
5. Using 4.8.1 as version for the updated translation seems not to bee possible 3 month later, because version 4.8.2 is already targeted at Febr 2018 (https://bugs.kde.org/show_bug.cgi?id=387280#c2)