Bug 384334 - UAC message box pops up for kconf_update.exe
Summary: UAC message box pops up for kconf_update.exe
Status: RESOLVED FIXED
Alias: None
Product: kdelibs
Classification: Unmaintained
Component: general (show other bugs)
Version: 4.14.0
Platform: Other Microsoft Windows
: NOR normal
Target Milestone: ---
Assignee: kdelibs bugs
URL:
Keywords:
: 384708 (view as bug list)
Depends on:
Blocks: 381786
  Show dependency treegraph
 
Reported: 2017-09-04 04:42 UTC by Ralf Habacker
Modified: 2020-01-14 10:29 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In: 4.14.40
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ralf Habacker 2017-09-04 04:42:09 UTC
At https://forum.kde.org/viewtopic.php?f=69&t=141673&sid=ba4dcaa26018f16e19d21c58c34ad4e9 a user reported a popping up uac message box refering to kconf_update.exe

How to reproduce ?
1. On Windows 7 search for uac, start and set to highest level, restart if requested
3. download https://software.opensuse.org/package/mingw32-kmymoney-portable and unpack into a folder
4. open command shell in unpack bin folder
5. run kconf_update.exe

What happens ?
A UAC message box pops up

What is expected ?
The UAC message box should not pop up

Additional information:
1. According to https://stackoverflow.com/questions/20096706/how-does-windows-decide-whether-to-display-the-uac-prompt is this a 32bit only problem. The 64 bit variant should not have this problem.
Comment 1 Ralf Habacker 2017-09-04 04:59:17 UTC
Fixed in mingw32-kdelibs package with the following patch https://build.opensuse.org/package/view_file/windows:mingw:win32/mingw32-kdelibs4/add-uac-to-kconf-update.patch?expand=1. An Updated snapshot should be available after rebuilding the packages.
Comment 2 Jack 2017-09-04 15:32:47 UTC
This seems more like a kde-windows issue than kmymoney.  Are they aware of this issue?  I don't know if a message to the mailing list would be enough or if this bug should just be reassigned to them.
Comment 3 Ralf Habacker 2017-09-05 06:35:31 UTC
(In reply to Jack from comment #2)
> This seems more like a kde-windows issue than kmymoney.  
I guess this depends from the point of view - the users faced with this problem may say that the installer or portable application as whole is KMyMoney while looking at the technical internals this issue belongs to kdelibs.
 
> Are they aware of this issue?
yes, https://git.reviewboard.kde.org/r/130239/

> if this bug should just be reassigned to them
good idea - I will also add bug 381786 as been blocked by this bug
Comment 4 Ralf Habacker 2017-09-15 17:14:40 UTC
*** Bug 384708 has been marked as a duplicate of this bug. ***
Comment 5 Ralf Habacker 2017-11-24 21:46:34 UTC
This bug has been fixed in the related windows builds, but is currently not merged into kdelibs git repository because of missing reviewers for Windows
Comment 6 Ralf Habacker 2017-12-27 10:46:14 UTC
Git commit 246298e57ed7ff7a3cbabe5fc9f95957cb6dc257 by Ralf Habacker.
Committed on 26/12/2017 at 21:06.
Pushed by habacker into branch 'KDE/4.14'.

Add Windows manifest to  kconf_update.exe

This explicitly sets the execution level to 'asInvoker', preventing
Windows' UAC heuristics from deciding that because its name mentions
"update", it probably needs to escalate privileges.

FIXED-IN:4.14.38
REVIEW:130239

M  +10   -0    kconf_update/CMakeLists.txt

https://commits.kde.org/kdelibs/246298e57ed7ff7a3cbabe5fc9f95957cb6dc257
Comment 7 Christoph Feck 2018-01-02 15:40:14 UTC
> FIXED-IN:4.14.38

That version was already released in November. It was also the final kdelibs4 release together with KDE Applications, so if you need to distribute tarballs with this commit included, you need to find someone to create/release the tarballs.
Comment 8 Ralf Habacker 2018-01-02 19:46:52 UTC
(In reply to Christoph Feck from comment #7)
> > FIXED-IN:4.14.38
> 
> That version was already released in November. 
The review has been opened in Sep 2017, but was delayed because of missing reviewers.
> It was also the final kdelibs4 release together with KDE Applications,
> so if you need to distribute tarballs with this commit included,
> you need to find someone to create/release the tarballs.

Thanks for this pointer. As long as there are major KF5 issues on Windows it will be required to use it for Windows.
Comment 9 Ralf Habacker 2020-01-14 10:29:57 UTC
Git commit 2deeeae2fcdca573baeec523d6569a2da017a039 by Ralf Habacker.
Committed on 14/01/2020 at 10:29.
Pushed by habacker into branch 'KDE/4.14'.

Exclude kconf_update from being catched by uac on Windows

Summary:
Exclude kconf_update from being catched by uac on Windows

FIXED-IN:4.14.40

Test Plan:
Compiled at https://build.opensuse.org/package/show/windows%3Amingw%3Awin32/mingw32-kdelibs4
and tested with KMyMoney snapshot for Windows downloadable
from https://software.opensuse.org/package/mingw32-kmymoney-portable

Reviewed at https://git.reviewboard.kde.org/r/130239/

M  +28   -0    cmake/modules/Win32Macros.cmake
M  +2    -9    kconf_update/CMakeLists.txt

https://commits.kde.org/kdelibs/2deeeae2fcdca573baeec523d6569a2da017a039