Bug 297842 - Navigating the list with the keyboard when a search filter is entered
Summary: Navigating the list with the keyboard when a search filter is entered
Status: RESOLVED FIXED
Alias: None
Product: plasma4
Classification: Unmaintained
Component: widget-kickoff (show other bugs)
Version: 4.8.2
Platform: unspecified Linux
: NOR normal
Target Milestone: ---
Assignee: Rick Stockton
URL:
Keywords: regression
: 299593 300576 300740 301668 302914 303132 303874 (view as bug list)
Depends on:
Blocks:
 
Reported: 2012-04-10 12:50 UTC by europium
Modified: 2012-10-16 18:34 UTC (History)
17 users (show)

See Also:
Latest Commit:
Version Fixed In: 4.9.2
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description europium 2012-04-10 12:50:42 UTC
Hi there,

the arrow keys can directly be used to navigate inside the k-menu.

But when a search filter is written, the up/down arrows are no directly active to navigate the filtered list. When clicking the shift key, the up/down arrows become active.
Could the up/down arrows be active without having to press shift?

Thanks!
Comment 1 Claudio 2012-04-22 10:27:26 UTC
Hi

First thanks for the tip with the shift key @ europium.
I wanted to add that this worked as wished up to KDE 4.8.1 - the 4.8.2 (Kubuntu 11.10) update broke this behavior.
Comment 2 Till Schäfer 2012-04-24 12:51:05 UTC
it used to work in previous versions without the shift key. so i guess this is more a broken feature (bug) as a wish.
Comment 3 ThorbjørnTux 2012-05-12 19:53:49 UTC
Yes, this used to work and it is an annoying bug.
Comment 4 Christoph Feck 2012-05-24 22:42:54 UTC
*** Bug 300576 has been marked as a duplicate of this bug. ***
Comment 5 Jekyll Wu 2012-05-27 19:32:23 UTC
*** Bug 299593 has been marked as a duplicate of this bug. ***
Comment 6 Jekyll Wu 2012-05-27 19:46:00 UTC
maybe introduced by this change: https://git.reviewboard.kde.org/r/104422/
Comment 7 Jekyll Wu 2012-05-28 09:20:30 UTC
*** Bug 300740 has been marked as a duplicate of this bug. ***
Comment 8 kdebugs 2012-05-29 03:16:09 UTC
*** This bug has been confirmed by popular vote. ***
Comment 9 Darin McBride 2012-06-11 22:50:59 UTC
Any hope of this being fixed in 4.8.5, or is 4.9 the next release anyway?
Comment 10 Jekyll Wu 2012-06-12 03:19:37 UTC
*** Bug 301668 has been marked as a duplicate of this bug. ***
Comment 11 Anne-Marie Mahfouf 2012-06-12 08:42:04 UTC
Darin it works on KDE 4.9 beta, it's only in KDE 4.8 that it is broken and we did not schedule any further 4.8 releases.
Comment 12 Marco Martin 2012-06-25 09:27:02 UTC
yes, i can confirm it's fixed with 4.9 beta and master, so reopen only if appears again in the 4.9 series
Comment 13 Jekyll Wu 2012-07-02 18:16:18 UTC
*** Bug 302914 has been marked as a duplicate of this bug. ***
Comment 14 Jekyll Wu 2012-07-07 00:41:39 UTC
*** Bug 303132 has been marked as a duplicate of this bug. ***
Comment 15 Janek Bevendorff 2012-07-21 09:41:39 UTC
*** Bug 303874 has been marked as a duplicate of this bug. ***
Comment 16 Rick Stockton 2012-08-18 00:57:23 UTC
(In reply to comment #12)
> yes, i can confirm it's fixed with 4.9 beta and master, so reopen only if
> appears again in the 4.9 series

Marco, this bug (and the recently closed Duplicates) are with regard to 4.8.x, with x > 1 (not 4.9). Do we plan a 4.8.6? If so, I'd like to re-open and take this myself. I broke it, so I fix it.
Comment 17 Rick Stockton 2012-08-22 16:07:07 UTC
I have a fix, but it has limitations. (Basically, the MVC "Controller" doesn't know where you _were_ when you press an arrow key - it can only pay attention to what is "visible", and it makes flakey guesses about sending your arrow into the "correct" view. IMO, bad design, and a more complete fix becomes something of a re-design.) I hope that you consider these 'rules' to be minor issues.

The following two rules apply under the fix I have written -

#1: To ENTER or LEAVE from the Search "data entry" field (after you have pressed "Key_Enter" or "Key_Return" to provoke the search results" panel of matching applications), you press "Key_Tab". But, in order to get your cursor back into the Search "data entry" field, to modify your search, you will usually have to press the Tab key twice. (Hint for rule #2: Upon most istances of the pressing the Tab Key, your search data text will highlighted - and easy to delete all at once, by simply pressing "Key_Delete" while your text is in highlighted state.) 

#2: If you do not wish to choose frrm any your search results, and wish to see one of the "Category Tabs" instead (e.g. "Applications", "Recently Used", etc.):  You must "clear away" all of the characters in the search data entry data field. This rule applies whenever the "Category Tabs" are not visible - even in the situation where your "search results" are an empty panel! Press Key_Tab until your search data entry text is Highlighted, and then press Key_Delete. The Applications Category will re-appear.
Comment 18 Rick Stockton 2012-08-22 16:10:42 UTC
I am about to put the fix onto the 4.8 branch. But, since KDE has no plans to create a 4.8.6 "Release", it will become a "Downstream" issue -- you will need to have your Distro Packagers create a "4.8.5-n", or build yourself.
Comment 19 Rick Stockton 2012-08-22 20:14:10 UTC
(In reply to comment #17)
> I have a fix, but it has limitations. (Basically, the MVC "Controller"....)

Let me make that more simple:

The Up/Down arrows will work for moving around within an Applications View (or a search results view which shows more than one program). In SOME situations, Key_Down or Key_Up IS capable of moving between view -- But for moving to the Search Bar, and to/from the search bar results, Qt::Key_Tab (new feature) is the keystroke which ALWAYS works.

Within a view: Arrow keys.
Between views: Tab Key.
Comment 20 Rick Stockton 2012-08-25 05:40:30 UTC
https://git.reviewboard.kde.org/r/106125/ for 4.9
Comment 21 Rick Stockton 2012-08-25 05:42:24 UTC
https://git.reviewboard.kde.org/r/106123/ for 4.8
Comment 22 Gregor Tätzner 2012-08-31 06:41:54 UTC
Git commit a97173bbce9085e5df7f9a22601300c50e84b030 by Gregor Tätzner.
Committed on 31/08/2012 at 08:34.
Pushed by gregort into branch 'KDE/4.9'.

Add keyboard navigation to Kickoff GUI (within and among all Views)

Fixes regression in KDE 4.9. Enables movement between views with tab
key.
Related: bug 276932
FIXED-IN: 4.9.1
REVIEW: 106125

M  +27   -11   plasma/desktop/applets/kickoff/ui/launcher.cpp
M  +7    -0    plasma/desktop/applets/kickoff/ui/searchbar.cpp

http://commits.kde.org/kde-workspace/a97173bbce9085e5df7f9a22601300c50e84b030
Comment 23 Gregor Tätzner 2012-08-31 06:56:24 UTC
Git commit e44b48c6fa1f9875f1189f495b9981ac92a1eb36 by Gregor Tätzner.
Committed on 31/08/2012 at 08:34.
Pushed by gregort into branch 'master'.

Add keyboard navigation to Kickoff GUI (within and among all Views)

Fixes regression in KDE 4.9. Enables movement between views with tab
key.
Related: bug 276932
FIXED-IN: 4.9.1
REVIEW: 106125

M  +27   -11   plasma/desktop/applets/kickoff/ui/launcher.cpp
M  +7    -0    plasma/desktop/applets/kickoff/ui/searchbar.cpp

http://commits.kde.org/kde-workspace/e44b48c6fa1f9875f1189f495b9981ac92a1eb36
Comment 24 Albert Astals Cid 2012-09-02 22:27:38 UTC
Too late for 4.9.1
Comment 25 Claudio 2012-10-03 14:44:42 UTC
Hi

The update to 4.9.2 broke it again :(
It worked at least in 4.9.0 and 4.9.1.
The trick by holding down the shift key and press a cursor key also doesn't work anymore.
Comment 26 Rick Stockton 2012-10-03 17:36:13 UTC
Claudio, is there a reason why you can't use the "tab" key for this function? That's the new workaround/fix. 

Don't forget, you might need to press "tab" more than once. Behavior varies, depending on where you are in the GUI.)
Comment 27 Claudio 2012-10-03 18:31:01 UTC
Hi Rick

OK I didn't know that it's now working with the TAB key (it didn't in 4.8.X and 4.9.1).
I tried it now but it's not as comfortable as before:
e.g.: I want to open Synaptic Package Manager (Kubuntu)

I open the K Menu enter "syna" ( 3 entries are found and displayed in the following order: synaptiks, Synaptic, Touchpad settings).

Up to 4.9.1:  Now I press 2x the down arrow key (1. to select synaptiks and 2. for Synaptic) and Enter to start the software.

Since 4.9.2:  Now I have to press TAB (synaptiks is selected), arrow down (for some reason it ignores the Synaptic entry and jumps to the 3. entry in the list "Touchpad Configuration") and arrow up key to finally get to "Synaptic" and start it with Enter.

So at the moment I have to press 3 different keys (TAB, down, up) to go where I want instead to 2x the same key (down, down). In Krunner it's still working as before btw (maybe I should be using Krunner more *g* ).
Comment 28 Bojan Vitnik 2012-10-04 12:59:15 UTC
I can confirm what Claudio said. It kills productivity and is just plain annoying.

I was not aware that this bug was discussed here so I reported it as bug 307823. Sorry :(.
Comment 29 Rick Stockton 2012-10-16 18:34:29 UTC
Git commit 8867c8f95133b09bc02ff7f455bd03cc0d8736ce by Rick Stockton.
Committed on 16/10/2012 at 20:30.
Pushed by stockton into branch 'KDE/4.9'.

Fix usage regressions (keyboard-only) in Kickoff-Widget 4.9.2

Bring back Up/Down arrow support for leaving applicationView,
while also keeping the ability to execute applicationView items.
Related: bug 307823
FIXED-IN: 4.9.3

M  +22   -8    plasma/desktop/applets/kickoff/ui/flipscrollview.cpp
M  +1    -0    plasma/desktop/applets/kickoff/ui/flipscrollview.h
M  +89   -44   plasma/desktop/applets/kickoff/ui/launcher.cpp
M  +3    -1    plasma/desktop/applets/kickoff/ui/launcher.h
M  +10   -8    plasma/desktop/applets/kickoff/ui/searchbar.cpp

http://commits.kde.org/kde-workspace/8867c8f95133b09bc02ff7f455bd03cc0d8736ce