Bug 242073 - manually moved desktop items lose their position just by changing one icon
Summary: manually moved desktop items lose their position just by changing one icon
Status: RESOLVED WORKSFORME
Alias: None
Product: plasma4
Classification: Plasma
Component: widget-folderview (show other bugs)
Version: unspecified
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: Plasma Bugs List
URL:
Keywords:
: 226813 251752 (view as bug list)
Depends on:
Blocks:
 
Reported: 2010-06-18 15:11 UTC by Jonathan Marten
Modified: 2011-06-03 23:47 UTC (History)
6 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Quick fix (458 bytes, patch)
2010-06-18 15:11 UTC, Jonathan Marten
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Marten 2010-06-18 15:11:06 UTC
Created attachment 48107 [details]
Quick fix

Version:           unspecified (using Devel) 
OS:                Linux

Using the folderview as the desktop, it is possible to move icons around manually (if the "Icons - Lock in Place" option is off).  However, if this is done and then the icon of one of the items is changed (via its "Properties" dialogue), all of the desktop icons revert to their default position.

This happens regardless of the "Lock in Place" setting.


Reproducible: Always

Steps to Reproduce:
Set the folderview as the desktop containment.
Create some items (a link to an external URL or a local device will do).
Set "Lock in Place" off, and move some of the items around on the desktop.
Set "Lock in Place" on.

Right-click on one of the icons (it doesn't matter which one) and select "Properties".

Set a new icon by clicking on the current one (top left) and selecting a different icon (the category doesn't matter).

Click "OK".


Actual Results:  
The icon of the changed item is updated as expected, but all of the items also revert to their default position at the top left.


Expected Results:  
The manually placed items should not move.


Applying the patch as in the attachment fixes the problem by brute force (ignoring the model's layoutChanged() signal if the icons are locked).  But this is probably not the right thing to do.
Comment 1 Vaso 2010-10-20 10:09:57 UTC
I think there are some related bugs:

https://bugs.kde.org/show_bug.cgi?id=226813
https://bugs.kde.org/show_bug.cgi?id=244525
https://bugs.kde.org/show_bug.cgi?id=251752
https://bugs.kde.org/show_bug.cgi?id=247505

My observation:

1. Position of objects are not remembered by folderview (after logout/login) if one of object is an image.
2. Position of objects resets immediately when an image is added.
Comment 2 Markus Grob 2010-11-12 12:18:27 UTC
*** Bug 251752 has been marked as a duplicate of this bug. ***
Comment 3 Markus Grob 2010-11-12 12:22:51 UTC
Like described in Bug 251752 it works for me in this case in 4.5.3, but the icons don't held they're position if I start KDE up again after aranging.
Comment 4 Jon Nelson 2011-02-01 02:36:01 UTC
Still a problem with 4.6.0
Comment 5 Aaron J. Seigo 2011-02-01 09:17:26 UTC
*** Bug 226813 has been marked as a duplicate of this bug. ***
Comment 6 Vaso 2011-04-26 20:00:57 UTC
Doesn't reproduced on 4.6.2. Fixed?
Comment 7 Beat Wolf 2011-05-28 20:28:19 UTC
Is this still a problem? otherwise i close this bugreport. thanks
Comment 8 Jonathan Marten 2011-05-28 21:32:29 UTC
Cannot reproduce on icon change with current trunk, although have not tried all circumstances in all duplicates.  Will reopen if necessary.
Comment 9 Markus Grob 2011-06-03 21:18:26 UTC
Works now for me. Suse 11.4 with KDE 4.6.0