Bug 226202 - [PATCH] K-menu(classical): switched name and description for category Games
Summary: [PATCH] K-menu(classical): switched name and description for category Games
Status: RESOLVED DUPLICATE of bug 241736
Alias: None
Product: plasma4
Classification: Unmaintained
Component: widget-kickoff (show other bugs)
Version: unspecified
Platform: Arch Linux Linux
: NOR normal
Target Milestone: ---
Assignee: Plasma Bugs List
URL:
Keywords:
: 228594 234070 (view as bug list)
Depends on:
Blocks:
 
Reported: 2010-02-10 22:25 UTC by cthx
Modified: 2010-06-24 17:00 UTC (History)
6 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description cthx 2010-02-10 22:25:08 UTC
Version:            (using KDE 4.4.0)
OS:                Linux
Installed from:    Archlinux Packages

language: ru (with "us english" is no problem)

but in menu editor name and description are correct
Comment 1 Aaron J. Seigo 2010-02-10 22:31:38 UTC
that's because the categories for games are meaningless. games are odd that way: it isn't enough to just know it's a "card game" (especially when they are all already under the "Card Game" submenu ;). the name of the game is actually really important for identification.

this isn't true for things like word processors.

ergo the change. which is to say, this is intentional and not a bug.
Comment 2 cthx 2010-02-11 00:03:17 UTC
yes, its ok for menu configured for Name - Description (if both is present)

I've chooseт option "Only names" but have description instead of name.
I have not only kde games (with good description), some games has in description like "Game" or "Arcade game" :) so, this feature is nog good for me :)
Comment 3 Vinícius 2010-02-13 05:39:57 UTC
Confirmed in kde 4.4.0 self compiled. If I set to show only names, it shows the description without name, if I set to show only description, then it shows the only the name...
Comment 4 Christoph Feck 2010-02-16 15:28:30 UTC
I also use "names only", and when someone says to try game "bovo", I am lost, because the name does not show in the menu.
Comment 5 Kevin Kofler 2010-02-26 21:49:56 UTC
*** Bug 228594 has been marked as a duplicate of this bug. ***
Comment 6 Kevin Kofler 2010-02-26 21:52:28 UTC
@Aaron: I see why you made the change for the Kickoff menu. However, in the classic menu, this is broken, as the classic menu uses DisplayRole as description and SubtitleRole as name and then formats it according to its own formats, e.g. Name - Description, so you end up with seeing Description - Name instead. Please test this kind of changes with the classic menu as well next time!

I have successfully tested the following fix:
http://cvs.fedoraproject.org/viewvc/rpms/kdebase-workspace/F-12/kdebase-workspace-4.4.0-classicmenu-games.patch?revision=1.1&view=markup
Basically, this adds a ForceNameAfterDescription DisplayOrder and uses that in
the classic menu.
Comments? Objections? Approvals? Do you want me to commit this?
Comment 7 Christoph Feck 2010-04-11 18:54:08 UTC
*** Bug 234070 has been marked as a duplicate of this bug. ***
Comment 8 Luciano Montanaro 2010-04-11 19:14:09 UTC
Erm... I have been puzzled for a while now, and opened bug 234070 in the while.

To sum this up, how do we proceed? 
The default menu is not the only one affected, there are at least two other menu replacement. If the underlying model lies, bad things are going to happen sooner or later. 

I understand you want to give meaningful titles, but perhaps it could be done by 
1 - coordinating with kdegames developers -- this is likely to be needed anyway.
    The used field is named "GenericName", not description anyway. It should provide 
    either a name like "chess" for a chess game, or a longer better version of the 
    game name or be removed if there is no "generic" version of the program/game.
2 - do the special casing in the view instead
Comment 9 Beat Wolf 2010-05-18 10:42:07 UTC
so whats up with this patch? should it be merged? should something else be made about it?
Comment 10 Christoph Feck 2010-06-24 17:00:41 UTC

*** This bug has been marked as a duplicate of bug 241736 ***