Bug 187587 - cue sheet not working for files in collection
Summary: cue sheet not working for files in collection
Status: CONFIRMED
Alias: None
Product: amarok
Classification: Applications
Component: Playback/CUE sheet support (show other bugs)
Version: 2.7-git
Platform: unspecified Linux
: NOR normal
Target Milestone: 2.8
Assignee: Amarok Developers
URL:
Keywords:
: 191185 222157 230272 272879 279234 291775 380098 (view as bug list)
Depends on:
Blocks: 270003 286089 294136
  Show dependency treegraph
 
Reported: 2009-03-19 11:13 UTC by simon
Modified: 2017-10-25 08:03 UTC (History)
36 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
patch (3.34 KB, patch)
2011-01-02 21:01 UTC, Anton Revunov
Details
CUE file (2.20 KB, text/plain)
2011-09-12 17:22 UTC, sdeber
Details

Note You need to log in before you can comment on or make changes to this bug.
Description simon 2009-03-19 11:13:18 UTC
Version:           2.1-SVN (using 4.2.67 (KDE 4.2.67 (KDE 4.3 >= 20090318)), Gentoo)
Compiler:          x86_64-pc-linux-gnu-gcc
OS:                Linux (x86_64) release 2.6.26-tuxonice

hi,

it seems cue sheets are still under development so this is just a reminder:

* please also integrate the tracks defined in the cue sheet in the collection
* use cue sheet bookmarks for file that are in collection (currently works only when addy files using the file browser)
Comment 1 Jared B. 2009-08-03 12:09:50 UTC
I've been testing out Amarok 2.1 and I noticed that bug 145661 is still present.  Is fixing this behavior included in your reminder (I'm not really sure what that second bullet is supposed to mean)?  If so, great!  If not, I'll open a new bug report as to not hijack this one.

Thanks.
Comment 2 Myriam Schweingruber 2009-08-03 12:31:27 UTC
Jared, the current testing environment is 2.2-git. Please check the current bugs lists at http://tinyurl.com/ourbugs and http://tinyurl.com/needsinfo before filing a new bug.
Comment 3 Casey Link 2009-09-21 10:26:06 UTC
*** Bug 191185 has been marked as a duplicate of this bug. ***
Comment 4 Mike Lenzen 2009-09-21 14:59:22 UTC
*** This bug has been confirmed by popular vote. ***
Comment 5 Martin 2009-11-20 12:04:44 UTC
Hi, something new ?
I really miss this feature. 
I am not a programmer, but i don't understand where is the problem if it was fully working in 1.4.
Comment 6 Eelko Berkenpies 2009-11-20 12:20:50 UTC
Martin, you can not compare Amarok 2.x with Amarok 1.x. Amarok 2 has (almost) been a complete rewrite of the 1.x series and therefore it doesn't mean if it "was there" in 1.4, that it will be back in 2.0.

I still miss this feature too. I guess we have to wait just a little bit longer. :)
Comment 7 Myriam Schweingruber 2010-01-11 10:42:30 UTC
Moving to bugs
Comment 8 Myriam Schweingruber 2010-01-11 10:43:34 UTC
*** Bug 222157 has been marked as a duplicate of this bug. ***
Comment 9 Myriam Schweingruber 2010-08-11 08:35:37 UTC
*** Bug 230272 has been marked as a duplicate of this bug. ***
Comment 10 RussianNeuroMancer 2010-08-11 20:36:06 UTC
About marking 230272 bug as duplicate. If 230272 is duplicate then this bug can be closed only when Amarok will support embedded cue. I want to warn - support of embedded cue is a another difficult task then just support external cue (what about this bug), and better to implement cue support step by step - support external cue for first, and support of embedded cue later. Then better set 230272 openede like a different bug.
Comment 11 Matej Repinc 2010-08-11 20:40:24 UTC
What about if developers would first try to implement a partial solution like looking for cue sheet in a directory where file from collection is stored?
Comment 12 RussianNeuroMancer 2010-08-11 20:43:16 UTC
Yes, this is exactly what I propose.
Comment 13 Jared B. 2010-08-11 20:56:47 UTC
(In reply to comment #11)
> What about if developers would first try to implement a partial solution like
> looking for cue sheet in a directory where file from collection is stored?

Amarok already does that.  However, it uses the cue sheet in a broken manner as described in bugs 209341 and 145661.  I'd really rather see the developers prioritize fixing the existing cue sheet support before adding any new features.
Comment 14 Vovochka 2010-10-28 09:31:20 UTC
It's Amarok 2.3.2

But amarok still doesn’t react right on cue files in collections.
cue albums presents as a single file. Not as separate files :(
Comment 15 Hagai Kariti 2010-12-11 12:01:53 UTC
Still doesn't work correctly in 2.6 Beta2. cue sheets albums in the collection are presented as single tracks (no bookmarks either). However, it seems to work correctly when adding cue albums not from the collection - if I drag the FLAC file to the playlist from a directory that's part of the collection, it doesn't work; if I symlink it to a different place it does work. Dragging the cue sheet doesn't work either way.
Comment 16 Myriam Schweingruber 2010-12-11 18:23:01 UTC
I am sure you mean 2.4 beta 1, there hasn't been any other release since.
Comment 17 Hagai Kariti 2010-12-11 19:05:26 UTC
whoops, my bad. 4.6 beta2, amarok 2.4 beta1 :)
Comment 18 Anton Revunov 2011-01-02 21:01:34 UTC
Created attachment 55484 [details]
patch

I made a patch for Amarok 2.3.2 as a temporary solution. It works for me and my collection. Required to re-add tracks to the playlist. Does not work for drag-and-drop, only from popup menu.
Comment 19 Myriam Schweingruber 2011-01-04 15:24:25 UTC
Thanks for the patch, Anton. Could you please submit it to http://git.reviewboard.kde.org ? (you will need to register with http://identity.kde.org first)
Comment 20 Anton Revunov 2011-01-04 20:28:43 UTC
(In reply to comment #19)
> Thanks for the patch, Anton. Could you please submit it to
> http://git.reviewboard.kde.org ? (you will need to register with
> http://identity.kde.org first)

I did it.
Comment 21 simon 2011-01-17 09:53:16 UTC
still missing feature from 1.4 as the patch didn't get accepted
Comment 22 Razvan 2011-01-21 22:03:05 UTC
(In reply to comment #6)
> Martin, you can not compare Amarok 2.x with Amarok 1.x. Amarok 2 has (almost)
> been a complete rewrite of the 1.x series and therefore it doesn't mean if it
> "was there" in 1.4, that it will be back in 2.0.
> 
> I still miss this feature too. I guess we have to wait just a little bit
> longer. :)

and longer...and longer...and longer...and longer...and longer (should I continue?)
Comment 23 Myriam Schweingruber 2011-05-10 04:02:18 UTC
*** Bug 272879 has been marked as a duplicate of this bug. ***
Comment 24 Myriam Schweingruber 2011-06-04 12:11:30 UTC
This is an automated message from the triager:

Amarok 2.4.1 has been released on May 8 already. Could you please upgrade and test if you can still reproduce this bug?

Without feedback within a month we will close this bug as resolved.

Thank you for your understanding.
Comment 25 sdeber 2011-06-04 13:07:14 UTC
(In reply to comment #24)
> This is an automated message from the triager:
> 
> Amarok 2.4.1 has been released on May 8 already. Could you please upgrade and
> test if you can still reproduce this bug?
> 
> Without feedback within a month we will close this bug as resolved.
> 
> Thank you for your understanding.

Just tested, it still does not work in 2.4.1
Comment 26 Myriam Schweingruber 2011-06-04 14:42:11 UTC
Thank yo for the fast feedback.
Comment 27 Myriam Schweingruber 2011-06-05 12:01:19 UTC
From Amarok Development Sprint Randa 2011:

Ralf, could you have a look at this? This is the most hated bug in Amarok as of now. Bart suggest using bounded playback.
Comment 28 Martin Vala 2011-09-12 14:36:38 UTC
(In reply to comment #27)
> From Amarok Development Sprint Randa 2011:
> 
> Ralf, could you have a look at this? This is the most hated bug in Amarok as of
> now. Bart suggest using bounded playback.

Hi All,

Currently i am testing Amarok 2.4.3 and finaly it is working. But still one small bug. When new song starts time of song still stays on 0:00 and it is playing first song again. But when i click on progress bar for example to 0:01 then correct song starts to play.

I think this is is quite easy to fix.

After that i will be soooo happy to play cue with ogg.

Thanks

Ciao

Martin
Comment 29 sdeber 2011-09-12 17:22:37 UTC
Created attachment 63593 [details]
CUE file
Comment 30 sdeber 2011-09-12 17:24:38 UTC
(In reply to comment #28)
> (In reply to comment #27)
> > From Amarok Development Sprint Randa 2011:
> > 
> > Ralf, could you have a look at this? This is the most hated bug in Amarok as of
> > now. Bart suggest using bounded playback.
> 
> Hi All,
> 
> Currently i am testing Amarok 2.4.3 and finaly it is working. But still one
> small bug. When new song starts time of song still stays on 0:00 and it is
> playing first song again. But when i click on progress bar for example to 0:01
> then correct song starts to play.
> 
> I think this is is quite easy to fix.
> 
> After that i will be soooo happy to play cue with ogg.
> 
> Thanks
> 
> Ciao
> 
> Martin

It does not seem to work for me, for example the file attached in Comment #29 is not recognized by the collection manager. I also tried to rename the file to CDImage.cue, but still it did not work.
Comment 31 mojedokumenty 2011-11-10 19:20:18 UTC
Confirmed in Amarok 2.4.3 on KDE 4.7.2.

A user should be allowed to use an arbitrary name for the cue sheet.

When a music file is commited to the collection, amarok should perform a check if a cue sheet with the same file name exists, differing only in the extension.

Currently, cue sheets don't seem to work within file collection.

Strangely enough, drag and drop cue file support works as expected.
Comment 32 wgx 2011-11-23 12:09:11 UTC
(In reply to comment #28)
> (In reply to comment #27)
> > From Amarok Development Sprint Randa 2011:
> > 
> > Ralf, could you have a look at this? This is the most hated bug in Amarok as of
> > now. Bart suggest using bounded playback.
> 
> Hi All,
> 
> Currently i am testing Amarok 2.4.3 and finaly it is working. But still one
> small bug. When new song starts time of song still stays on 0:00 and it is
> playing first song again. But when i click on progress bar for example to 0:01
> then correct song starts to play.
> 
> I think this is is quite easy to fix.
> 
> After that i will be soooo happy to play cue with ogg.
> 
> Thanks
> 
> Ciao
> 
> Martin
I have the same problem with you! I also find that after it played first song again,it will play the next song and after that first song will be  played again.Strange bug.
Comment 33 Bart Cerneels 2011-11-25 11:35:52 UTC
Cue sheets found in the collection folders will be supported starting version 2.6

- Detect cue-sheets in collectionscanner, report them as regular playlist files.
- SqlScanResultProcessor handles cue sheets different from other playlists. Stores timecoded urls (partial playback) indatabase for each entry.
- Handled as regular tracks from now on.
Comment 34 RussianNeuroMancer 2012-01-12 04:30:23 UTC
Will Amarok support embedded cue sheets in FLAC, WavPack, etc? https://bugs.kde.org/show_bug.cgi?id=230272
Will Amarok preferred tags from cue for track releases with cue?
Comment 35 Myriam Schweingruber 2012-02-10 14:55:11 UTC
Setting status to NEW, else this doesn't show in the filters.
Comment 36 Myriam Schweingruber 2012-02-10 14:57:19 UTC
Actually it does, but was in the wrong component, sorry for the noise.
Comment 37 simon 2012-02-17 12:36:44 UTC
@bart: is there already a branch where this can be tested?
Comment 38 Myriam Schweingruber 2012-04-24 12:15:58 UTC
*** Bug 291775 has been marked as a duplicate of this bug. ***
Comment 39 Martin Vala 2012-04-24 12:19:14 UTC
Any news on that? Can we test it?

Ciao

Martin
Comment 40 Myriam Schweingruber 2012-04-24 12:25:44 UTC
I don't think that there is anything to test yet, else Bart would have Cc'ed this report with a commit.
Comment 41 Myriam Schweingruber 2012-05-08 11:38:20 UTC
Sometimes real life gets in the way, so this is pushed to 2.7 as we are about to release 2.6 and Bart doesn't find enough time to work on it right now. Sorry about that.
Comment 42 Myriam Schweingruber 2012-05-08 11:45:08 UTC
*** Bug 279234 has been marked as a duplicate of this bug. ***
Comment 43 Ralf Engels 2012-12-11 16:07:54 UTC
Bart,
I don't have that much knowledge about the cue sheet support. I guess it's not enough for the collectionscanner to just report a cue sheet as a normal song, is it?
Comment 44 Bart Cerneels 2012-12-12 07:35:02 UTC
(In reply to comment #43)
> Bart,
> I don't have that much knowledge about the cue sheet support. I guess it's
> not enough for the collectionscanner to just report a cue sheet as a normal
> song, is it?

The first step is reporting the .cue. The collection then has to create individual Tracks for each of the parts, with metadata read from the .cue. To make it all work those tracks need to be time-coded and it has to work automatically in EngineController. It might work with the BoundedPlaybackCapability, but I was thinking of just adding a query argument to the playableUrl that the Engine can interpret.
Comment 45 RussianNeuroMancer 2012-12-12 08:07:29 UTC
Also it's important to not treat files that already part of cue as separate tracks.
Comment 46 LoneStar 2013-09-04 22:02:53 UTC
Hi,
are there any news on this? will it ever be supported?
Comment 47 Mark Kretschmann 2013-09-05 15:23:11 UTC
We have a Season of KDE student who is going to work on Cue Sheet support soon.
Comment 48 matthias sweertvaegher 2013-09-05 18:07:55 UTC
great news!

On Thu, Sep 5, 2013 at 5:23 PM, Mark Kretschmann <kretschmann@kde.org> wrote:
> https://bugs.kde.org/show_bug.cgi?id=187587
>
> --- Comment #47 from Mark Kretschmann <kretschmann@kde.org> ---
> We have a Season of KDE student who is going to work on Cue Sheet support soon.
>
> --
> You are receiving this mail because:
> You voted for the bug.
Comment 49 Dotan Cohen 2017-02-22 15:01:42 UTC
I can confirm that this issue is not resolved in Amarok 2.8.0. Playing .flac files with a .cue sheet in the same directory does not provide track information.
Comment 50 Myriam Schweingruber 2017-05-22 23:11:40 UTC
*** Bug 380098 has been marked as a duplicate of this bug. ***