Bug 184607 - composition disabled when adjusting system time
Summary: composition disabled when adjusting system time
Status: RESOLVED FIXED
Alias: None
Product: kwin
Classification: Plasma
Component: general (show other bugs)
Version: unspecified
Platform: unspecified Linux
: NOR normal
Target Milestone: ---
Assignee: KWin default assignee
URL:
Keywords:
: 187092 189403 196328 197820 (view as bug list)
Depends on:
Blocks:
 
Reported: 2009-02-17 10:05 UTC by Robin Pedersen
Modified: 2009-06-25 12:45 UTC (History)
5 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Robin Pedersen 2009-02-17 10:05:31 UTC
Version:            (using KDE 4.2.0)
OS:                Linux
Installed from:    Unlisted Binary Package

Packages:    Arch Linux official repositories

I used ntpdate to correct the system time, and kwin composition was immediately disabled, because it was "too slow".
Comment 1 Martin Flöser 2009-03-04 20:22:19 UTC
There is probably nothing we can do about it. The functionality uses Qt's QTime class to measure how long it takes to paint one frame. If you change your time settings, KWin cannot know it - this has to be fixed upstream at Qt Software.

Even if I don't think this is really a bug. No "real" damage is done, you can just use alt+shift+f12 to enable compositing again.
Comment 2 Robin Pedersen 2009-03-04 20:49:48 UTC
I haven't looked at the code, but I guess it should be possible to add a sanity check if the time is negative or above some threshold value, then assume that something other than bad performance caused it.

Another possibility might be to require an operation to be "too slow" a number of times before acting, and not kill the feature just because of one measurement indicating slow performance.
Comment 3 lucas 2009-03-05 04:41:48 UTC
I agree with Robin, sanity checks should be added. Negative time should have no effect on KWin's checks but anything over +30 seconds or so can be safely ignored.
Comment 4 Jose 2009-03-12 10:55:46 UTC
Also, when kwin disables compositing because it believes that it's being too slow (and most times it isn't) then it's not possible to enable compotition again through the GUI. It says that it cannot enable composite with the current configuration while it was working just a few seconds before.
Comment 5 lucas 2009-03-14 11:07:35 UTC
*** Bug 187092 has been marked as a duplicate of this bug. ***
Comment 6 Martin Flöser 2009-04-12 13:02:43 UTC
*** Bug 189403 has been marked as a duplicate of this bug. ***
Comment 7 Martin Flöser 2009-06-25 11:37:10 UTC
*** Bug 197820 has been marked as a duplicate of this bug. ***
Comment 8 lucas 2009-06-25 12:09:10 UTC
SVN commit 986962 by lmurray:

Prevent KWin from automatically disabling compositing when the user
changes the system time or timezone.
BUG: 184607


 M  +7 -0      composite.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=986962
Comment 9 lucas 2009-06-25 12:13:44 UTC
SVN commit 986966 by lmurray:

Backport:
Prevent KWin from automatically disabling compositing when the user
changes the system time or timezone.
CCBUG: 184607


 M  +7 -0      composite.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=986966
Comment 10 Martin Flöser 2009-06-25 12:45:06 UTC
*** Bug 196328 has been marked as a duplicate of this bug. ***