Bug 182830 - Large icons in sidebar tab titles
Summary: Large icons in sidebar tab titles
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Usability-Themes (show other bugs)
Version: 0.10.0
Platform: Ubuntu Unspecified
: NOR wishlist
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-02-02 08:36 UTC by Dotan Cohen
Modified: 2022-01-13 06:22 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 7.5.0


Attachments
mockup for new sidebar tab title style (100.10 KB, image/png)
2009-02-05 13:17 UTC, caulier.gilles
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Dotan Cohen 2009-02-02 08:36:38 UTC
Version:            (using KDE 4.2.0)
Installed from:    Ubuntu Packages

When the user selects Large Icons the setting is only applied to the toolbars above the photos, not to the icons in the sidebars. Please add the ability to enlarge the icons in the sidebars. Thanks.
Comment 1 Marcel Wiesweg 2009-02-02 11:15:18 UTC
What about Configure Digikam -> Album View -> Tree View Thumbnail Size?
I think icon size in the toolbar is a KDE-wide settings, is it?
Comment 2 Dotan Cohen 2009-02-02 11:59:22 UTC
Thank you, Marcel, but that adjusts the icons _in_ the sidebars, not the icons that let the user select _which_ sidebar is displayed. I am sorry for not making that clear.

The icons that I am referring to are these on the right:
Albums, Calendar, Tags, Timeline, Search

And these on the left:
Properties, Metadata, Colours, Captions, Filters
Comment 3 caulier.gilles 2009-02-02 12:07:16 UTC
Dotan,

Why do you want to changes these icon sizes ? It's not enough as well ?

Gilles
Comment 4 Mikolaj Machowski 2009-02-02 22:45:54 UTC
Technically this could be done like in Kontact or Okular. In this way you can make icons different size, show text.

Usability pro: bigger icons are more readable, easier to hit with mouse.
Comment 5 Dotan Cohen 2009-02-02 23:32:34 UTC
Gilles, the icons are tiny on my laptop. This Dell has a 129 DPI screen. I cannot see the icons comfortably. Furthermore, even on the desktop system we would prefer larger icons as the monitor is larger, but we sit further away from it.

In my opinion the icons should be the same size as the toolbar icons, for the same reasons.
Comment 6 caulier.gilles 2009-02-05 11:45:25 UTC
Dotan,

digiKam sidebar is based on KDE component KMultiTabBar. When we append a tab to a bar, we pass a pixmap as icon. If i change pixmap size to large value, it's downscaled automatically by KDE.

So, it's impossible to change icon size with KMultiTabBar.

... but there is another issue for your problem. KMultiTabBar style can be changed to always print tab title:

http://api.kde.org/4.x-api/kdelibs-apidocs/kdeui/html/classKMultiTabBar.html#1620e3aa198963c7d94233050139c827

Currently, VSNET style is used in digiKam, but i can add a setup to choose KDEV3ICON style. What do you think about ?

Gilles Caulier
Comment 7 caulier.gilles 2009-02-05 12:01:51 UTC
Here a screen-shot with KDEV3ICON sidebar style :

http://www.flickr.com/photos/digikam/3255563070/sizes/o/

Gilles Caulier
Comment 8 Mikolaj Machowski 2009-02-05 12:52:51 UTC
*I* like it. I see only two potential problems:
a) bad visual feedback about which tab is active (overall problem with Oxygen :/ )
b) how it fits on small screens - according to screenshot height of left tabs is ca. 700px, right tabs just over 600px; could you test how it works with minimized window to 600px of height?
Comment 9 caulier.gilles 2009-02-05 13:13:17 UTC
With small screen, it's not adapted. For ex, on my laptop (800*1280), not all sidebar tab are visible. In all case, by default, the current style must be selected for digiKam

About to improve visual feedback, a ticket can be open in KDELibs...

Gilles
Comment 10 caulier.gilles 2009-02-05 13:17:53 UTC
Created attachment 30982 [details]
mockup for new sidebar tab title style
Comment 11 caulier.gilles 2009-02-05 15:13:21 UTC
SVN commit 921697 by cgilles:

digiKam from trunk : Sidebar : it's now possible to select the sidebar type: tab tile always visible or only for active tab.
First one is dedicated for large screen. Second one is the default.
BUG: 182830


 M  +17 -0     digikam/albumsettings.cpp  
 M  +8 -0      digikam/albumsettings.h  
 M  +13 -0     digikam/digikamview.cpp  
 M  +2 -0      digikam/digikamview.h  
 M  +1 -1      digikam/iconview.cpp  
 M  +17 -0     showfoto/setup/setupeditor.cpp  
 M  +6 -2      showfoto/showfoto.cpp  
 M  +2 -2      showfoto/showfoto.h  
 M  +25 -16    utilities/cameragui/cameraui.cpp  
 M  +4 -2      utilities/cameragui/cameraui.h  
 M  +4 -4      utilities/cameragui/camerauiprivate.h  
 M  +10 -1     utilities/imageeditor/editor/imagewindow.cpp  
 M  +3 -1      utilities/imageeditor/editor/imagewindow.h  
 M  +38 -28    utilities/lighttable/lighttablewindow.cpp  
 M  +2 -0      utilities/lighttable/lighttablewindow.h  
 M  +5 -5      utilities/lighttable/lighttablewindowprivate.h  
 M  +19 -5     utilities/setup/setupalbumview.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=921697
Comment 12 Dotan Cohen 2009-02-05 18:16:59 UTC
>Dotan, digiKam sidebar is based on KDE
> component KMultiTabBar.

Thanks, I filed this bug (the component needs changing, though I don't know to what):
http://bugs.kde.org/show_bug.cgi?id=183339

> bad visual feedback about which tab
> is active (overall problem with Oxygen

I agree, it is extremely difficult to determine which icon is depressed. File the bug and link here, I will comment on it.

> SVN commit 921697 by cgilles

Thanks!
Comment 13 caulier.gilles 2009-02-05 18:20:41 UTC
to Mik, comment #8

>bad visual feedback about which tab is active (overall problem with Oxygen)

yes, i confirm. using other KDE theme do not have problem... I recommend to fill another bug in Oxygen component about this problem...

Gilles

Comment 14 Dotan Cohen 2009-02-05 18:22:34 UTC
> mockup for new sidebar tab title style

Why is the new option under Album View? Is it not valid in other views?
Comment 15 caulier.gilles 2009-02-05 18:32:48 UTC
It's valid everywhere. AlbumView need to be renamed as General i think. i cannot find another place for that... If you have a better idea...

Gilles
Comment 16 Mikolaj Machowski 2009-02-16 17:44:59 UTC
I addressed weak visual feedback about KMultiTabBar with Bug 184395 report but Oxygen developers closed this because this widget isn't under direct control of styling engine.