Bug 156678 - Places panel should highlight an entry only when the main content view shows the exact path of the entry, rather than any subdirectory of it
Summary: Places panel should highlight an entry only when the main content view shows ...
Status: RESOLVED FIXED
Alias: None
Product: dolphin
Classification: Applications
Component: panels: places (show other bugs)
Version: unspecified
Platform: unspecified Linux
: NOR wishlist
Target Milestone: ---
Assignee: David Faure
URL:
Keywords:
: 183378 206018 (view as bug list)
Depends on:
Blocks:
 
Reported: 2008-01-25 23:50 UTC by S. Burmeister
Modified: 2020-11-30 14:29 UTC (History)
10 users (show)

See Also:
Latest Commit:
Version Fixed In: 20.12


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description S. Burmeister 2008-01-25 23:50:00 UTC
Version:            (using KDE 4.0.0)
OS:                Linux

If you open e.g. the "save as" dialogue and it starts in another folder than ~, i.e. the address-bar displays e.g. /home/user/someFolder, the speedbar does show the "home" item selected, which is irritating, because if you click on it, you jump to another folder, i.e. although signaled it was not selected before.

Expected behaviour, do show any item in the speedbar as selected, unless it has exactly the same path as shown in the address-bar.
Comment 1 FiNeX 2008-11-24 17:26:21 UTC
It is selected because you're on a subdirectory of home.
Comment 2 Dario Andres 2009-01-06 13:53:40 UTC
Here using:

Qt: 4.4.3 + qt-copy-patches-889120
KDE: 4.1.87 (KDE 4.1.87 (KDE 4.2 >= 20090101))
kdelibs svn rev. 906436 / kdebase svn rev. 906436
on ArchLinux x86_64 - Kernel 2.6.27.10

I can't reproduce this bug.
In the save dialog if the folder is "/home/user/folder" the speedbar shows ">Home>folder" , and folder is bold, not "Home".

Can anyone else check this ?
Comment 3 FiNeX 2009-01-06 14:30:57 UTC
I agree with Dario. The current behaviour is not the one described on the initial report, and it is the right one. I'm closing as "worksforme".
Comment 4 S. Burmeister 2009-01-06 19:41:29 UTC
The speedbar in open-dialogue is on the left. You might call it Places since KDE4 too. What you are talking about is the breadcrump stuff.
Comment 5 Dario Andres 2009-01-06 20:15:05 UTC
Updating the title...
Comment 6 Allen Winter 2009-01-06 20:36:49 UTC
I encounter something similar:

When I open the save-as dialog, the breadcrumbs shows a path to my home dir.
But the Places shows Root as highlighted.

The breadcrumbs are Root -> misc -> home -> winterz.

My home directory is automounted from a server at /misc/home/winterz.
In /etc/passwd, my home dir is set as /home/winterz.
Therefore, I have a symlink /home/winterz -> /misc/home/winterz

Maybe the Places computation for Home can be made a little smarter somehow?
Comment 7 Dario Andres 2009-09-03 02:03:54 UTC
*** Bug 206018 has been marked as a duplicate of this bug. ***
Comment 8 Maciej Pilichowski 2009-09-03 08:02:04 UTC
a) to fix the bug it is necessary (minimum) to select place in places pane only when place matches current directory

b) I personally wouldn't mind for removing selection entirely, because of its nature -- it is more like an action ("go home") rather than item (it is not like files or directories; you cannot select two of them because of their nature)
Comment 9 Christoph Feck 2009-10-09 16:58:05 UTC
*** Bug 183378 has been marked as a duplicate of this bug. ***
Comment 10 Stephan Sokolow 2009-10-10 01:17:48 UTC
As I mentioned in Bug 183378, especially for people who leave the address bar in non-breadcrumb mode all the time, the current behaviour is confusing.

I mocked up a couple of screenshots for compromises to indicate equality rather than merely descent, but never got a response.

They can be seen at http://bugsfiles.kde.org/attachment.cgi?id=31069

In case it's not clear, I'm proposing that, when you're viewing the directory highlighted in the Places list, an arrow or underline should be added.
Comment 11 Maciej Pilichowski 2009-10-10 07:58:42 UTC
Stephan, with all respect, but your mockups show no progress in solving this issue -- I know why, you had to assume that if something is "by design" then it is logical. However you don't fix errors by covering them, but by removing them.
The path display is a state, but places are not -- with current highlighting they only confuse regular users. From my experience I had to remove this pane, because while saving files were scattered all over the disk ("oh, home is highlighted, good, I save now").
Comment 12 Gary L. Greene, Jr. 2009-10-10 08:12:19 UTC
I think the problem we're having here is that the Places column is really just another way of showing bookmarked locations. Even on Windows where this was prevalent since Windows 95 OSR 2, the item in the Places column would only highlight if you were directly in the folder/place to the right. Thing is, the new version of the file dialog in Windows 7 no longer has this, as the places are now part of the drop down in the dialog much like the Gtk+ one. I do agree with Maciej that the underline in the mock-up doesn't quite match up with my expectations.
Comment 13 Stephan Sokolow 2009-10-10 08:34:46 UTC
I also agree with Maciej and I did initially ask for the old KDE 3.5 "Highlight only when you're actually in the folder in question" behaviour in Bug 183378.

However, aseigo's comment felt, to me, like a fairly firm "No" so I tried to compromise.
Comment 14 Bug Janitor Service 2020-11-17 20:17:49 UTC
A possibly relevant merge request was started @ https://invent.kde.org/system/dolphin/-/merge_requests/117
Comment 15 Elvis Angelaccio 2020-11-23 00:03:26 UTC
Git commit 2cd1c07cad5945a5286914c05987e21b53cc3c7f by Elvis Angelaccio, on behalf of Méven Car.
Committed on 23/11/2020 at 00:02.
Pushed by elvisangelaccio into branch 'release/20.12'.

Places panel: highlight place only when it is displayed
FIXED-IN: 20.12

M  +10   -6    src/panels/places/placespanel.cpp
M  +2    -2    src/panels/places/placespanel.h

https://invent.kde.org/system/dolphin/commit/2cd1c07cad5945a5286914c05987e21b53cc3c7f
Comment 16 Patrick Silva 2020-11-25 15:41:25 UTC
This bug is fixed in Dolphin but it persists with file open/save dialogs.

Operating System: KDE neon Unstable Edition
KDE Plasma Version: 5.20.80
KDE Frameworks Version: 5.77.0
Qt Version: 5.15.1
Comment 17 Nate Graham 2020-11-28 20:07:55 UTC
Yes, the file dialogs will need the same fix implemented there, as they use different code.

Can you file a bug report to track that?
Comment 18 Stephan Sokolow 2020-11-28 20:48:07 UTC
(In reply to Nate Graham from comment #17)
>           What    |Removed                     |Added
>----------------------------------------------------------------------------
>          Component|Places                      |panels: places
>                 CC|                            |kfm-devel@kde.org
>            Version|5.47.0                      |unspecified
>            Product|frameworks-kio              |dolphin
>
> Yes, the file dialogs will need the same fix implemented there, as they use
> different code.
> 
> Can you file a bug report to track that?

That seems a little inconsiderate. Would you be willing to take responsibility for migrating over all the votes and CCs of people like me who only ever cared about the dialogs in the first place?

(I've used PCManFM in my KDE since the 4.x series began and I'm just not a fan of various UI design choices in Dolphin.)
Comment 19 Nate Graham 2020-11-28 22:27:59 UTC
Sure, no problem.
Comment 20 Patrick Silva 2020-11-29 12:48:07 UTC
(In reply to Nate Graham from comment #17)
> Yes, the file dialogs will need the same fix implemented there, as they use
> different code.
> 
> Can you file a bug report to track that?

done, see bug 429806
Comment 21 Bug Janitor Service 2020-11-30 06:43:24 UTC
A possibly relevant merge request was started @ https://invent.kde.org/frameworks/kio/-/merge_requests/234
Comment 22 Méven Car 2020-11-30 14:29:45 UTC
Git commit 7817692f3e02d13d8570027d81369635548398c4 by Méven Car.
Committed on 30/11/2020 at 06:42.
Pushed by meven into branch 'master'.

Places view: highlight place only when it is displayed
Related: bug 429806
FIXED-IN: 5.77

M  +6    -1    src/filewidgets/kfileplacesview.cpp

https://invent.kde.org/frameworks/kio/commit/7817692f3e02d13d8570027d81369635548398c4