Bug 183378 - Places view in KFileDialog highlights closest match, rather than only highlighting on exact matches
Summary: Places view in KFileDialog highlights closest match, rather than only highlig...
Status: RESOLVED DUPLICATE of bug 156678
Alias: None
Product: kfile
Classification: Applications
Component: kfileplacesview (show other bugs)
Version: unspecified
Platform: unspecified Linux
: NOR normal
Target Milestone: ---
Assignee: kdelibs bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-02-06 02:10 UTC by Stephan Sokolow
Modified: 2009-10-09 16:58 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Screenshot showing the problem (57.85 KB, image/png)
2009-02-06 02:12 UTC, Stephan Sokolow
Details
Mockup for proposed compromise (12.54 KB, image/png)
2009-02-07 08:28 UTC, Stephan Sokolow
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Stephan Sokolow 2009-02-06 02:10:28 UTC
Version:           unknown (using 4.2.00 (KDE 4.2.0), Gentoo)
Compiler:          x86_64-pc-linux-gnu-gcc
OS:                Linux (x86_64) release 2.6.25-gentoo-r7-20080501

If none of the places shown in the Places view in KFileDialog matches the user's current location, then the closest ancestor is highlighted. While one could argue that this is the best approach in Dolphin, it is at odds with the behaviour of the KDE 3.5 and GTK+ 2.x file dialogs and I find it highly disorienting.

Specifically, I habitually take a highlight in the places list (KDE or GTK) to mean that I'm directly in the highlighted folder. As such, whenever I see something like the provided screenshot, I pause for up to 5 seconds while I try to figure out why there are no folders in my home directory and whether it's a new bug in KDE 4 that I should report... then I realize that I'm actually in my Desktop folder and it makes sense until the next time I want to save a file after having spent a few hours AFK.
Comment 1 Stephan Sokolow 2009-02-06 02:12:30 UTC
Created attachment 31011 [details]
Screenshot showing the problem

Correction: I don't have to go AFK for it to regain its effectiveness. I got stuck for roughly 2 seconds while trying to select this file because habit says that clicking on an already-selected places entry will have no effect, but I wanted to get to Home so I could go to the desktop.
Comment 2 Aaron J. Seigo 2009-02-06 12:00:21 UTC
this is intentional for a few reasons, consistency being one of them, and is much clearer when using the breadcrumb navigation rather than the editable url navigation.
Comment 3 Stephan Sokolow 2009-02-06 15:14:07 UTC
My point is that the current behaviour is inconsistent with both GTK+ and KDE 3, Hence the disorientation I mentioned.

Would it preserve consistency acceptably if there was a single toggle (even just one that's only available via raw rc file editing) which changed the behaviour everywhere a places view is used?

If it would but you don't feel it's worth the effort, would you accept a patch to provide such a hidden toggle? (I don't know how soon I'd be able to write one, but it should be simple enough for me to pull off if I do manage to make time.)

If not, what about introducing some kind of obvious visual distinction in the places entries between "active, current folder" and "active, ancestor of the current folder".

...or, if I really do have to just close the places sidebar and use the bookmarks menu, could it at least be altered so bookmarks can be visiblity-limited to a specific application the way places are? (The lack of that feature is by far my biggest complaint about the GTK+ 2.x and vanilla Qt 4.x file pickers)
Comment 4 Stephan Sokolow 2009-02-07 08:26:37 UTC
Now that I'm not half-way through an all-nighter, I'm a little more receptive to the new design, but I still think there should be some sort of visual distinction between directly viewing a place and having it as the ancestor of your current location... if nothing else, to bring some consistency with every other Save/Load bookmarking implementation that it may coexist with.

The KDE 3.x, vanilla Qt 4.x, and GTK+ 2.x Save/Load dialogs all encourage the assumption that highlighted means current location.
Comment 5 Stephan Sokolow 2009-02-07 08:28:08 UTC
Created attachment 31069 [details]
Mockup for proposed compromise

Would one of the two appearances for "current location" in this mockup be an acceptable compromise?
Comment 6 Christoph Feck 2009-10-09 16:58:05 UTC

*** This bug has been marked as a duplicate of bug 156678 ***