Bug 454937

Summary: On Wayland, launch feedback always triggers for global-shortcut-launched apps that have `StartupNotify=false` in their desktop file
Product: [Frameworks and Libraries] frameworks-kglobalaccel Reporter: Nate Graham <nate>
Component: generalAssignee: kdelibs bugs <kdelibs-bugs>
Status: RESOLVED FIXED    
Severity: normal CC: aleixpol, bugseforuns, crazycableguy, indecisiveautomator, postix, putr4.s, xglooom, yaomtc
Priority: VHI Keywords: regression
Version: unspecified   
Target Milestone: ---   
Platform: Other   
OS: Linux   
See Also: https://bugs.kde.org/show_bug.cgi?id=451160
https://bugs.kde.org/show_bug.cgi?id=455126
Latest Commit: Version Fixed In: 5.25.3
Sentry Crash Report:

Description Nate Graham 2022-06-06 17:30:01 UTC
See for example Spectacle. Hit the PrintScreen key to launch it and you'll see the launch feedback animation despite having `StartupNotify=false` in its desktop file.
Comment 1 Patrick Silva 2022-06-17 13:49:49 UTC
*** Bug 455455 has been marked as a duplicate of this bug. ***
Comment 2 Patrick Silva 2022-06-20 10:02:13 UTC
*** Bug 455638 has been marked as a duplicate of this bug. ***
Comment 3 Nate Graham 2022-06-24 13:50:45 UTC
*** Bug 455850 has been marked as a duplicate of this bug. ***
Comment 4 Nate Graham 2022-06-24 13:51:46 UTC
Possibly related: Bug 455126.
Comment 5 Nate Graham 2022-06-29 16:13:43 UTC
*** Bug 456124 has been marked as a duplicate of this bug. ***
Comment 6 Bug Janitor Service 2022-06-29 19:41:11 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/kwin/-/merge_requests/2594
Comment 7 Aleix Pol 2022-07-04 16:47:19 UTC
Git commit 78d80123f1d2efbfa00733390430ce381db9c245 by Aleix Pol.
Committed on 04/07/2022 at 15:44.
Pushed by apol into branch 'master'.

xdgactivation: Properly prevent disabled activation notifications

The logic when checking the settings was wrong and it would always
notify unless both keys were actually disabled.

M  +4    -2    src/xdgactivationv1.cpp

https://invent.kde.org/plasma/kwin/commit/78d80123f1d2efbfa00733390430ce381db9c245
Comment 8 Aleix Pol 2022-07-04 16:48:40 UTC
Git commit 155b3cd4907e619e2ae0ec4feca873a213f839d0 by Aleix Pol Gonzalez, on behalf of Aleix Pol.
Committed on 04/07/2022 at 16:48.
Pushed by apol into branch 'Plasma/5.25'.

xdgactivation: Properly prevent disabled activation notifications

The logic when checking the settings was wrong and it would always
notify unless both keys were actually disabled.


(cherry picked from commit 78d80123f1d2efbfa00733390430ce381db9c245)

M  +4    -2    src/xdgactivationv1.cpp

https://invent.kde.org/plasma/kwin/commit/155b3cd4907e619e2ae0ec4feca873a213f839d0