Summary: | System Settings crashes on Wayland in KScreen::Config::clone() when display configuration changes | ||
---|---|---|---|
Product: | [Applications] systemsettings | Reporter: | Patrick Silva <bugseforuns> |
Component: | kcm_kscreen | Assignee: | kscreen-bugs-null <kscreen-bugs-null> |
Status: | RESOLVED FIXED | ||
Severity: | crash | CC: | bednarczyk.pawel, bruno, bugreports.nmhj2, jimtahu, meven29, nate, nicolas.fella, plasma-bugs, postix, rustico.bakko, stephen.wetzel, sven |
Priority: | HI | Keywords: | drkonqi, wayland-only |
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Neon | ||
OS: | Linux | ||
See Also: | https://bugs.kde.org/show_bug.cgi?id=461581 | ||
Latest Commit: | https://invent.kde.org/plasma/kscreen/commit/41770e254a067ae3f9a7865fa6741b07009a73f5 | Version Fixed In: | 5.26 |
Sentry Crash Report: | |||
Attachments: | New crash information added by DrKonqi |
Description
Patrick Silva
2021-12-18 19:09:58 UTC
Git commit 41770e254a067ae3f9a7865fa6741b07009a73f5 by Nate Graham, on behalf of Méven Car. Committed on 30/12/2021 at 18:15. Pushed by ngraham into branch 'master'. KCM: better handle revert timer and buttons FIXED-IN: 5.23.5 The issue was that the `revertSettings` method was called when the timer timed out, the settings were reverted, the confirmMsg overlay closed and called a second time `revertSettings` when the kcm backend has not been reloaded yet. This makes sure this won't happen, as either the timer of the revert button will revert the Settings but not simply closing `confirmMsg. This makes the code simpler by removing book keeping but instead using only the events. M +5 -20 kcm/package/contents/ui/main.qml https://invent.kde.org/plasma/kscreen/commit/41770e254a067ae3f9a7865fa6741b07009a73f5 *** Bug 449869 has been marked as a duplicate of this bug. *** *** Bug 449953 has been marked as a duplicate of this bug. *** Apparently not fixed; we are still getting crash reports with the same backtrace from 5.24. Apparently the crash in KScreen::Config::clone() is unrelated to the presence or absence of the reversion dialog. *** Bug 449318 has been marked as a duplicate of this bug. *** Created attachment 150605 [details]
New crash information added by DrKonqi
systemsettings (5.25.2) using Qt 5.15.5
Maybe these additions help:
After the crash the timer does not come back, no matter how I change my screen resolution or which screen (one panel, two monitors)
=> That said, I had DrKonqi open while I tried to reproduce the crash.
-- Backtrace (Reduced):
#6 QSharedPointer<KScreen::Screen>::data (this=<optimized out>) at /usr/include/qt5/QtCore/qsharedpointer_impl.h:301
#7 QSharedPointer<KScreen::Screen>::operator-> (this=<optimized out>) at /usr/include/qt5/QtCore/qsharedpointer_impl.h:307
#8 KScreen::Config::clone (this=0x0) at /data/portage/portage/kde-plasma/libkscreen-5.25.2/work/libkscreen-5.25.2/src/config.cpp:205
#9 0x00007f05bce0ea1f in ConfigHandler::updateInitialData (this=0x557a6d64e910) at /usr/include/qt5/QtCore/qsharedpointer_impl.h:301
#10 0x00007f05bce1100f in operator() (__closure=0x557a6f48c2a0) at /data/portage/portage/kde-plasma/kscreen-5.25.2/work/kscreen-5.25.2/kcm/kcm.cpp:180
*** Bug 457943 has been marked as a duplicate of this bug. *** *** Bug 459848 has been marked as a duplicate of this bug. *** FWIW, I cannot reproduce this on Wayland plasma 5.26 beta using OPs repro steps. Patrick, can you reproduce it on Neon unstable? (In reply to Nate Graham from comment #12) > Patrick, can you reproduce it on Neon unstable? No. Fantastic. |