| Summary: | Favorites are scrollable even though there are only four item rows | ||
|---|---|---|---|
| Product: | [Plasma] plasmashell | Reporter: | dagobertram |
| Component: | Application Launcher (Kickoff) widget | Assignee: | David Edmundson <kde> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | mikel5764, plasma-bugs |
| Priority: | NOR | ||
| Version: | 5.22.2 | ||
| Target Milestone: | 1.0 | ||
| Platform: | Neon | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/plasma/plasma-desktop/commit/9d9c4f169ed424e976636a6d5fa23c7a1e40576b | Version Fixed In: | 5.23 |
| Sentry Crash Report: | |||
| Attachments: | scroll bar probably unnecessary | ||
Git commit 9d9c4f169ed424e976636a6d5fa23c7a1e40576b by Noah Davis. Committed on 19/07/2021 at 06:47. Pushed by ndavis into branch 'master'. Kickoff: Refactor and tweak design Changes: - Now uses implicit content size to set the size of the plasmoid, which fixes translated string elision issues. - Much simpler code. This is a red patch. - Reduced RAM usage. Pages that are not in use are unloaded. The models aren't unloaded, so it shouldn't negatively affect performance in other ways. - Vertical movement and opacity animation when switching from normal page to search view. - Single horizontal movement and opacity animation when switching from applications page to places page. - Opacity animation when switching from favorites grid to apps list. - KickoffListView and KickoffGridView now support PageUp, PageDown, Home, End, Ctrl+Home and Ctrl+End shortcuts like lists and grids do on the web. See https://www.w3.org/TR/wai-aria-practices-1.2/#grid - KickoffListView/KickoffGridView keyboard navigation disables hovering to change current item for 100ms. It's meant to filter out accidental mouse movement while using the arrow keys to navigate. - Add Ctrl+F shortcut to focus search bar - Focus the next item down when pressing down while the search bar is focused instead of focusing the 1st item. The old kickoff did this and made it faster to select and activate items. - Hovering near the bottom/top of a view no longer rapidly selects a series of new items lower down/higher up that are not yet visible. - Single letter section headers are now horizontally center aligned with icons. - Scroll to switch tabs. - Added pin button to keep the launcher open. - Show tooltips for list/grid items that have elided text. - Padding and spacing are more uniform. - List items have better vertical pixel alignment. - Fixed pixel alignment of arrows in sidebar category items - Sidebar list items line up with main content area list items and section headers - Labels in grid items now have consistent vertical positions. - Fixed error in tools.js with favoriteModel.enabled Related: bug 433103, bug 432270, bug 434736, bug 431913, bug 433146, bug 433241, bug 408313 FIXED-IN: 5.23 M +7 -3 applets/kickoff/package/contents/config/main.xml M +55 -97 applets/kickoff/package/contents/ui/ActionMenu.qml D +0 -142 applets/kickoff/package/contents/ui/ApplicationsGroupView.qml A +140 -0 applets/kickoff/package/contents/ui/ApplicationsPage.qml [License: LGPL(v2.0+)] D +0 -358 applets/kickoff/package/contents/ui/ApplicationsView.qml A +88 -0 applets/kickoff/package/contents/ui/BasePage.qml [License: GPL (v2+)] D +0 -55 applets/kickoff/package/contents/ui/BaseView.qml D +0 -70 applets/kickoff/package/contents/ui/Breadcrumb.qml D +0 -41 applets/kickoff/package/contents/ui/ComputerView.qml M +31 -11 applets/kickoff/package/contents/ui/ConfigGeneral.qml A +30 -0 applets/kickoff/package/contents/ui/EmptyPage.qml [License: LGPL(v2.0+)] D +0 -129 applets/kickoff/package/contents/ui/FavoritesGridView.qml D +0 -133 applets/kickoff/package/contents/ui/FavoritesView.qml A +193 -0 applets/kickoff/package/contents/ui/Footer.qml [License: GPL (v2+)] D +0 -20 applets/kickoff/package/contents/ui/FrequentlyUsedView.qml M +119 -736 applets/kickoff/package/contents/ui/FullRepresentation.qml M +186 -146 applets/kickoff/package/contents/ui/Header.qml A +59 -0 applets/kickoff/package/contents/ui/HorizontalStackView.qml [License: LGPL(v2.0+)] M +53 -27 applets/kickoff/package/contents/ui/Kickoff.qml D +0 -93 applets/kickoff/package/contents/ui/KickoffGridItem.qml M +200 -288 applets/kickoff/package/contents/ui/KickoffGridView.qml D +0 -175 applets/kickoff/package/contents/ui/KickoffItem.qml A +227 -0 applets/kickoff/package/contents/ui/KickoffItemDelegate.qml [License: GPL (v2+)] M +211 -288 applets/kickoff/package/contents/ui/KickoffListView.qml A +137 -0 applets/kickoff/package/contents/ui/KickoffSingleton.qml [License: LGPL(v2.0+)] M +43 -104 applets/kickoff/package/contents/ui/LeaveButtons.qml A +53 -0 applets/kickoff/package/contents/ui/NormalPage.qml [License: LGPL(v2.0+)] A +76 -0 applets/kickoff/package/contents/ui/PlacesPage.qml [License: LGPL(v2.0+)] D +0 -22 applets/kickoff/package/contents/ui/PlacesView.qml D +0 -18 applets/kickoff/package/contents/ui/RecentlyUsedView.qml D +0 -87 applets/kickoff/package/contents/ui/SearchView.qml D +0 -42 applets/kickoff/package/contents/ui/SectionDelegate.qml A +61 -0 applets/kickoff/package/contents/ui/VerticalStackView.qml [License: LGPL(v2.0+)] M +1 -1 applets/kickoff/package/contents/ui/code/tools.js A +2 -0 applets/kickoff/package/contents/ui/qmldir https://invent.kde.org/plasma/plasma-desktop/commit/9d9c4f169ed424e976636a6d5fa23c7a1e40576b |
Created attachment 139653 [details] scroll bar probably unnecessary SUMMARY I don't know if this is because of two times scaling on a 4k screen but with four rows of favorites I am getting a scroll bar in kickoff which seems odd. SOFTWARE/OS VERSIONS Operating System: KDE neon 5.22 KDE Plasma Version: 5.22.2 KDE Frameworks Version: 5.83.0 Qt Version: 5.15.3 Kernel Version: 5.8.0-59-generic (64-bit) Graphics Platform: X11