Summary: | FormLayout text gets elided too early when using a fractional font size | ||
---|---|---|---|
Product: | [Frameworks and Libraries] frameworks-kirigami | Reporter: | Usarin Heininga <usarinheininga> |
Component: | general | Assignee: | Marco Martin <notmart> |
Status: | CLOSED UPSTREAM | ||
Severity: | normal | CC: | albertoshea2, ianp, kde-bugs, kitt997, lv215bd5, nate, n_s_mendoza, pieterkristensen, plasma-bugs, rulatir, sadiyumusak, safa1996alfulaij |
Priority: | NOR | ||
Version: | 5.78.0 | ||
Target Milestone: | 1.0 | ||
Platform: | Kubuntu | ||
OS: | Linux | ||
URL: | https://bugreports.qt.io/browse/QTBUG-92006 | ||
Latest Commit: | Version Fixed In: | ||
Attachments: | Screenshot |
Can confirm. Seems like an issue with the Kirigami FormLayout component. I have just investigated this bug, but unfortunately it's a QT bug. I reported the bug at QT https://bugreports.qt.io/browse/QTBUG-92006. So this means that this won't get fixed very soon. Not until QT6 i guess. I have been able to fix it by hacking some of the default plasma controls. But this doesn't work everywhere. The latte-dock configuration widgets use plain QtQuick 1 controls for example and those will not be affected by anything that KDE does, Right? Darn. Thanks for the investigation! *** Bug 437762 has been marked as a duplicate of this bug. *** *** Bug 439271 has been marked as a duplicate of this bug. *** *** Bug 441177 has been marked as a duplicate of this bug. *** *** Bug 414418 has been marked as a duplicate of this bug. *** *** Bug 437077 has been marked as a duplicate of this bug. *** *** Bug 442343 has been marked as a duplicate of this bug. *** Th.. Qt tea... shou... definit... alloc... mo... resou... to fixi... thi... bu... . *** Bug 443950 has been marked as a duplicate of this bug. *** *** Bug 444181 has been marked as a duplicate of this bug. *** *** Bug 449201 has been marked as a duplicate of this bug. *** I believe that once it has been established that "upstream" has a bug that won't be fixed in foreseeable future, but "application" and its users continually suffer from the bug, then "application" should try to come up with a workaround instead of telling users that they will have to wait indefinitely for the bug to be fixed upstream. KDE is the "application" here. Please don't re-open bug marked RESOLVED UPSTREAM reports because you want a local workaround. In this case I don't believe a local workaround is easily possible. We could prevent the ability to set fractional font sizes i the fong dialog, but I don't think that would make people very happy. :) *** Bug 453303 has been marked as a duplicate of this bug. *** Bug 453303, now marked as duplicate of this one, suggests "adding a warning to the Font settings". Closing bug 432372 did not save me wasting time on reporting this defect, nor others managing the duplicate bug. Either add a permanent label next to the settings or add a reactive pop up when a half point size is used. Sure, that seems reasonable. I'll look into it. Git commit 9d0a71d7e514cb4a11649464e8e867b2ce39e106 by Nate Graham. Committed on 02/05/2022 at 20:42. Pushed by ngraham into branch 'master'. kcms/fonts: show warning when user tries to set a non-integer font size It triggers https://bugreports.qt.io/browse/QTBUG-92006, and we need to warn users about that. M +23 -0 kcms/fonts/package/contents/ui/main.qml https://invent.kde.org/plasma/plasma-workspace/commit/9d0a71d7e514cb4a11649464e8e867b2ce39e106 *** Bug 453419 has been marked as a duplicate of this bug. *** This bug has been fixed in QT 6.2.5 according to https://bugreports.qt.io/browse/QTBUG-92006 Is it possible to include it in the KDE QT patch collection? Could be feasible. Feel free to send a merge request to do it. See https://community.kde.org/Qt5PatchCollection#How_do_I_get_a_patch_merged.3F Haha, not the answer I was hoping for. But I'll give it a try this weekend, I don't promise anything. I'm short on time currently and not familiar with the QT codebase. Regards, Usarin Heininga |
Created attachment 135347 [details] Screenshot SUMMARY STEPS TO REPRODUCE 1. open the font settings page. 2. change the font size to any size with a half, 10.5 or 11.5. OBSERVED RESULT All QML based widgets don't reserve enough space for the text. Apparently the internal algorithm works with a rounded down value to resize the widgets. EXPECTED RESULT All qml based widgets should reserve enough space for the text. SOFTWARE/OS VERSIONS Windows: macOS: Linux/KDE Plasma: Ubuntu Hirsute (available in About System) KDE Plasma Version: 5.20.90 KDE Frameworks Version: 5.78 Qt Version: 5.15 ADDITIONAL INFORMATION This is also the case in Ubuntu Focal and Groovy.