| Summary: | The two finger touchscreen gesture to zoom in out (pinch in/pinch out) results in the document to scroll by a large amount. | ||
|---|---|---|---|
| Product: | [Applications] okular | Reporter: | spittingverse <spittingverse> |
| Component: | general | Assignee: | Okular developers <okular-devel> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | 842mono, apandada1, dzackgarza, eliottt-m, jan.claussen10, jk, micraft.b, nate, oliver.sander, stefan.bruens |
| Priority: | NOR | Keywords: | usability |
| Version: | 1.10.1 | ||
| Target Milestone: | --- | ||
| Platform: | Manjaro | ||
| OS: | Linux | ||
| See Also: | https://bugs.kde.org/show_bug.cgi?id=159408 | ||
| Latest Commit: | https://invent.kde.org/graphics/okular/-/commit/db68662372984e643184a6d1f8eb63e519e2646d | Version Fixed In: | 23.08 |
| Sentry Crash Report: | |||
| Attachments: |
Video displaying how the two finger pinch scrolls and zooms, rather than just zoom.
Confirmed zooming issue |
||
The problem is that the document does not pan when zooming. The code that handles mouse wheel zoom should be used for the pinch zoom too. The viewport position must be updated while zooming to maintain relative position of the mouse cursor (pinch zoom center) and the document. Should be fixed by https://invent.kde.org/graphics/okular/-/merge_requests/134 I have the exact same issue (on KDE Manjaro, Okular 1.10.1). Same issue here, on Arch Linux, and the linked merge request seems to still be open. I am currently running version 1.10.70 under Xorg, and this seems to be a new issue that was introduced sometime earlier this year for me. Is there any way to work around this issue while the merge is under review? Maybe rolling back to some previous version in the meantime? Created attachment 130053 [details]
Confirmed zooming issue
*** Bug 426679 has been marked as a duplicate of this bug. *** I can confirm this still is the case in 20.12.1 on X11: Okular always zooms as if both fingers were in the upper left corner on the first page of the document, no the page you are on. This means that zooming works mostly fine on the first page, but if you want to zoom to 2x on page 100 you will find yourself on page 50. Note that this only happens with touch, middle mouse or crtl+scroll don't do that. *** Bug 390707 has been marked as a duplicate of this bug. *** *** Bug 429197 has been marked as a duplicate of this bug. *** Actually it's the opposite: this bug and its dupes are all dupes of 159408. I've tested the MR and it fixes them all. *** This bug has been marked as a duplicate of bug 159408 *** Git commit db68662372984e643184a6d1f8eb63e519e2646d by Nicolas Fella. Committed on 08/07/2023 at 12:04. Pushed by nicolasfella into branch 'master'. Avoid accidental scrolling when performing pinch gesture When starting a pinch the user first touches with one finger. That causes the QScroller to enter the pressed state. Then when the second finger touches and moves this causes the QScroller to interpret it as a scroll. This causes the view position of the document to move To avoid this send InputRelease to the scroller when a pinch starts to make sure it is no longer in pressed state. Also don't send any input to the scroller while the pinch is ongoing to avoid it entering the pressed state again. M +19 -4 part/pageview.cpp https://invent.kde.org/graphics/okular/-/commit/db68662372984e643184a6d1f8eb63e519e2646d *** Bug 470289 has been marked as a duplicate of this bug. *** |
Created attachment 128596 [details] Video displaying how the two finger pinch scrolls and zooms, rather than just zoom. SUMMARY The two finger touchscreen gesture to zoom in out (pinch in/pinch out) results in the document to scroll by a large amount. STEPS TO REPRODUCE 1. Open document (tested with pdf and epub) 2. pinch in or pinch out with touchscreen OBSERVED RESULT The document scrolls by a lot EXPECTED RESULT Document should not scroll, and the behavior should mimic the ctrl + touchpad scroll, which works fine. SOFTWARE/OS VERSIONS Windows: macOS: Linux/KDE Plasma: manjaro? (available in About System) KDE Plasma Version: 5.18.5 KDE Frameworks Version: 5.69.0 Qt Version: 5.14.2 ADDITIONAL INFORMATION