Bug 390707 - Two-finger touchscreen zoom gesture should respect finger position
Summary: Two-finger touchscreen zoom gesture should respect finger position
Status: RESOLVED FIXED
Alias: None
Product: okular
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR wishlist
Target Milestone: ---
Assignee: Okular developers
URL:
Keywords: usability
Depends on:
Blocks:
 
Reported: 2018-02-19 01:36 UTC by Stefan Brüns
Modified: 2023-08-11 16:47 UTC (History)
7 users (show)

See Also:
Latest Commit: https://invent.kde.org/graphics/okular/-/commit/3306e4f35d212f9eb64d28108b2b684012c9ce4e
Version Fixed In: 23.12
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Stefan Brüns 2018-02-19 01:36:44 UTC 
The two-finger zoom seems to always zoom to the center position.

Expected behaviour:
If the user marks a rectangle with the fingers, e.g. in the top left corner of the view, and then pulls the rectangle to the size of the screen, the former top left corner should be shown full screen.

The same should probably apply to zooming with Ctrl + Mouse Wheel, i.e. zoom to mouse position. This is how zooming is handled in e.g. inkscape and any other document centric application I am aware of.
Comment 1 Oliver Sander 2018-02-19 21:24:48 UTC 
That needs somebody to implement it.  The current code for the gesture zooming is very simple and short.  It is in the method PageView::gestureEvent, if you want to have a look.
Comment 2 Laura David Hurka 2020-11-06 17:42:03 UTC 
*** Bug 159408 has been marked as a duplicate of this bug. ***
Comment 3 Nate Graham 2020-11-17 16:48:43 UTC 
*** Bug 429197 has been marked as a duplicate of this bug. ***
Comment 4 personalizedrefrigerator 2021-01-18 22:49:22 UTC 
This might be a duplicate of https://bugs.kde.org/show_bug.cgi?id=421755. This bug has a merge request attached to it.
Comment 5 Nate Graham 2021-01-19 15:16:39 UTC 
Yeah. Forward-duping since that bug already has a submitted merge request that will fix it.

*** This bug has been marked as a duplicate of bug 421755 ***
Comment 6 Nate Graham 2021-01-19 15:55:18 UTC 

*** This bug has been marked as a duplicate of bug 159408 ***
Comment 7 Nate Graham 2022-01-14 21:31:53 UTC 
*** Bug 448478 has been marked as a duplicate of this bug. ***
Comment 8 Nicolas Fella 2023-08-02 14:49:47 UTC 
*** Bug 472924 has been marked as a duplicate of this bug. ***
Comment 9 Nicolas Fella 2023-08-11 11:35:08 UTC 
Git commit 3306e4f35d212f9eb64d28108b2b684012c9ce4e by Nicolas Fella.
Committed on 11/08/2023 at 13:27.
Pushed by nicolasfella into branch 'master'.

Hold zoom center below fingers on pinch zoom

Which feels more natural than always zooming towards the center of the window.

Co-authored-by: Steffen Hartleib <sh033@gmx.de>

Co-authored-by: Oliver Sander <oliver.sander@tu-dresden.de>

M  +101  -11   part/pageview.cpp
M  +6    -0    part/pageview.h

https://invent.kde.org/graphics/okular/-/commit/3306e4f35d212f9eb64d28108b2b684012c9ce4e