| Summary: | Dark panels have light-colored visual glitches in their rounded corners | ||
|---|---|---|---|
| Product: | [Plasma] plasmashell | Reporter: | veggero <niccolo.venerandi> |
| Component: | Panel | Assignee: | visual-design |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | dev.bacteriostat, developer.gl513, harsimran, martial, me, nate, niccolo.venerandi, plasma-bugs, ray, rikmills, vasua.ukraine, zawertun |
| Priority: | HI | Keywords: | regression |
| Version: | 5.18.0 | ||
| Target Milestone: | 1.0 | ||
| Platform: | Other | ||
| OS: | Linux | ||
| See Also: | https://bugs.kde.org/show_bug.cgi?id=438644 | ||
| Latest Commit: | https://invent.kde.org/frameworks/plasma-framework/commit/575d0de125cd9b6d60ca5a51ebc32c9bd0dd05ea | Version Fixed In: | 5.101 |
| Sentry Crash Report: | |||
| Attachments: | White corners | ||
|
Description
veggero
2020-02-12 19:15:59 UTC
author Niccol Venerandi <niccolo@venerandi.com> 2020-02-12 20:12:05 +0100 committer Niccolò Venerandi <niccolo@venerandi.com> 2020-02-13 18:18:09 +0100 commit 1ed47e7c4188ed0f047dda40093ea0213ae4a433 (patch) tree 605f782003b23344c59284e6ce2e75a476770ada parent 1dc36bc2cee489e621a52fb4456ff28cf6a64685 (diff) Remove hardcoded colorsHEADmaster Summary: Fixes https://www.reddit.com/r/kde/comments/f2mxd3/517_seeing_weird_white_corners_on_my_autohiding/ BUG:417511 Reviewers: ndavis Reviewed By: ndavis Subscribers: kde-frameworks-devel Tags: #frameworks Differential Revision: https://phabricator.kde.org/D27354 Created attachment 149042 [details]
White corners
Same issue in 5.24.4
Oops meant to say frameworks 5.92.0 I suppose Oops meant to say frameworks 5.92.0 I suppose System Info Operating System: Kubuntu 22.04 KDE Plasma Version: 5.24.4 KDE Frameworks Version: 5.92.0 Qt Version: 5.15.3 Kernel Version: 5.15.0-30-generic (64-bit) Graphics Platform: X11 Processors: 8 × Intel® Core™ i7-8550U CPU @ 1.80GHz Memory: 7.7 GiB of RAM Graphics Processor: Mesa Intel® UHD Graphics 620 It's actually Bug 438644 now; it came back. :( *** This bug has been marked as a duplicate of bug 438644 *** Not fixed by the fix for Bug 438644, unfortunately. Re-opening. *** Bug 454467 has been marked as a duplicate of this bug. *** *** Bug 459704 has been marked as a duplicate of this bug. *** *** Bug 455749 has been marked as a duplicate of this bug. *** *** Bug 454794 has been marked as a duplicate of this bug. *** A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/2215 Git commit 999c3a0feb97874a41faa286977e34398216e80e by Nate Graham, on behalf of Niccolò Venerandi. Committed on 14/10/2022 at 15:55. Pushed by ngraham into branch 'master'. Make the panel's corner mask 1px smaller to avoid artifacts at the corners This effectively applies the fix in https://invent.kde.org/frameworks/plasma-framework/-/merge_requests/377 to panels as well. FIXED-IN: 5.26.1 M +10 -3 shell/panelview.cpp https://invent.kde.org/plasma/plasma-workspace/commit/999c3a0feb97874a41faa286977e34398216e80e Git commit b68a93efee8a1b1de86f3689c0db685f6a74adf9 by Nate Graham, on behalf of Niccolò Venerandi. Committed on 14/10/2022 at 15:56. Pushed by ngraham into branch 'Plasma/5.26'. Make the panel's corner mask 1px smaller to avoid artifacts at the corners This effectively applies the fix in https://invent.kde.org/frameworks/plasma-framework/-/merge_requests/377 to panels as well. FIXED-IN: 5.26.1 (cherry picked from commit 999c3a0feb97874a41faa286977e34398216e80e) M +10 -3 shell/panelview.cpp https://invent.kde.org/plasma/plasma-workspace/commit/b68a93efee8a1b1de86f3689c0db685f6a74adf9 *** Bug 460781 has been marked as a duplicate of this bug. *** A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/2358 Git commit 631841e00e204ba37da2367fe6b221ba6ab795b4 by Nate Graham, on behalf of Niccolò Venerandi. Committed on 24/11/2022 at 17:00. Pushed by ngraham into branch 'Plasma/5.26'. Panel: Revert making the mask smaller by 1px This fixes 460896, but breaks the fix for 417511. It will be re-fixed again by https://invent.kde.org/frameworks/plasma-framework/-/merge_requests/644, without any negative side effects. Related: bug 460896 FIXED-IN: 5.26.4 (cherry picked from commit 1abe11473bcaa282ad1b5087b8dbaab2329530de) M +2 -10 shell/panelview.cpp https://invent.kde.org/plasma/plasma-workspace/commit/631841e00e204ba37da2367fe6b221ba6ab795b4 We had to revert the fix; re-opening this. It will be re-fixed with https://invent.kde.org/frameworks/plasma-framework/-/merge_requests/644 in Frameworks 5.101. Git commit 575d0de125cd9b6d60ca5a51ebc32c9bd0dd05ea by Nate Graham, on behalf of Niccolò Venerandi. Committed on 25/11/2022 at 16:39. Pushed by ngraham into branch 'master'. Rework Plasma theme mask corners and outlines This patch reverts Marco's idea of making the mask of dialogs smaller by 1px (and https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/2276 reverts my patch doing the same for the panel); instead, this MR reduces the mask by 1px, but only for the corner elements. The issue with reducing the whole mask by 1px is that you'll get a dark outline in Breeze Dark (both on the panel and the dialogs) *and* you'll be able to see the wallpaper through the panel/dialog in its outermost pixel. This patch still isn't perfect. With some combination of colorscheme and wallpaper, you might still notice some slight darkening going on in the corners. This happened before this MR too, but at least now it happens *only* in the corners. It's much less noticeable; especially since most people seem to notice it only for the panel, which in most cases does not have any rounded corners (but it does have sides, so this MR - which makes the bug only appear in corners - is a great step forward). FIXED-IN: 5.101 M +643 -111 src/desktoptheme/breeze/dialogs/background.svg M +622 -120 src/desktoptheme/breeze/solid/dialogs/background.svg M +656 -121 src/desktoptheme/breeze/solid/widgets/background.svg M +663 -125 src/desktoptheme/breeze/solid/widgets/panel-background.svg M +625 -128 src/desktoptheme/breeze/solid/widgets/tooltip.svg M +649 -120 src/desktoptheme/breeze/translucent/dialogs/background.svg M +687 -125 src/desktoptheme/breeze/translucent/widgets/panel-background.svg M +649 -120 src/desktoptheme/breeze/translucent/widgets/tooltip.svg M +687 -125 src/desktoptheme/breeze/widgets/panel-background.svg M +261 -59 src/desktoptheme/breeze/widgets/plasmoidheading.svg M +649 -120 src/desktoptheme/breeze/widgets/tooltip.svg M +1 -5 src/plasmaquick/dialog.cpp https://invent.kde.org/frameworks/plasma-framework/commit/575d0de125cd9b6d60ca5a51ebc32c9bd0dd05ea |