Bug 416358

Summary: kcm_fonts: Cannot apply changes (button remains inactive)
Product: [Applications] systemsettings Reporter: Andreas Sturmlechner <asturm>
Component: kcm_fontsAssignee: Plasma Bugs List <plasma-bugs>
Status: RESOLVED FIXED    
Severity: grave CC: aliceaccounts, alien, anonkun, awilfox, benjamin.port, bizyaev, brucewwayne1234, bugseforuns, demm, ferenosdev, gisk+kdebugs, givbra, htenberge, jdgmpviqb, jr, kassin.dornelles, kde, lanstar454, linux, luanrodrigues51, matejm98mthw, me, meven29, nate, peeledbanana, popov895, postix, rikmills, rockprinzess, rstrube, talentlcy, Tyler, unassigned-bugs, yurchor, zawertun
Priority: VHI    
Version: 5.18.0   
Target Milestone: ---   
Platform: Other   
OS: Linux   
See Also: https://bugs.kde.org/show_bug.cgi?id=417587
Latest Commit: Version Fixed In: 5.18.1
Sentry Crash Report:

Description Andreas Sturmlechner 2020-01-16 23:21:19 UTC
After the update to 5.17.90, making changes in the Fonts KCM does not activate the Apply button. Running the KCM via kcmshell5 shows additional OK/Cancel buttons and e.g. checking 'Force font DPI' will visibly flash the OK button while Apply remains inactive, however using the OK button has no effect. After restarting the KCM, old values are visible again.

Since I wanted to test Qt 5.14.0 scaling after applying b31852c4ca from QTBUG-80967, I removed ~/.config/kcmfonts (from tty, in between two sessions) which certainly worked to reset the values. However the above behavior remained. For some reason though, the new file created by kcm_fonts had set `forceFontDPI=144` which is weird.

SOFTWARE/OS VERSIONS
Operating System: Gentoo 
KDE Plasma Version: 5.17.90
KDE Frameworks Version: 5.66.0
Qt Version: 5.14.0
Kernel Version: 5.4.10-gentoo
OS Type: 64-bit
Processors: 8 × Intel® Core™ i7-4790K CPU @ 4.00GHz
Memory: 15.4 GiB of RAM
Comment 1 Nate Graham 2020-01-17 00:59:21 UTC
We have another report in 416119. I can't reproduce on openSUSE Tumbleweed with packages compiled from source, however.
Comment 2 Nate Graham 2020-01-17 00:59:29 UTC
*** Bug 416119 has been marked as a duplicate of this bug. ***
Comment 3 Matej Mrenica 2020-01-17 09:48:47 UTC
I also have this issue on Arch Linux.
Comment 4 Méven Car 2020-01-17 15:36:57 UTC
I can reproduce it with plasma compiled from source.
Comment 5 Andreas Sturmlechner 2020-01-17 20:56:44 UTC
That said, also 'Defaults' and 'Reset' button are never activated no matter what.

I don't see the behavior mentioned in the duplicate bug, changing anti-aliasing does nothing, as with all other options.
Comment 6 Ivaylo Atanasov 2020-01-28 04:57:07 UTC
Testing on Kubuntu Daily Build 27.01.2019:

I have found that when following these steps you are once again allowed to make and save any changes to the fonts configuration. Make some alternations to the fonts selection, uncheck the "Anti-Aliasing: Enable", then check it ON and after that uncheck it once again then hit the Apply button. From now on you can edit the settings as usually. This bug should be fixed for the 5.18 LTS release, I think there are many people who make custom fonts settings, as the default ones are not very comfortable and easy to read ...
Comment 7 Kai Uwe Broulik 2020-01-28 10:01:16 UTC
*** Bug 416847 has been marked as a duplicate of this bug. ***
Comment 8 A. Wilcox (awilfox) 2020-02-03 18:39:13 UTC
We're seeing this in Adélie Linux as well, on 5.17.90 with Qt 5.12.6.

Additionally, the dropdowns for i.e. "Sub-pixel rendering" don't show any items other than the values currently chosen.  Making the dropdowns active and then using the arrow keys, the values can be changed.  (But the values cannot be saved, as previously described in this bug.)  If this is a separate bug, I can file another.
Comment 10 Andreas Sturmlechner 2020-02-11 12:44:58 UTC
Not fixed for me with 5.18.0, `Apply` is disabled whatever I change.
Comment 11 Matej Mrenica 2020-02-11 16:24:41 UTC
Not fixed here either.
Comment 12 popov895 2020-02-12 10:02:23 UTC
Any workaround?
Comment 13 Martin Riethmayer 2020-02-12 10:29:18 UTC
*** Bug 417474 has been marked as a duplicate of this bug. ***
Comment 14 Martin Riethmayer 2020-02-12 10:29:29 UTC
*** Bug 417450 has been marked as a duplicate of this bug. ***
Comment 15 Martin Riethmayer 2020-02-12 10:29:42 UTC
*** Bug 417423 has been marked as a duplicate of this bug. ***
Comment 16 Jonathan Riddell 2020-02-12 11:51:36 UTC
The issue is caused by this commit
https://cgit.kde.org/plasma-desktop.git/commit/?id=11092af79680595211d3d22baade811bc1765cd3
KCM Fonts ConfigModule to ManagedConfigModule
Comment 17 Kai Uwe Broulik 2020-02-12 12:11:23 UTC
*** Bug 417487 has been marked as a duplicate of this bug. ***
Comment 18 Robert Strube 2020-02-12 15:32:51 UTC
I can also confirm that this bug is still present on Plasma 5.18 running on the lastest user edition of KDE Neon.
Comment 19 Nate Graham 2020-02-12 15:34:29 UTC
I guess we're learning that a lot of people change the default font. :)
Comment 20 Iyán Méndez Veiga 2020-02-12 15:49:39 UTC
(In reply to Nate Graham from comment #19)
> I guess we're learning that a lot of people change the default font. :)

Or that fonts in some apps (e.g. Firefox) changed after upgrading to 5.18.0 and first thing we try to fix it was look in the font configuration.
Comment 21 Ilya Bizyaev 2020-02-12 15:55:03 UTC
(In reply to Iyán Méndez Veiga from comment #20)
> (In reply to Nate Graham from comment #19)
> > I guess we're learning that a lot of people change the default font. :)
> 
> Or that fonts in some apps (e.g. Firefox) changed after upgrading to 5.18.0
> and first thing we try to fix it was look in the font configuration.

You might want to confirm https://bugs.kde.org/show_bug.cgi?id=416993
Comment 22 Jeffrey Bouter 2020-02-12 17:10:39 UTC
(In reply to Nate Graham from comment #19)
> I guess we're learning that a lot of people change the default font. :)

Hack 9 is just a tad too small :-)
Comment 23 Robert Strube 2020-02-12 18:44:04 UTC
(In reply to Nate Graham from comment #19)
> I guess we're learning that a lot of people change the default font. :)

I really like the default fonts, but they're too small on my screen, so it's less of the aesthetics and more of a usability issue (at least for me).
Comment 24 Nate Graham 2020-02-12 19:03:22 UTC
(In reply to Robert Strube from comment #23)
> (In reply to Nate Graham from comment #19)
> > I guess we're learning that a lot of people change the default font. :)
> 
> I really like the default fonts, but they're too small on my screen, so it's
> less of the aesthetics and more of a usability issue (at least for me).
Out of curiosity, what kind of screen do you have? What's the size and resolution, and are you scaling anything at all?
Comment 25 A. Wilcox (awilfox) 2020-02-12 19:32:16 UTC
(In reply to Nate Graham from comment #19)
> I guess we're learning that a lot of people change the default font. :)

I've never liked the look of Noto.  Liberation Sans is much less distracting for UI elements, for me.
Comment 26 The Feren OS Dev 2020-02-12 20:27:26 UTC
Managed to reproduce this issue, I'll start experimenting now with the source code to see if I can come up with a fix.
Comment 27 The Feren OS Dev 2020-02-12 22:31:21 UTC
Gave up trying to fix the current code here, but I tested Jonathan Riddell's comment and can confirm that commit indeed seems to be the starting point of this issue - versions of the source code files for this area in System Settings before that commit was made work fine.
Comment 28 boospy 2020-02-12 23:29:27 UTC
I have fun here with 4k Monitors ;)

Waiting for the fix :) 
Thanks a lot!
Comment 29 boospy 2020-02-12 23:39:22 UTC
The strange thing is. On an existing profile the fontsize is ok, changing is not available. That's why I thought, i set the fontoption directly in the file ~/.kde/share/config/kdeglobals but the options will not be set. 
Logout and in did also not help, so should there be any special command to set new options in such file?
Comment 30 peeledbanana 2020-02-13 00:00:25 UTC
I'm having the same issue on Arch as well. 

Operating System: Arch Linux 
KDE Plasma Version: 5.18.0
KDE Frameworks Version: 5.67.0
Qt Version: 5.14.1
Kernel Version: 5.4.19-1-lts
OS Type: 64-bit
Processors: 12 × Intel® Core™ i7-8750H CPU @ 2.20GHz
Memory: 15.5 GiB of RAM
Comment 31 lanstar454 2020-02-13 00:01:14 UTC
(In reply to Iyán Méndez Veiga from comment #20)
> (In reply to Nate Graham from comment #19)
> > I guess we're learning that a lot of people change the default font. :)
> 
> Or that fonts in some apps (e.g. Firefox) changed after upgrading to 5.18.0
> and first thing we try to fix it was look in the font configuration.

That is why I went to system settings to also find this bug. I found that the fonts of gtk3-themed applications are defaulting to one size a font too small since the 5.18 update. I went to /home/config/gtk-3.0/settings.ini to increase the font size of such apps by 1 pt, and now they look fine on my 1080p screen. 

Unfortunately, Plasma forces the font size back to the small size each time I log in, so I keep having to manually switch it each time... Which is why I wish there was a clear way to block this overriding of fonts.
Comment 32 boospy 2020-02-13 00:16:39 UTC
(In reply to lanstar454 from comment #31)
> Unfortunately, Plasma forces the font size back to the small size each time
> I log in, so I keep having to manually switch it each time... Which is why I
> wish there was a clear way to block this overriding of fonts.

Yes a workaround: chmod 444 /home/config/gtk-3.0/settings.ini
Comment 33 Harry ten Berge 2020-02-13 09:27:43 UTC
Confirmed on OpenSUSE Tumbleweed.
Comment 34 jdgmpviqb 2020-02-13 18:43:24 UTC
Confirmed this issue on Arch Linux.
Comment 35 Benjamin Port 2020-02-13 20:19:40 UTC
I implemented a first fix
https://phabricator.kde.org/D27384

you can download fix there: https://phabricator.kde.org/D27384?download=true

I ill be glad if someone with this bug can confirm the fix solve the problem

Thanks,
Benjamin
Comment 36 The Feren OS Dev 2020-02-13 20:29:43 UTC
(In reply to Benjamin Port from comment #35)
> I implemented a first fix
> https://phabricator.kde.org/D27384
> 
> you can download fix there: https://phabricator.kde.org/D27384?download=true
> 
> I ill be glad if someone with this bug can confirm the fix solve the problem
> 
> Thanks,
> Benjamin

Building it now with your diff on my machine which has the issue.
Comment 37 Christoph Feck 2020-02-13 20:38:27 UTC
*** Bug 417587 has been marked as a duplicate of this bug. ***
Comment 38 Jonathan Riddell 2020-02-13 20:44:38 UTC
The fix works for me
Comment 39 Eric Hameleers 2020-02-13 20:55:04 UTC
The fix works for me too (Slackware).
Comment 40 The Feren OS Dev 2020-02-13 21:10:43 UTC
(In reply to Benjamin Port from comment #35)
> I implemented a first fix
> https://phabricator.kde.org/D27384
> 
> you can download fix there: https://phabricator.kde.org/D27384?download=true
> 
> I ill be glad if someone with this bug can confirm the fix solve the problem
> 
> Thanks,
> Benjamin

Yup, this fixes it - I've tried a bunch of settings changes in Fonts and every time after this patch the Apply button is made sensitive when something is changed
Comment 41 Iyán Méndez Veiga 2020-02-13 21:57:05 UTC
I also confirm the patch works. Thanks Benjamin.
Comment 42 Andreas Sturmlechner 2020-02-13 22:20:41 UTC
Confirmed, works for me!
Comment 44 Kai Uwe Broulik 2020-02-14 11:36:53 UTC
*** Bug 417626 has been marked as a duplicate of this bug. ***
Comment 45 Nate Graham 2020-02-16 23:50:07 UTC
*** Bug 417758 has been marked as a duplicate of this bug. ***
Comment 46 Nate Graham 2020-02-18 05:24:46 UTC
*** Bug 417812 has been marked as a duplicate of this bug. ***
Comment 47 Robert Strube 2020-02-18 18:00:34 UTC
(In reply to Nate Graham from comment #24)
> (In reply to Robert Strube from comment #23)
> > (In reply to Nate Graham from comment #19)
> > > I guess we're learning that a lot of people change the default font. :)
> > 
> > I really like the default fonts, but they're too small on my screen, so it's
> > less of the aesthetics and more of a usability issue (at least for me).
> Out of curiosity, what kind of screen do you have? What's the size and
> resolution, and are you scaling anything at all?

Sorry for the late response.

I'm currently running an ultra-wide 2560*1080 monitor.  The main font I was struggling with was the 9pt Hack fixed width font.

Thanks for fixing the issue!
Comment 48 talentlcy 2020-02-19 02:41:04 UTC
When will this issue be fixed in neon user edition?
Comment 49 Nate Graham 2020-02-19 03:20:03 UTC
Given that the version including the fix was released today, I'd say the answer is "as soon as you perform an update." :)
Comment 50 talentlcy 2020-02-19 14:45:40 UTC
(In reply to Nate Graham from comment #49)
> Given that the version including the fix was released today, I'd say the
> answer is "as soon as you perform an update." :)

Got an update just now, still can't  apply font changes.
Comment 51 Méven Car 2020-02-19 15:08:28 UTC
neon developper edition, does not have plasma 5.18.1 yet :
So neither does neon user edition.
As of me typing latest neon Version is : $ apt show plasma-desktop | grep Version:
Version: 4:5.18.0+p18.04+git20200218.0030-0

(Irony is kubuntu ppa has 5.18.1)

talentlcy@hotmail.com please check you have updated to plasma 5.18.1 (in about system for instance) before giving feedback. Your last update did not concern Plasma.
Comment 52 Nate Graham 2020-02-19 15:09:14 UTC
Please verify that you are using Plasma 5.18.1 (not 5.18.0) and that you have rebooted your system.
Comment 53 talentlcy 2020-02-19 15:18:16 UTC
(In reply to Méven Car from comment #51)
> neon developper edition, does not have plasma 5.18.1 yet :
> So neither does neon user edition.
> As of me typing latest neon Version is : $ apt show plasma-desktop | grep
> Version:
> Version: 4:5.18.0+p18.04+git20200218.0030-0
> 
> (Irony is kubuntu ppa has 5.18.1)
> 
> talentlcy@hotmail.com please check you have updated to plasma 5.18.1 (in
> about system for instance) before giving feedback. Your last update did not
> concern Plasma.
OK, my system is neon user edition, and plasma version is 5.18.0.  But why is kubuntu newer than neon , shouldn't neon to have the latest version ?🤣
Comment 54 Rik Mills 2020-02-19 15:25:03 UTC
(In reply to talentlcy from comment #53)
> OK, my system is neon user edition, and plasma version is 5.18.0.  But why
> is kubuntu newer than neon , shouldn't neon to have the latest version ?🤣

Neon are upgrading to Qt 5.14.1, and the Plasma update was queued behind doing that. Makes sense for it to be, as several parts of Plasma need to be recompiled for new Qt versions anyway.
Comment 55 Iyán Méndez Veiga 2020-02-19 15:44:02 UTC
(Offtopic + advertising)
Maybe KDE Neon and Kubuntu have the reputation of updating the first, but the patch was applied in Arch Linux 5 days ago, and we have plasma desktop Plasma 5.18.1 since yesterday, just after the release hehe
Comment 56 Rik Mills 2020-02-19 15:48:45 UTC
(In reply to Iyán Méndez Veiga from comment #55)
> (Offtopic + advertising)
> Maybe KDE Neon and Kubuntu have the reputation of updating the first, but
> the patch was applied in Arch Linux 5 days ago

If we are going to do that, then FYI it was applied in Kubuntu 5 days ago as well, and copied to backports.

https://launchpad.net/ubuntu/+source/plasma-desktop/4:5.18.0-0ubuntu3
Comment 57 Eric Hameleers 2020-02-19 22:52:43 UTC
Was fixed in Slackware 6 days ago even... https://git.slackware.nl/ktown/commit/?id=d443f4f78cd553a37326f005a90b5a8f8030bf3c as we are skipping the .1 release.
Comment 58 talentlcy 2020-02-19 23:02:53 UTC
Finally, after a bunch of updates just now, kde neon was upgraded to 5.18.1, and everything is fine now. Thank everyone.
Comment 59 boospy 2020-02-19 23:54:15 UTC
It works perfectly here on NEON. Very Thanks!!! :)
Comment 60 Mark Smith 2020-03-04 21:48:32 UTC
Even after the bug was solved I could not make any change in the font settings stick. The file ~/.config/kcmfonts had the "immutable" flag set. I removed the flag and now font settings update normally as I change them. What could have caused it?