| Summary: | Not-very-long strings elided in artist/album/genre grid views | ||
|---|---|---|---|
| Product: | [Applications] Elisa | Reporter: | Nate Graham <nate> |
| Component: | general | Assignee: | Matthieu Gallien <matthieu_gallien> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | bugseforuns |
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| See Also: |
https://bugs.kde.org/show_bug.cgi?id=406474 https://bugs.kde.org/show_bug.cgi?id=406475 |
||
| Latest Commit: | https://commits.kde.org/elisa/761e3af65347072f12b770529a5effb6b39b6e58 | Version Fixed In: | |
| Attachments: | Elided album and artist names | ||
A quick fix would be to make the grid delegates larger, which would allow the pretty art in album view to be more prominent. However this would exacerbate the issues with Genre and Artist views that currently have generic icons See Bug 406474 and Bug 406475). Those issues could be solved by making them lists rather than grids, or by giving them some artwork (see those bugs). Git commit 761e3af65347072f12b770529a5effb6b39b6e58 by Nate Graham. Committed on 23/04/2019 at 02:56. Pushed by ngraham into branch 'master'. Revamp grid browser delegates to improve UI Summary: This patch changes the grid browser delegates in the following ways: - Labels are centered - Album art size increases from 100px to 170px, making the album view more attractive and leaving more room for labels - Hover buttons now appear in the corner, have borders, and no longer make the album art get washed out when the delegate is hovered - Some minor layout and positioning bugs are fixed As a result, the following bugs are fixed: Related: bug 406476 Also, the last usage of QQC1 in this component is removed as a side effect. Test Plan: Everything still works and there are no behavioral changes. {F6780036} Reviewers: mgallien, #elisa Reviewed By: mgallien, #elisa Differential Revision: https://phabricator.kde.org/D20581 M +83 -63 autotests/qmltests/tst_GridBrowserDelegate.qml M +2 -2 src/qml/BaseTheme.qml M +62 -61 src/qml/GridBrowserDelegate.qml https://commits.kde.org/elisa/761e3af65347072f12b770529a5effb6b39b6e58 |
Created attachment 119375 [details] Elided album and artist names Elisa from git master. See attached screenshot. The grid delegates' labels get elided rather than becoming multi-line strings, causing elision most artist and album names (though the problem is also visible in genre view).