Summary: | Labels of file items wrap over themselves in open/save file dialog widget's Short View | ||
---|---|---|---|
Product: | [Frameworks and Libraries] frameworks-kio | Reporter: | jm.ouwerkerk |
Component: | general | Assignee: | kdelibs bugs <kdelibs-bugs> |
Status: | RESOLVED FIXED | ||
Severity: | major | CC: | arthur, artur.glavic, benjamindaines, bugseforuns, elvis.angelaccio, jan.mussche, kdelibs-bugs, matthewtrescott, n.schnelle, nate, pmargeti34, sasha.mishchenko, sergei.chernikov, simonandric5, vkrevs, voidarray |
Priority: | NOR | Keywords: | usability |
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Debian unstable | ||
OS: | Linux | ||
Latest Commit: | https://commits.kde.org/kio/248941a0f4b4792b6935546da1c1e6bdda61846e | Version Fixed In: | |
Attachments: |
Broken layout example (1)
Broken layout example (2) 'Fixed' layout by selecting an entry |
Description
jm.ouwerkerk
2015-09-15 23:37:01 UTC
Created attachment 94589 [details]
Broken layout example (1)
Displays broken file open dialog in Kate.
Created attachment 94590 [details]
Broken layout example (2)
When the file dialog is resized to a bigger, more appropriate, size the problem still persists.
Created attachment 94591 [details]
'Fixed' layout by selecting an entry
When selecting a file/dir entry (highlighted) the layout 'suddenly' fixes itself (temporarily). The same effect of now-you-see-me-now-you-don't can be achieved by mousing over the entries. Sometimes this actually 'scrambles' a good layout and results in the 'broken' one as showcased in the previous two screen shots.
*** Bug 386864 has been marked as a duplicate of this bug. *** Using Manjaro Linux KDE 17.1.0 Hakoila with Plasma 5.11.5, Frameworks 5.41.0 and Qt 5.10.0. I can confirm the fact that Kdialog is not always showing filenames complete. It looks like columns don't have the correct width and text is cut-off. When making the window larger it normally gets better, but not always. Git commit 248941a0f4b4792b6935546da1c1e6bdda61846e by Fabian Vogt. Committed on 12/01/2018 at 08:54. Pushed by fvogt into branch 'master'. Fix KFilePreviewGenerator::LayoutBlocker Summary: QAbstractItemViews does layout in a timer event handler to avoid unnecessary layout calculations. Changes which cause a relayout only start the timer. LayoutBlocker has the restriction that it only works if the event loop is not entered during its lifetime. Without an event loop there's no expensive relayout anyway, making the LayoutBlocker pointless in such cases. LayoutBlocker works by changing the uniformItemSizes property of the QListView to true and in the destructor back to the original value again. Those changes do not trigger a relayout in QListView, so if the QListView did a layout with uniformItemSizes set to true, it stays that way. Fix it by triggering a relayout in ~LayoutBlocker. This got exposed by a change in Qt, which results in QListView doing a relayout while the LayoutBlocker is active. Test Plan: kfilewidgettest_gui has proper item sizes now. Reviewers: #frameworks, dfaure Reviewed By: dfaure Tags: #frameworks Differential Revision: https://phabricator.kde.org/D9830 M +6 -4 src/filewidgets/kfilepreviewgenerator.cpp https://commits.kde.org/kio/248941a0f4b4792b6935546da1c1e6bdda61846e *** Bug 379820 has been marked as a duplicate of this bug. *** *** Bug 387956 has been marked as a duplicate of this bug. *** *** Bug 331303 has been marked as a duplicate of this bug. *** *** Bug 346731 has been marked as a duplicate of this bug. *** *** Bug 280420 has been marked as a duplicate of this bug. *** |