Summary: | Muon Discover crash when clicking Sources Tab | ||
---|---|---|---|
Product: | [Applications] muon | Reporter: | Bob Treat <rptreat> |
Component: | libqapt | Assignee: | Jonathan Thomas <echidnaman> |
Status: | RESOLVED FIXED | ||
Severity: | crash | CC: | aleixpol, hello, sitter, umersm401 |
Priority: | NOR | Keywords: | drkonqi |
Version: | 2.2.0 | ||
Target Milestone: | --- | ||
Platform: | Kubuntu | ||
OS: | Linux | ||
Latest Commit: | http://commits.kde.org/libqapt/5baccc9bfd63ab39505b09ab042002d226d515e4 | Version Fixed In: | 2.2.1 |
Attachments: | New crash information added by DrKonqi |
Description
Bob Treat
2014-04-21 08:21:53 UTC
Git commit 5baccc9bfd63ab39505b09ab042002d226d515e4 by Harald Sitter. Committed on 24/04/2014 at 08:10. Pushed by sitter into branch '2.2'. Prevent crashes on source entries that contain a line like "##" Simply ensure that while we are stripping # the string retains the QString::at(i) requirement of i being a valid index (which requires the size() to be greater than 0 for us). Random note: while size>0 is equal to !isEmpty, the ::at() documentation specifically ties the validity of index to size, so for clarity's sake I am using size>0 rather than !isEmpty. FIXED-IN: 2.2.1 M +1 -1 src/sourceentry.cpp M +1 -0 tests/data/test1.list M +15 -2 tests/sourceslisttest.cpp http://commits.kde.org/libqapt/5baccc9bfd63ab39505b09ab042002d226d515e4 Created attachment 86308 [details]
New crash information added by DrKonqi
muon-discover (2.2.0) on KDE Platform 4.13.0 using Qt 4.8.6
- What I was doing when the application crashed:
I opened Muon Discover and clicked the sources tab.
- Custom settings of the application:
I noticed this happening after I changed my sources with synaptic package manager so it's most likely related to that. But it's not a bug from Synaptic itself as I could reproduce the bug after removing Synaptic and its configuration files so possibly difficulty in reading the sources lists.
-- Backtrace (Reduced):
#6 0x00007fc4b6c8ef79 in __GI_raise (sig=sig@entry=6) at ../nptl/sysdeps/unix/sysv/linux/raise.c:56
#7 0x00007fc4b6c92388 in __GI_abort () at abort.c:89
[...]
#11 0x00007fc3ff7be150 in at (i=<optimized out>, this=<optimized out>) at /usr/include/qt4/QtCore/qstring.h:699
#12 QApt::SourceEntryPrivate::parseData (this=0x24dac50, data=...) at /build/buildd/libqapt-2.1.70/src/sourceentry.cpp:90
#13 0x00007fc3ff7bec45 in SourceEntryPrivate (fileName=..., lineData=..., this=0x24dac50) at /build/buildd/libqapt-2.1.70/src/sourceentry.cpp:50
|