Summary: | Unchecking 'confirm logout' then logging out shuts down the system | ||
---|---|---|---|
Product: | [Unmaintained] ksmserver | Reporter: | James Spencer <jamessp> |
Component: | general | Assignee: | Lubos Lunak <l.lunak> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | alejandro, alpha.super-one, andresbajotierra, belliash, bugzilla, dkarnout, enz, giovanni, info, martynorespublika, menegola, narutoplasma14, nbigaouette, piral, razielmine, thilo, tonywhite100 |
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Debian testing | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | ||
Sentry Crash Report: |
Description
James Spencer
2009-01-30 18:22:55 UTC
I can confirm this issue with 4.2.0 packages installed from the Kubuntu repository. Unfortunately, ksmserver does not seem to crash, so I cannot provide a backtrace to help figuring out what is wrong... Confirmed here as well. Running KDE 4.2 on Slackware 12.2. The system shuts down if 'Confirm logout' is disabled. *** Bug 183268 has been marked as a duplicate of this bug. *** Confirmed here as well - KDE 4.2 compiled from scratch on Gentoo Linux... Confirmed in Archlinux, KDEmod 4.2.0. I have to "qdbus org.kde.ksmserver /KSMServer org.kde.KSMServerInterface.logout 0 0 0" in order to log out without shutting down the machine. Confirmed in Archlinux, KDE 4.2.0 Confirmed in Gentoo, KDE 4.2.0. Confirmed in Debian testing/unstable *** Bug 186140 has been marked as a duplicate of this bug. *** This bug is still there in 4.2.1 (gentoo) Still on KDEmod 4.2.2 on ArchLinux (In reply to comment #11) > Still on KDEmod 4.2.2 on ArchLinux Still on Kubuntu 9.04 (KDE 4.2.2) Looking at bug 183058, it seems this works properly when logouting with the Lock&Logout plasmoid or with the "end session" command on KRunner. So the bug only happens when clicking the Leave option on the Kickoff menu. Can you check that too ? Thanks unless i screwed up this time, ksmserver's d-bus interface's logout() function is broken - it doesn't respect the shutdown type (i.e., it never shuts down). consequently all the "plasma-based" bugs relating to shutdown would be in fact ksmserver's bug. i might try to fix that this weekend. let's see. I'm not a kde developer but I took a look at the kickoff and ksmserver codes and it seems to me that its really a ksmserver bug (not a kickoff bug, as I reported in bug 183058). The lock/logout plasmoid seems not to use the ksmserver interface to end session (maybe this is something to add to the TODO list?), but the kickoff does. A workaround could be like this (not tested, I can't compile this right now): --- trunk/KDE/kdebase/workspace/plasma/applets/kickoff/core/itemhandlers.cpp.bkp 2009-05-29 18:51:06.000000000 -0300 +++ trunk/KDE/kdebase/workspace/plasma/applets/kickoff/core/itemhandlers.cpp 2009-05-29 18:51:21.000000000 -0300 @@ -153,7 +153,7 @@ if (m_logoutAction == "logout") { type = KWorkSpace::ShutdownTypeNone; } else if (m_logoutAction == "logoutonly") { - type = KWorkSpace::ShutdownTypeLogout; + type = KWorkSpace::ShutdownTypeDefault; } else if (m_logoutAction == "lock") { kDebug() << "Locking screen"; } else if (m_logoutAction == "switch") { But this only would use the same end session method that the lock/logout does. Probably it's not the right way to solve the problem. SVN commit 976028 by ossi: try to fix up the shutdown stuff first of all, deprecate the braindead ShutdownTypeLogout again and alias it to ShutdownTypeNone internally, as the latter means "logout only" (that enum refers to the machine's state, not the session's). unify the semantics of ksmserver's d-bus interface to interpret a shutdown request with a pre-selected shutdown type as needing only a confirmation, not a full choice. this is a behavior break from the original implementation, but that actually happened in 4.2 already - i'm just fixing it. all "generic" logout actions (alt-ctrl-del, lock_logout applet, plasma desktop menu) now always pop up the full shutdown dialog, irrespective of the "confirm shutdown" option. "specialized" logout actions (like in kickoff's "leave" menu) continue to respect the "confirm shutdown" option. if the confirmation is enabled, the reduced shutdown dialog will appear as before (only some implementation details changed). BUG: 152110 BUG: 177139 BUG: 182466 M +1 -1 krunner/krunnerapp.cpp M +9 -2 ksmserver/shutdown.cpp M +64 -69 ksmserver/shutdowndlg.cpp M +3 -2 ksmserver/shutdowndlg.h M +4 -6 ksmserver/tests/test.cpp M +4 -2 libs/kworkspace/kworkspace.h M +1 -3 plasma/applets/kickoff/core/itemhandlers.cpp M +1 -1 plasma/applets/lock_logout/lockout.cpp M +1 -1 plasma/containments/desktop/desktop.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=976028 *** Bug 196863 has been marked as a duplicate of this bug. *** *** Bug 200101 has been marked as a duplicate of this bug. *** *** Bug 183058 has been marked as a duplicate of this bug. *** Must be related to the present bug: - since a recent upgrade (using KDE 4.3.0 Debian/unstable) the ksmserverrc confirmLogout=false option seems to be ignored, that is logging out (via right click or lock/logout plasma widget) always brings up the confirm logout dialog pop-up, regardless of the setting of the confirmLogout option. *** Bug 184562 has been marked as a duplicate of this bug. *** *** Bug 190418 has been marked as a duplicate of this bug. *** |