| Summary: | JJ: make the Context View remember its size | ||
|---|---|---|---|
| Product: | [Applications] amarok | Reporter: | Lydia Pintscher <lydia> |
| Component: | Context View | Assignee: | Amarok Developers <amarok-bugs-dist> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | fatlardo, hydrogen, k.dummann, kdebugs.99.urgwurz, mikko.cal, nhn, ria.freelander, sven.burmeister |
| Priority: | HI | Keywords: | junior-jobs |
| Version: | 2.0-SVN | ||
| Target Milestone: | --- | ||
| Platform: | Unlisted Binaries | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
| Attachments: |
Saves panel widths for persistance on restart
Partly fixes collapsed frame problem |
||
|
Description
Lydia Pintscher
2008-10-16 18:57:22 UTC
*** Bug 171512 has been marked as a duplicate of this bug. *** Created attachment 28039 [details]
Saves panel widths for persistance on restart
Saves the widths of the three panels on exit, and restores them on restart of Amarok.
Uses the sizeHint() member function of each panel to set the size. Should prevent problems if the main window is a different size when Amarok is restarted.
*** Bug 173217 has been marked as a duplicate of this bug. *** SVN commit 874449 by markey: Make Amarok remember its panel sizes over restarts. Patch by Gary Steinert <fatlardo@gmail.com>. I've cleaned up the patch a bit before committing. BUG: 172976 M +19 -5 MainWindow.cpp M +8 -10 MainWindow.h M +9 -1 Sidebar.h M +6 -1 playlist/PlaylistWidget.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=874449 The patch does not work as expected. If one collapses the pane, i.e. clicks on it if it is opened and restarts amarok, the pane is restored with its minimum size rather than collapsed. Created attachment 28107 [details]
Partly fixes collapsed frame problem
This partly fixes the collapsed frame problem. If the entire frame is collapsed (in the case of the sidebar, this includes the buttons), when amarok restarts, it will remain collapsed.
If, however, the sidebar is collapsed with the buttons visible, the minimum size will still be restored. I'm working on that now.
Also, there is functionality in the patch for Mark's idea of a reset to defaults button. I'll work on that for 2.1.
SVN commit 875731 by markey: New patch from Gary Steinert that improves panel size restoration. CCBUG: 172976 M +17 -7 MainWindow.cpp M +1 -6 Sidebar.h M +1 -6 playlist/PlaylistWidget.cpp M +1 -0 widgets/SidebarWidget.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=875731 Gary what are your plans for this for 2.0 rc/final? Now that I've actually remembered about this one, I've just come across some code that should allow me to get this sorted. Expect a fix soon =) Gary Not going to happen for 2.0, retargetting. I've looked into every way I can think of to get the collection browser panel to collapse properly. I just don't seem to be able to find the right way. All that is left to be fixed of this bug is to restore the left hand panel correctly when it has been collapsed (i.e. one of the tab buttons clicked twice to hide the contents of the panel). Unfortunately it is a little over my head =( Sorry Gary This is still valid with current trunk and the new CV. *** Bug 185860 has been marked as a duplicate of this bug. *** semms to fixed in current SVN, am i right? *** Bug 194293 has been marked as a duplicate of this bug. *** Works fine here now. Closing. Please re-open, this is not fixed as of Revision 973477. See comment 5 for the remaining issue. |