| Summary: | [patch] other desktops' windows not drawn with effects like desktop grid and present windows | ||
|---|---|---|---|
| Product: | [Plasma] kwin | Reporter: | Sebastian Kuźlak <sebastiankuzlak> |
| Component: | compositing | Assignee: | KWin default assignee <kwin-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | badshah400, des, drew.m.fisher, ehamberg, fhimpe, jlp, karthik.periagaram, lucas, mail |
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Compiled Sources | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Attachments: |
Patch that reverts r800581
Push desktop windows to the bottom of the stack Push desktop windows to the bottom of the stack, r2 |
||
|
Description
Sebastian Kuźlak
2008-04-30 02:34:11 UTC
I can confirm that I see this bug on my system as well. With a little investigation, I've found the commit that broke it:
r800581
Fix handling of stacking order of unmanaged windows. Could maybe use a little
bit more of optimization.
BUG: 157878
Reverting this commit fixes this problem for me.
I haven't looked far enough to see what the repercussions are (other than fixing that annoying screensaver bug listed). I'll attach the revert patch for those (like me) that can't stand to be without hidden window updates :)
Created attachment 24725 [details]
Patch that reverts r800581
This isn't the solution, of course, but this fixes the hidden thumbnail
problem, but re-introduces the window stacking order problem. If I have time
I'll look into it further to produce a fix.
*** Bug 161932 has been marked as a duplicate of this bug. *** *** Bug 161875 has been marked as a duplicate of this bug. *** After spending two entire afternoons trying to find the problem for this bug, changing each line one-by-one until the problem occurred, it all just comes down to: rootStackingOrder() returns a different list when hidden windows are kept up-to-date than when they are not. The only difference that I can see is that all windows on non-active screens are on the bottom of the list, causing Plasma's desktop containment to render on top of them. You can see this by deleting the wallpaper containments from ~/.kde4/share/config/plasma-appletsrc . I will continue trying to find the cause of this later tonight. Problem is quite obviously in layers.cpp, Workspace::propagateClients() // when having hidden previews, stack hidden windows below everything else // (as far as pure X stacking order is concerned), in order to avoid having // these windows that should be unmapped to interfere with other windows *** Bug 162972 has been marked as a duplicate of this bug. *** Created attachment 25349 [details] Push desktop windows to the bottom of the stack This seems to fix it without causing bug 157878. I can confirm that the patch from comment #9 fixes it. *** Bug 165662 has been marked as a duplicate of this bug. *** This bug is the root cause of missing windows from other desktops in the Present Windows plugin as well as in Desktop Grid. I've had the patch from comment #9 applied in my builds for two weeks now with no issues. *** Bug 165694 has been marked as a duplicate of this bug. *** Created attachment 25831 [details]
Push desktop windows to the bottom of the stack, r2
Looped the wrong way.
*** Bug 162972 has been marked as a duplicate of this bug. *** SVN commit 828060 by lunakl: Use KWin's internal stacking order for managed windows, not the X one. Fixes composited drawing of windows on other desktops. BUG: 161436 M +1 -1 composite.cpp M +5 -4 layers.cpp M +1 -1 workspace.h WebSVN link: http://websvn.kde.org/?view=rev&revision=828060 |