| Summary: | Add a little eject symbol next to mounted volumes/disks/CDs/etc in Dolphin's Places panel | ||
|---|---|---|---|
| Product: | [Applications] dolphin | Reporter: | Krenar Qehaja <kedadi> |
| Component: | panels: places | Assignee: | Dolphin Bug Assignee <dolphin-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | wishlist | CC: | afiestas, bksubhuti, bugseforuns, claudius.ellsel, codestruct, dragonheart73951, JasonW94, kde, kdelibs-bugs, kfm-devel, loacoon, mail, manuel_songokuh, nate, safeerpasha7, simonandric5 |
| Priority: | VHI | Keywords: | usability |
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Ubuntu | ||
| OS: | Linux | ||
| See Also: | https://bugs.kde.org/show_bug.cgi?id=409381 | ||
| Latest Commit: | https://invent.kde.org/frameworks/kio/commit/b59404eb70469195732dd31a9ac0f94728a6d942 | Version Fixed In: | 5.91 |
| Sentry Crash Report: | |||
| Attachments: | removing drives, mockup | ||
|
Description
Krenar Qehaja
2007-12-22 22:47:26 UTC
Created attachment 22659 [details]
removing drives, mockup
I made a mockup of my idea, to make my wish more visible for you =)
Nice to hear that you like Dolphin :-) Regarding your wish I've added Kevin Ottens to CC, as he is the maintainer of the places panel. I personally like the idea judging from the mockup, let's see what we can do in future... Will hopefully be for 4.1. Any news on this? Plans implementing it in 4.4? Does it make sense from a usability POV? Or is this a no-go? Well, will hopefully be implemented. I think it's an interesting idea, it's quite some work to get it right though... *** Bug 255790 has been marked as a duplicate of this bug. *** *** Bug 383678 has been marked as a duplicate of this bug. *** *** Bug 377259 has been marked as a duplicate of this bug. *** Definitely. My vote goes to adding a little eject symbol next to mounted volumes in Dolphin's Places panel. *** Bug 305050 has been marked as a duplicate of this bug. *** hi this bug 154499 is ready fixed? if yesthis bug will be close..right? see here:https://phabricator.kde.org/D8348 No, that patch just added the Removable Devices section to file dialogs. We still don't have an eject button there, which is what this bug tracks. I started looking into this (first dive into KDE code) and it looks like the PlacesItem class is only capable of displaying one icon, which renders on the left, and the text, which renders on the right. Furthermore, it seems like the whole PlacesItem is clicked and activated as a unit. To implement this, we'll have to add the option for PlacesItem to render a second icon that is activated separately from the main icon/text. On the plus side, all of the code to unmount the drive and enable/disable the icon is already present for the context menu, and easy to pull out. That's very cool, Jason. Let me know if you run into any roadblocks along the way! I'd love to help. *** Bug 421222 has been marked as a duplicate of this bug. *** *** Bug 425149 has been marked as a duplicate of this bug. *** Changed to dolphin as a product. Seems to make more sense to me. regarding where this bug report should live, let me provide a bit of background. The actual model for the paces panel lives in KIO, but there are two implementations of its visual presentation: one in KIO, which you can see in the file dialog, Gwenview, Kate, and many other places; and another one specific to Dolphin. So with the current state of affairs, we'd technically need two bug reports: one tracking implementing this in the general KIO version, and another one tracking implementing it just for Dolphin. However what we ideally should do is port Dolphin to use the KIO implementation so that all the code is centralized in one place and we don't need to implement the same feature in two places (KIO and Dolphin. See https://phabricator.kde.org/T9795. Then we can implement the eject button in KIO once and all apps that show a Places panel will get it for free. Kai started working on doing this last year: https://phabricator.kde.org/D26067 Unfortunately the work seems to have stalled recently. :( I think it would be good to get that going again and move this bug back to KIO so that the feature can be implemented there, and then once Kai's patch gets merged, Dolphin will get the feature for free. What do you think? Oh and thanks for all the bug triaging, BTW. :) Thanks for the explanation. I was unaware of the different implementations of the places panel. You are right, it probably makes sense to try not to have duplicate code and thus use the already existing implementation also in Dolphin. The only thing I am not sure about is whether it is sensible to have unmount buttons also in the other contexts where the places panel is used in. But I guess that could also maybe be circumvented with some sort of switch dependent on the context, if this should turn out to be a problem. Cool, glad to be able to provide that background. Are you okay with moving this back to KIO? (In reply to Nate Graham from comment #20) > Cool, glad to be able to provide that background. > > Are you okay with moving this back to KIO? I don't know what the right place would be. Basically this issue wants to see the functionality integrated in Dolphin and doesn't really care how this is achieved technically. To get this done technically in the proposed way, one would need actually two issues, one for integrating this in KIO and one to use KIO places in Dolphin. So I think one could maybe add those two issues (if not already there) and link them to this one, with having KIO places in Dolphin as a dependency for this one. This has the benefit that there are open issue for every involved product, so the awareness for this on the relevant sides might be higher. Also it offers some more granularity and modularity. Finally some progress! * The KIO enablement for porting back Dolphin to KFilePlacesView has just been merged * The Dolphin patch is still pending but should be safe to go in in a few days * and now there's a patch to add a little eject icon :) https://invent.kde.org/frameworks/kio/-/merge_requests/697 Git commit b59404eb70469195732dd31a9ac0f94728a6d942 by Kai Uwe Broulik. Committed on 10/01/2022 at 13:14. Pushed by broulik into branch 'master'. [KFilePlacesView] Add inline eject button M +142 -12 src/filewidgets/kfileplacesview.cpp M +72 -8 src/filewidgets/kfileplacesview_p.h https://invent.kde.org/frameworks/kio/commit/b59404eb70469195732dd31a9ac0f94728a6d942 |