| Summary: | Tower of Babel-like confusion around the meaning of the +q and +a user modes | ||
|---|---|---|---|
| Product: | [Applications] konversation | Reporter: | Oliver Lewisohn <ollie.jl> |
| Component: | protocol | Assignee: | Konversation Developers <konversation-devel> |
| Status: | CONFIRMED --- | ||
| Severity: | normal | CC: | cathy, edwardfredriks, error.syntax0, hein, johu, m.niggli, mailomaysara, OldShatterhand, rdieter, shentino |
| Priority: | NOR | ||
| Version: | 1.5-rc1 | ||
| Target Milestone: | --- | ||
| Platform: | openSUSE | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
| Attachments: | Patch that fixes the issue | ||
|
Description
Oliver Lewisohn
2007-12-06 19:58:25 UTC
What network is this happening on? I've the same problem on my IRC Networks. I send that I've when I connect to my IRC Network : [09:02] [Bienvenue] Your host is Kolosse.MoonScoop-Fan.com, running version Unreal3.2.7 [09:02] [Bienvenue] This server was created samedi 31 mai (UTC+0200) at 2008, 00:10:37 [09:02] [Bienvenue] Serveur Kolosse.MoonScoop-Fan.com (Version Unreal3.2.7), Modes utilisateur : iowghraAsORTVSxNCWqBzvdHtGp, Modes canal : lvhopsmntikrRcaqOALQbSeIKVfMCuzNTGj [09:02] [Gérer] Neurones67 CMDS=KNOCK,MAP,DCCALLOW,USERIP NAMESX SAFELIST HCN MAXCHANNELS=25 CHANLIMIT=#:25 MAXLIST=b:60,e:60,I:60 NICKLEN=30 CHANNELLEN=32 TOPICLEN=307 KICKLEN=307 AWAYLEN=307 MAXTARGETS=20 [09:02] [Gérer] Neurones67 WALLCHOPS WATCH=128 SILENCE=15 MODES=12 CHANTYPES=# PREFIX=(qaohv)~&@%+ CHANMODES=beI,kfL,lj,psmntirRcOAQKVCuzNSMTG NETWORK=MoonScoop-Fan.com CASEMAPPING=ascii EXTBAN=~,cqnr ELIST=MNUCT STATUSMSG=~&@%+ EXCEPTS If you need further informations, tell me :) and sorry for my bad english, I'm french :) I can reproduce this with Konversation 1.1 and KDE 3.5.10 on Gentoo in euIRC (irc.euirc.net) Just now I found that it's not just the wrong state for admin, but that owner/admin status appear to be interchanged.. Likely related to bug #139591 and #148437. I have firsthand experience with this bug, the icon changes when mode +a is granted on a user, not (for example) when you join the channel and there are admins already there. This would be a very nice fix for the final release of 1.2 *** Bug 220285 has been marked as a duplicate of this bug. *** *** Bug 220285 has been marked as a duplicate of this bug. *** I would like to confirm this bug as still present in 1.3.1 on Gentoo Linux. *** Bug 315424 has been marked as a duplicate of this bug. *** Created attachment 77417 [details]
Patch that fixes the issue
Please find attached a patch that fixes this bug.
Thanks for the patch. On what network and IRCd are you seeing this issue? On Mon, Feb 18, 2013 at 7:08 PM, Cathy J. Fitzpatrick <cathy@cathyjf.com>wrote: > https://bugs.kde.org/show_bug.cgi?id=153580 > > --- Comment #11 from Cathy J. Fitzpatrick <cathy@cathyjf.com> --- > Created attachment 77417 [details] > --> https://bugs.kde.org/attachment.cgi?id=77417&action=edit > Patch that fixes the issue > > Please find attached a patch that fixes this bug. > > -- > You are receiving this mail because: > You are the assignee for the bug. > _______________________________________________ > Konversation-devel mailing list > Konversation-devel@kde.org > https://mail.kde.org/mailman/listinfo/konversation-devel > [16:44:18] [Welcome] Welcome to the synIRC IRC Network Cathy!~Cathy@... [16:44:18] [Welcome] Your host is moonlight.se.eu.synirc.net, running version Unreal3.2.9 [16:44:18] [Welcome] This server was created Tue Jun 19 2012 at 21:04:53 CEST [16:44:18] [Welcome] Server moonlight.se.eu.synirc.net (Version Unreal3.2.9), User modes: iowghraAsORTVSxNCWqBzvdHtGp, Channel modes: lvhopsmntikrRcaqOALQbSeIKVfMCuzNTGjZ [16:44:18] [Support] Cathy CMDS=KNOCK,MAP,DCCALLOW,USERIP UHNAMES NAMESX SAFELIST HCN MAXCHANNELS=40 CHANLIMIT=#:40 MAXLIST=b:60,e:60,I:60 NICKLEN=30 CHANNELLEN=32 TOPICLEN=307 KICKLEN=307 AWAYLEN=307 are supported by this server [16:44:18] [Support] Cathy MAXTARGETS=20 WALLCHOPS WATCH=128 WATCHOPTS=A SILENCE=15 MODES=12 CHANTYPES=# PREFIX=(qaohv)~&@%+ CHANMODES=beI,kfL,lj,psmntirRcOAQKVCuzNSMTGZ NETWORK=synIRC CASEMAPPING=ascii EXTBAN=~,qjncrR ELIST=MNUCT are supported by this server [16:44:18] [Support] Cathy STATUSMSG=~&@%+ EXCEPTS INVEX are supported by this server [16:44:18] [Notice] -moonlight.se.eu.synirc.net- *** You are connected to moonlight.se.eu.synirc.net with TLSv1-AES256-SHA-256bits That said, I don't think my proposed patch will have side effects on other networks. The code in the region I changed already assumes that mode +a is admin (not owner). The call to setOwner() appears to just be a typo. *** Bug 308016 has been marked as a duplicate of this bug. *** *** Bug 148437 has been marked as a duplicate of this bug. *** Note that bug 148437 introduces an additional meaning of "super OPs" for +q. I've tested Fitzpatrick's patch and it works. I think we should go ahead and apply it to the mainline. It fixes an obvious bug and it doesn't appear to conflict with the mode rework. Furthermore, the mode rework may yet take a long while. I'd like to hear Eli's opinion on that since he's the domain expert. I had a nice chat with argonel on irc's #konversation and the consensus is that this is indeed a typo being fixed. Said that there was a good chance of it popping into 1.5. Git commit 5b79cf8cad9781f37f52f77a71353ea4caf64698 by Eike Hein, on behalf of Cathy J. Fitzpatrick. Committed on 19/02/2013 at 00:46. Pushed by hein into branch '1.5'. Fix for setting mode +a or -a Previously, setting or removing mode +a on a nick in a channel called ChannelNick::setOwner(), so setting +a on a nick made the nick appear as an owner of the channel, rather than as an admin. This commit fixes the problem by correctly calling ChannelNick::setAdmin() instead. M +1 -1 src/irc/channel.cpp http://commits.kde.org/konversation/5b79cf8cad9781f37f52f77a71353ea4caf64698 |