Bug 93357 - Konqueror starts Opera when browsing the internet
Summary: Konqueror starts Opera when browsing the internet
Status: RESOLVED FIXED
Alias: None
Product: konqueror
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: openSUSE Linux
: NOR normal
Target Milestone: ---
Assignee: David Faure
URL:
Keywords:
: 81654 93344 139172 (view as bug list)
Depends on:
Blocks:
 
Reported: 2004-11-16 13:24 UTC by Martin Krischik
Modified: 2008-05-18 08:45 UTC (History)
5 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
test case with iframe showing iframes rendered in external browser. (427 bytes, text/html)
2004-11-16 16:21 UTC, Stephen Depooter
Details
proposed fixed (625 bytes, patch)
2004-11-16 19:56 UTC, Stephen Depooter
Details
white space fixes in the patch (631 bytes, patch)
2004-11-16 20:16 UTC, Stephen Depooter
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Krischik 2004-11-16 13:24:15 UTC
Version:            (using KDE KDE 3.3.1)
Installed from:    SuSE RPMs
OS:                Linux

When I browse the internet with Konqueror then Konqueror start Opera when clicking a link. This is of corse not what I want and it seems not right for a Web Browser. Or have you ever seen mozilla starting internet explorer just because IE was default browser?

This is of course different when clicking a link in for excample KMail where it is quite OK to start Opera as default for HTML pages.

Just when I start bowsing with Konqueror I want to stay within Konqueror. i.E. Konqueror has a working spell checker which is usefull for Wiki Pages.

With Regards

Martin.

PS: Please forgive the spelling mistakes - but I have to fill in this report with opera :-(.
Comment 1 Martin Krischik 2004-11-16 13:25:18 UTC
Just as clarification: is is of corse KDE 3.3.3 - KDE 3.3.3 was not in the list
Comment 2 Maksim Orlovich 2004-11-16 15:16:12 UTC
*** Bug 93344 has been marked as a duplicate of this bug. ***
Comment 3 Stephen Depooter 2004-11-16 16:21:38 UTC
Created attachment 8297 [details]
test case with iframe showing iframes rendered in external browser.
Comment 4 George Staikos 2004-11-16 16:31:46 UTC
Here it opens in GV for me for some reason, and crashes when I click in it.
Comment 5 Stephen Depooter 2004-11-16 19:56:26 UTC
Created attachment 8301 [details]
proposed fixed

Here is a fix that works for me.  khtml is using an external browser when it
launches a new KHTMLRun object.  

I called the inherited functionality in CVS KRun to not use an external browser
for parts of a webpage we are rendering in a kpart.
Comment 6 Stephen Depooter 2004-11-16 20:16:30 UTC
Created attachment 8302 [details]
white space fixes in the patch
Comment 7 Stephan Binner 2004-11-16 20:21:30 UTC
> Just as clarification: is is of corse KDE 3.3.3 - KDE 3.3.3 was not in the list

May I bet that this is because no KDE 3.3.3 exists? :-)
Comment 8 Martin Krischik 2004-11-17 09:30:49 UTC
Ups, you are rigth still wrong version number - got it all mixed up in my had. Its 3.3.0.

BTW: Konqueror would have filled the version number by itself. Yet another good reasong for allowing browsing with Konqueror even when another Browser is default.
Comment 9 Martin Krischik 2004-11-17 09:53:37 UTC
I tried a set Konqueror as default browser. The Result was worth it's own bug report:

See: http://bugs.kde.org/show_bug.cgi?id=93430
Comment 10 Waldo Bastian 2004-11-19 12:42:17 UTC
CVS commit by waba: 

Don't use external browser for frames
BUG: 93357
Patch by Stephen Depooter


  M +3 -0      khtml_run.cpp   1.37


--- kdelibs/khtml/khtml_run.cpp  #1.36:1.37
@@ -34,4 +34,7 @@ KHTMLRun::KHTMLRun( KHTMLPart *part, kht
   m_child( child )
 {
+    // Don't use an external browser for parts of a webpage we are rendering. (iframes at least are one example)
+    setEnableExternalBrowser(false);
+
     // get the wheel to start spinning
     part->started(0L);


Comment 11 H.H. 2005-08-14 23:10:36 UTC
I think the bug never was fixed. The reporter wanted LINKS to open in konqueror-browser, too, when clicked from within the konqueror-browser. Even if opera is the standard-browser. I have this problem for many month, also in the newest kde-version 3.4.3.
Comment 12 Martin Krischik 2005-08-15 18:35:25 UTC
Precicly - that's the ways any any browser works - no other browser would spawn off the default browser when you surf a site.

Which is handy if a particular site does not reder properly inside the default browser - you start one of the non default browsers you have installed and continue there.

And this behavior is cerntainly not fixed in V. 3.4.2.
Comment 13 Martin Krischik 2005-08-15 18:39:00 UTC
Reopen - It's not fixed: Konqueor still behave like a File-Browser and not like a Web-Browser when in Web-Browing-Mode - but then prehaps you can't have it both.
Comment 14 Tim Wunder 2005-12-27 02:10:06 UTC
This is a duplicate of http://bugs.kde.org/show_bug.cgi?id=81654 one or the other should be closed. FWIW, the bug stil exists in KDE 3.5.0.
Comment 15 Thiago Macieira 2005-12-27 04:12:48 UTC
*** Bug 81654 has been marked as a duplicate of this bug. ***
Comment 16 David Faure 2005-12-27 13:05:21 UTC
Does it help if you move the line to the parent class, i.e. KParts::BrowserRun?
Then it should also have an effect on Konqueror itself (not only on frames inside KHTML).

This is for kdelibs/kparts, please test.

--- browserrun.cpp      (revision 488546)
+++ browserrun.cpp      (working copy)
@@ -45,6 +45,7 @@ BrowserRun::BrowserRun( const KURL& url,
       m_args( args ), m_part( part ), m_window( window ),
       m_bRemoveReferrer( removeReferrer ), m_bTrustedSource( trustedSource )
 {
+  setEnableExternalBrowser( false );
   d = new BrowserRunPrivate;
   d->m_bHideErrorDialog = false;
 }
@@ -57,6 +58,7 @@ BrowserRun::BrowserRun( const KURL& url,
       m_args( args ), m_part( part ), m_window( window ),
       m_bRemoveReferrer( removeReferrer ), m_bTrustedSource( trustedSource )
 {
+  setEnableExternalBrowser( false );
   d = new BrowserRunPrivate;
   d->m_bHideErrorDialog = hideErrorDialog;
 }
Comment 17 Jakub Januszkiewicz 2007-02-03 14:17:01 UTC
Bug #139172 looks like a duplicate of this.
Comment 18 Jean-Marie Favreau 2007-08-07 11:41:06 UTC
This bug allready exists in debian sid (07-08-2007)
Comment 19 Unknown 2008-05-15 21:15:39 UTC
The problem is fixed in Konqueror 4.0.4.
It doesn't occur even when you have "File Manager" profile selected instead of "Web browsing".
Comment 20 David Faure 2008-05-16 13:38:26 UTC
Yes, this is currently completely independent from the selected profile. Profiles are only about the organization of the views, and the window/toolbar settings, nothing else.

Indeed I fixed konqueror 4 so that it keeps opening html pages in itself when browsing the web -- but the question is what should happen when clicking on an HTML file in a directory view. I used this logic in konqueror 4: if any tab in this mainwindow is showing an HTML page, then keep opening HTML pages in konqueror. But otherwise, fire the associated browser (e.g. opera). Otherwise it would be impossible to use konqueror purely as a filemanager.

But maybe this should be profile-dependent indeed, it would be a clearer logic than the above magic..... Opinions?  [More precisely, konqueror trunk knows two modes on startup: filemanager or webbrowser; this can be used with any profile, for people using more than two profiles]. The problem is what happens when people type a web url in a window that was originally opened for file management :)

Closing the bug as FIXED, in any case.
Comment 21 George Goldberg 2008-05-18 08:45:58 UTC
*** Bug 139172 has been marked as a duplicate of this bug. ***