Version: (using Devel) Installed from: Compiled sources As already reported, there is a bit of confusion regarding those actions: - leave - logout - shutdown "Leave" label is used: - on the kickoff tab for provide the various action to perform - on rmb button on desktop for the "logout" action "Logout" label is used: - on kickoff menu - on the "leave/logout" widget There are three problems: 1) the icon used for leave is the same for shutdown. - solution: add a new icon. 2) the action called by "leave" on RMB is not "leave", but logout. - solution: use "logout" icon instead of shutdown and change the string to "Logout..." (the string can be changed even if we are in string freeze because it is already used) 3) the icon used on lock/logout plasmoid is "shutdown", but the label (and the action called) is logout. - solution: use "logout" icon instead of shutdown. I've filled this bug report because oldest bug are a bit confusionary. I've opened only one bug report and not three because they are all related each other. I'll attach a trivial patch to fix the second and the third problems. About the first problem I know that it has already been discussed, but I cannot find where and what it was decided, so I'm asking here what about it. Thanks for reading. :-) If you agree I can apply the patch for the second and the third problems. Regards :-)
Created attachment 25665 [details] patch
ad.1) I am all for this ad.2) already reported https://bugs.kde.org/show_bug.cgi?id=164816 this is ksmserver bug (there is an error in this report, because it is SS isue, not KControl), changing settings in SS does not change the labels and icons accordingly ad.3) this is (2) case I use binary SVN and due to lack of space I am unable to recompile KDE on my own, but if your patch changes label & icon according to ksmserver settings then it is great. The real solution would be to drop ksmserver options completely and add the ability to: a) customize lock/logout plasmoid -- reported https://bugs.kde.org/show_bug.cgi?id=164687 b) customize desktop context menu -- reported https://bugs.kde.org/show_bug.cgi?id=164817 c) customize fully KMenu -- reported :-) https://bugs.kde.org/show_bug.cgi?id=162469
so i've unfortunately just wasted another 15 minutes on this issue going through each issue noted in this bug report. i probably should have just clicked "WONTFIX" right away as this is really just the old bug report warmed over and resubmitted; but i did go through all the "problem" spots noted in the report. and every single one of them is exactly how we want it right now. the "Leave" idea is used at top level items so people know it's not *only* about logging out, and it's only once they drill down (which is something the kickoff menu lets you do) that we get more specific (and use, e.g., the logout icon and term) as for the lock/logout applet .. i figured the *name* of it would be the offense, not the icon used. in any case, the principle here is to not concentrate on the *literal* meaning of the icon, but the context and user tasks being attempted where it appears.
> the "Leave" idea is used at top level items so people know it's not *only* > about logging out, and it's only once they drill down (which is something > the kickoff menu lets you do) that we get more specific (and use, e.g., the > logout icon and term) I've understand it, "leave" with his icon should behave the same on both kickoff and right mouse button, or am I wrong? > as for the lock/logout applet .. i figured the *name* of it would be the > offense, not the icon used. So do you mean that it is better to change the name to "lock/leave"? ... well, maybe the name could be "improved" when the widget itself will be improved (about adding options ecc). But it will be done after 4.1, so I've suggested to "fix" temporary it :-) > in any case, the principle here is to not concentrate on the *literal* > meaning of the icon, but the context and user tasks being attempted where > it appears. Right, I can agree this, but about the label "leave" on the rmb for example, it is write "leave", but the action called is logout (with the confirmation dialog off). I've wanted to put all this issues on the same report for watching them togheter. The idea was to save some time for avoid to look on a lot of old reports :-( Anyway thanks for your clear answer :-) bye!