Summary: | Konqueror Scan Plugins crashes kwin | ||
---|---|---|---|
Product: | [Plasma] kwin | Reporter: | Ismail Donmez <ismail> |
Component: | general | Assignee: | KWin default assignee <kwin-bugs-null> |
Status: | RESOLVED FIXED | ||
Severity: | grave | CC: | daniel.engelschalt, djander, gj, klee, mateusz-lists, scottn, tpr, tringo |
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Compiled Sources | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: |
Description
Ismail Donmez
2003-11-11 18:22:58 UTC
*** Bug 67919 has been marked as a duplicate of this bug. *** *** Bug 67938 has been marked as a duplicate of this bug. *** Subject: kdebase/kwin CVS commit by lunakl: Avoid transient loops with group transients. CCMAIL: 67914-done@bugs.kde.org M +17 -7 group.cpp 2.8 --- kdebase/kwin/group.cpp #2.7:2.8 @@ -346,4 +346,6 @@ void Client::setTransient( Window new_tr transient_for = workspace()->findClient( WindowMatchPredicate( transient_for_id )); assert( transient_for != NULL ); // verifyTransient() had to check this + if( transient_for->groupTransient()) + removeTransient( transient_for ); transient_for->addTransient( this ); } @@ -437,5 +439,5 @@ void Client::cleanGrouping() // Make sure that no group transient is considered transient -// for a window trat is (directly or indirectly) transient for it. +// for a window that is (directly or indirectly) transient for it. // Group transients not being transient for each other is already // handled before calling addTransient(). @@ -544,4 +546,5 @@ void Client::addTransient( Client* cl ) { assert( !transients_list.contains( cl )); + assert( !cl->transients_list.contains( this )); assert( cl != this ); transients_list.append( cl ); @@ -635,5 +638,5 @@ Client* Client::findModal() void Client::checkGroup() { - bool check_group_transients = false; + Group* old_group = in_group; if( window_group != None ) { @@ -652,5 +655,4 @@ void Client::checkGroup() in_group = new_group; in_group->addMember( this ); - check_group_transients = true; } } @@ -667,5 +669,4 @@ void Client::checkGroup() in_group = transientFor()->group(); in_group->addMember( this ); - check_group_transients = true; } } @@ -685,13 +686,22 @@ void Client::checkGroup() } } - if( check_group_transients ) + if( in_group != old_group ) { + for( ClientList::Iterator it = transients_list.begin(); + it != transients_list.end(); + ) + { // it's no longer transient for group transients in the old group + if( (*it)->groupTransient() && (*it)->group() != group()) + it = transients_list.remove( it ); + else + ++it; + } for( ClientList::ConstIterator it = group()->members().begin(); it != group()->members().end(); ++it ) { - if( !(*it)->groupTransient()) + if( !(*it)->groupTransient()) // and its transient for group transients in the new group continue; - if( !transients_list.contains( *it )) + if( !transients_list.contains( *it )) // unless it's the other way around addTransient( *it ); } *** Bug 67980 has been marked as a duplicate of this bug. *** *** Bug 68003 has been marked as a duplicate of this bug. *** *** Bug 68067 has been marked as a duplicate of this bug. *** *** Bug 68175 has been marked as a duplicate of this bug. *** Configure Kmail....Identities....modify....Signature....select from file...click on the folder icon Yeah I can reproduce too.... *** Bug 68292 has been marked as a duplicate of this bug. *** Should be fixed now. I'm still able to produce this crash on todays kdelibs + kdebase. To reproduce: 1. Run the Icon kcm _standalone_ (kcmshell Icons) 2. Click "Install New Theme..." 3. Click the File Dialog button =>On a fresh system, here the file dialog comes up with the "Quick Access Navigation Panel" visible, and on it an icon called "Network" 4. Click the Network icon. On my system I don't have Lisa running, this produces a message box. => Crash. On my system, kwin crashes (well.. disappears at least, there is never a backtrace) every time the "Lisa does not appear to be running" warning box comes up IF I run the icon kcm standalone, and never if it is run as part of kcontrol. Subject: Re: Konqueror Scan Plugins crashes kwin I can confirm Jens's report. Not quite running current, but this past weekend, definitely after Lubos's fix of Nov. 12 (which does fix the crashes I observed earlier in Bug 67938). ~k *** Bug 68692 has been marked as a duplicate of this bug. *** *** Bug 68722 has been marked as a duplicate of this bug. *** Hopefully finally fixed. Please retest. Subject: Re: Konqueror Scan Plugins crashes kwin Built from clean build of last night (21 Nov.) and I can confirm kcmshell Icons does not crash kiwn, nor do any of the other cases that previously crashed for me. Thanks! ~k I can't crash it either. Thanks! :) cool, it works here too under my testing. Thanks *** Bug 69788 has been marked as a duplicate of this bug. *** *** Bug 68650 has been marked as a duplicate of this bug. *** |