Bug 59379 - mimelib can't parse several "cc:" lines in a message
Summary: mimelib can't parse several "cc:" lines in a message
Status: RESOLVED FIXED
Alias: None
Product: kmail
Classification: Applications
Component: general (show other bugs)
Version: SVN (3.5 branch)
Platform: Compiled Sources Linux
: NOR grave
Target Milestone: ---
Assignee: kdepim bugs
URL:
Keywords:
: 53321 62395 63381 63447 (view as bug list)
Depends on:
Blocks:
 
Reported: 2003-06-05 13:08 UTC by Per Winkvist
Modified: 2007-09-14 12:17 UTC (History)
5 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
patch (1.35 KB, patch)
2003-11-01 21:33 UTC, Stephan Kulow
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Per Winkvist 2003-06-05 13:08:24 UTC
Version:            (using KDE Devel)
Installed from:    Compiled sources
OS:          Linux

I noticed that both Outlook express and kmail 1.5.9 send mail where the cc look like these (I don't know if it illegal or correct):
....
cc: bla@foo.net
cc: foo@bla.net
cc: "For developer's discussion about KOffice" <koffice-devel@mail.kde.org>
Subject: Re: [Uml-devel] Re: karbon/umbrello
....

When receiving such mail kmail only displays one CC line. I beleive this is due to mimelib only returns the body for the first cc header it finds.

The real problem for me isn't that I don't see the complete CC line, but that the filters doesn't work correctly since sometimes the mailing list is at the end of the cc list (like the example above) and thus not filtered == very annoying :=)

When we search for a header we return the body once the header is found. What if we continue searching for more duplicate headers and append their body to the first one we found... Or would that screw things up elsewhere?
Comment 1 Ingo Klöcker 2003-06-06 01:21:55 UTC
Subject: Re:  New: mimelib can't parse several "cc:" lines in a message

Multiple To: and Cc: headers violate RFC 2822 (Internet Message Format). 
Does KMail really create multiple Cc: headers?

On Thursday 05 June 2003 13:08, Per Winkvist wrote:
> When we search for a header we return the body once the header is 
> found. What if we continue searching for more duplicate headers and
> append their body to the first one we found... Or would that screw
> things up elsewhere?

I don't think that this would break anything.

Regards,
Ingo

Comment 2 Per Winkvist 2003-06-06 11:01:28 UTC
Subject: Re:  mimelib can't parse several "cc:" lines in a message

> Multiple To: and Cc: headers violate RFC 2822 (Internet Message Format).
> Does KMail really create multiple Cc: headers?

------------------------------------------------------------
User-Agent: KMail/1.5.1
References: <157240-2200353718482709@M2W093.mail2web.com>
	<200305120939.22680.asutton@cs.kent.edu>
 <200305130242.40592.lparrab@gmx.net> In-Reply-To:
 <200305130242.40592.lparrab@gmx.net>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200305131018.34480.asutton@cs.kent.edu>
X-Spam-Status: No, hits=-25.4 required=5.5
	tests=IN_REP_TO,QUOTED_EMAIL_TEXT,REFERENCES,REPLY_WITH_QUOTES,
	      USER_AGENT_KMAIL
	version=2.53
X-Spam-Level:
X-Spam-Checker-Version: SpamAssassin 2.53 (1.174.2.15-2003-03-30-exp)
cc: "For developer's discussion about KOffice" <koffice-devel@mail.kde.org>
cc: uml-devel@lists.sourceforge.net
Subject: Re: [Uml-devel] Re: karbon/umbrello
------------------------------------------------------------

And here too (though it would be less surprisingly if this wasn't following
the standard ;=) )
------------------------------------------------------------------------
X-MSMail-Priority: Normal
X-Mailer: Microsoft Outlook Express 5.00.2014.211
X-MIMEOLE: Produced By Microsoft MimeOLE V5.00.2014.211
X-Spam-Status: No, hits=-1.0 required=5.5
	tests=QUOTED_EMAIL_TEXT,REFERENCES
	version=2.54
X-Spam-Level:
X-Spam-Checker-Version: SpamAssassin 2.54 (1.174.2.17-2003-05-11-exp)
cc: lparrab@gmx.net
cc: kudling@kde.org
cc: rwlbuis@xs4all.nl
cc: "For developer's discussion about KOffice" <koffice-devel@mail.kde.org>
Subject: Re: [Uml-devel] Re: karbon/umbrello
------------------------------------------------------------------------

> > When we search for a header we return the body once the header is
> > found. What if we continue searching for more duplicate headers and
> > append their body to the first one we found... Or would that screw
> > things up elsewhere?

Should we just add a comma between the appended bodies?
Hmm... What would happen to "Received" field if we modify mimelib accordinly?

Perhaps it would be better to just extend the fields::Cc function to traverse
the linked list and append additional cc fields so we'll be on the safe side?
(I don't have the code here atm so maby it was the Headers::Cc function)

Comment 3 Thiago Macieira 2003-06-06 14:15:19 UTC
Just to be sure, does this happen at all when koffice-devel@mail.kde.org is not 
envolved? Try generating the same problem without sending into any mailing lists. 
 
We have to find the culprit here and I actually think it might be the Mailing List 
Manager. 
Comment 4 Till Adam 2003-06-07 14:38:15 UTC
I just came across #53321. Apparently it happens that cc headers are split. Even if the 
mailing list manager is to blame, in this particular case, shouldn't kmail be able to cope? 
Comment 5 Ingo Klöcker 2003-06-07 14:42:18 UTC
Subject: Re:  mimelib can't parse several "cc:" lines in a message

Like Thiago already wrote it's most like the mailing list software that 
breaks the CC header in multiple headers. KMail definitely doesn't do 
this (it always uses DwHeaders::AddOrReplaceField and never 
DwHeaders::AddField).

The change has to be made in DwHeaders::Cc (resp. in a new function 
which would also be used by DwHeader::To).

Comment 6 Till Adam 2003-06-07 15:30:55 UTC
*** Bug 53321 has been marked as a duplicate of this bug. ***
Comment 7 Ingo Klöcker 2003-08-28 21:05:36 UTC
*** Bug 63381 has been marked as a duplicate of this bug. ***
Comment 8 Stephan Kulow 2003-09-21 15:56:18 UTC
I want to have this bug fixed. Raising priority for now :) 
Comment 9 Stephan Kulow 2003-09-23 21:15:19 UTC
*** Bug 63447 has been marked as a duplicate of this bug. ***
Comment 10 Stephan Kulow 2003-09-23 21:34:05 UTC
*** Bug 62395 has been marked as a duplicate of this bug. ***
Comment 11 Stephan Kulow 2003-11-01 21:33:28 UTC
Created attachment 2970 [details]
patch
Comment 12 Ingo Klöcker 2003-11-02 01:26:52 UTC
Fixed without Coolo's evil hack.