Bug 54473 - atlantik: missing estate information
Summary: atlantik: missing estate information
Status: RESOLVED UNMAINTAINED
Alias: None
Product: atlantik
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: Rob Kaper
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-02-11 14:11 UTC by esigra
Modified: 2009-09-07 15:26 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Patch against KDE_3_1_BRANCH from today (8.35 KB, patch)
2003-02-12 17:20 UTC, esigra
Details
My complete diff against KDE_3_1_BRANCH (19.42 KB, patch)
2003-02-17 17:43 UTC, esigra
Details
This eventsrc belongs together with the patch above (668 bytes, text/plain)
2003-02-17 17:45 UTC, esigra
Details
My complete diff against KDE_3_1_BRANCH (57.70 KB, patch)
2003-02-22 18:23 UTC, esigra
Details

Note You need to log in before you can comment on or make changes to this bug.
Description esigra 2003-02-11 14:11:29 UTC
Version:           KDE_3_1_BRANCH from today (using KDE KDE 3.1)
Installed from:    Compiled From Sources
Compiler:          gcc-3.2.2 

Some information is missing from the display inside the gameboard when an estate is clicked. It should also show:

houseprice
sellhouseprice
mortgageprice
unmortgageprice
can_be_owned
can_toggle_mortgage
can_buy_houses
can_sell_houses
rent0, rent1, rent2, ...
money
Comment 1 esigra 2003-02-12 17:20:02 UTC
Created attachment 940 [details]
Patch against KDE_3_1_BRANCH from today
Comment 2 esigra 2003-02-17 17:43:16 UTC
Created attachment 978 [details]
My complete diff against KDE_3_1_BRANCH

This patch includes all my modifications to the KDE_3_1_BRANCH. It
fixes [http://bugs.kde.org/show_bug.cgi?id=54473] and
[http://bugs.kde.org/show_bug.cgi?id=54499]. These features were
added:
	* Added missing estate information:
    * houseprice
		* sellhouseprice
		* mortgageprice
		* unmortgageprice
		* rent0
		* rent1
		* rent2
		* rent3
		* rent4
		* rent5
	* Added menuitem to the popupmenu in the portfolioview. It is called
		"Calculate asset worth" and is useful for selecting how to pay
tax
		as a workaround for
[http://bugs.kde.org/show_bug.cgi?id=54538].
	* Added (sound) notifications for these events:
		* A new game is created
		* A new player joins the game
		* A player sends a chat message
		* The player can roll the dice
		* The player can buy estate
		* A new auction has begun
		* A player has made a new bid in an auction
	* Added a toggle action for autoplay. When it is toggled, the client
		makes some trivial decisions such as rolling and buying. The
		autoplay is interrupted when the action is untoggled or when
the
		player:
		* Is is in jail
		* Has to chose how to pay tax
		* Can not afford to buy an estate
		* Is not solvent
    More automation is planned for when the server sends better
		information.
The patch works together with the file eventsrc which is also
provided.
Comment 3 esigra 2003-02-17 17:45:02 UTC
Created attachment 979 [details]
This eventsrc belongs together with the patch above
Comment 4 esigra 2003-02-22 18:23:13 UTC
Created attachment 1028 [details]
My complete diff against KDE_3_1_BRANCH  

This adds more automation (auto bid in auctions) and some features that require
server patches. I also added a lot of "const"s to the trade code when hunting
segfaults.
Comment 5 Rob Kaper 2003-07-14 02:18:03 UTC
Gee, there's a lot more in your patch than I though. Never noticed all of this. Will 
start merging once KDE 3.1.3 is out of the way. 
 
Comment 6 Mathieu Jobin 2003-10-31 13:51:40 UTC
Sorry, it that been implemented into current CVS ? in HEAD ?
Comment 7 Rob Kaper 2003-11-16 20:51:16 UTC
Reassigning to myself. 
 
Comment 8 Rob Kaper 2003-11-25 08:18:23 UTC
It's not applied yet, but I've seperated out the auto-play stuff at least. One thing that bothers me is that it should probably depend on whether players in jail get rent or not.

As more customizations enter monopd it will be increasingly tough to maintain a decent auto-play, I'm afraid. :-(

As for the estate information: it appeared to me this needs some changes to EstateDetails first, allowing to make a distinction between a user event (showing all details) and calls from travering the board (the existing details there already annoy me when playing).
Comment 9 Jonas Vejlin 2009-04-25 17:32:30 UTC
As far as I know there is not kde 4 version of this game. Should it be "unmaintain" instead?
Comment 10 FiNeX 2009-09-07 15:26:46 UTC
After asking to all the old atlantik developers the current status of the project I've got no positive feedback. Being the project in "unmantained" tree since a lot of time I've moved all atlantik/atlantikdesigner bugs to "RESOLVED-UNMANTAINED".